From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 641E3A04DD;
Fri, 20 Nov 2020 18:27:08 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CFCA9DED;
Fri, 20 Nov 2020 18:27:04 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 7846323D
for <dev@dpdk.org>; Fri, 20 Nov 2020 18:27:02 +0100 (CET)
IronPort-SDR: saLyrTU+FWCOXedCYDh3D1ljTMWu7LJR0a+Q19KVY9BidTsLlzCa6iW0YbGWQyEbJjTjzZ5SMl
jL9BzKaYN8hg==
X-IronPort-AV: E=McAfee;i="6000,8403,9811"; a="256219734"
X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="256219734"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
20 Nov 2020 09:27:00 -0800
IronPort-SDR: MTxw1vPv60L2soHZx3oQIbNSa1HyN1o0q/GvBWsVrSjN1fGvyKZ9RRvhy9Tdoj1VSvnLpLjFVf
boQUypDOK4BA==
X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="331385489"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.199])
([10.213.243.199])
by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
20 Nov 2020 09:26:58 -0800
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com
References: <531504ce-0547-48c2-4e34-c2ed6cb12e57@intel.com>
<1605873002-51934-1-git-send-email-humin29@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com>
Date: Fri, 20 Nov 2020 17:26:55 +0000
MIME-Version: 1.0
In-Reply-To: <1605873002-51934-1-git-send-email-humin29@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping
configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 11/20/2020 11:50 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, the queue stats mapping has the following problems:
> 1) Many PMD drivers don't support queue stats mapping. But there is no
> failure message after executing the command "set stat_qmap rx 0 2 2".
> 2) Once queue mapping is set, unrelated and unmapped queues are also
> displayed.
> 3) The configuration result does not take effect or can not be queried
> in real time.
> 4) The mapping arrays, "tx_queue_stats_mappings_array" &
> "rx_queue_stats_mappings_array" are global and their sizes are based on
> fixed max port and queue size assumptions.
> 5) These record structures, 'map_port_queue_stats_mapping_registers()'
> and its sub functions are redundant for majority of drivers.
> 6) The display of the queue stats and queue stats mapping is mixed
> together.
>
> Since xstats is used to obtain queue statistics, we have made the following
> simplifications and adjustments:
> 1) If PMD requires and supports queue stats mapping, configure to driver in
> real time by calling ethdev API after executing the command
> "set stat_qmap rx/tx ...". If not, the command can not be accepted.
> 2) Based on the above adjustments, these record structures,
> 'map_port_queue_stats_mapping_registers()' and its sub functions can be
> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters,
> and 'parse_queue_stats_mapping_config()' can be removed too.
> 3) remove display of queue stats mapping in 'fwd_stats_display()' &
> 'nic_stats_display()', and obtain queue stats by xstats.
> Since the record structures are removed, 'nic_stats_mapping_display()'
> can be deleted.
>
> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error")
> Fixes: 013af9b6b64f6 ("app/testpmd: various updates")
> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue")
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
Overall looks good to me.
I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info'
app still can be used to get queue stats and "set stat_qmap ..." is working as
expected.
But it is a little late for this release cycle, would you be OK to get this at
the beginning of next release?