From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 056B242C4E; Wed, 7 Jun 2023 16:08:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A98A40ED5; Wed, 7 Jun 2023 16:08:17 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65]) by mails.dpdk.org (Postfix) with ESMTP id A836E40A84 for ; Wed, 7 Jun 2023 16:08:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFP1EzCF5rMTitnrfFWJ9b9Jk066qc161Nvewn0tZ16VWm5NhKEfDEizUsRgDrXKCXNQH8oyNAWVxfNupw2iNuKal2fwsJSwJSa8zrKpqE51AfRzL9OS7TBaKRydvSzk7syWDaCCjJeIbSyP1hoax3ylEH9but2tZjvVfLDVxN6pxS+ROqz9kJfeHA7gQgt5TOe0avrpOrmof/uLZhTuiTXtHnHH/GFQPyjliFdB4aiHL4L55VX7x2f3GgBC9xxI92EtZwnt5NsvaRcy27WO3Q34H05s/zRWDZCVtAKryCIDKxw8AjyUYPfummJvftMuYynexNHNnrfA7AK5FE0l5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeZpzjBOVa0nd5MPzI9ZB5wZ7H5Fk0AZSqXMctieQ2k=; b=m3RihU+KQstvPtpkgXOj56ynJBlHhLfZlWPjmfhqoiex92gHYfIeLSxHOzL/e1ttATTo56wshNWUo1zmkkrapFPB2VxxEPU77LxqqmydXNOQW04rpVHEkbqeRhNYtAcaRr66wmUk+lOnc/Pqo5cwy8uHed8s8teoIlmjhX9Rk+zjRw2wZdmy4j9Q2GcrsQg712dqH1ztc9P54cVGigCV+1pm+1Nx2NUtNO4zqdEopnGUrhY6i1H9+wqVDjdEERMwLwsFU6/pE9Tzz1YeWoRYFr8HgBR/qX4oTcVa7geoZQxBbcoicjaN8pqBndPlF55ao+LTjmzlZJdYwODH3N8ZmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qeZpzjBOVa0nd5MPzI9ZB5wZ7H5Fk0AZSqXMctieQ2k=; b=RCUlYIVxBGje4p9LKHWMCKNYH235drOUEkaEHLTulXLBZ5GcPJbPNrlz//Vj9PVaIkD046vnu2n8ht69nygxM3kVg6W+pviLc5dS/NBpEUSFnomW9/RZYr/9wR1K658cptfQsyKDk6qkcWeDTDOz0kK1FKNvDNcrTGpgF56oO+8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5127.namprd12.prod.outlook.com (2603:10b6:208:31b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Wed, 7 Jun 2023 14:08:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Wed, 7 Jun 2023 14:08:12 +0000 Message-ID: <94c71918-31bf-9564-8c55-4404d2813abc@amd.com> Date: Wed, 7 Jun 2023 15:08:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Jie Hai , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230530090510.56812-1-haijie1@huawei.com> <20230607074209.4798-1-haijie1@huawei.com> <20230607074209.4798-12-haijie1@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH v2 11/13] ethdev: support telemetry query RSS info In-Reply-To: <20230607074209.4798-12-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0654.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5127:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ad4b55a-8399-4017-4c04-08db6760a127 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frTxgjYZJFXyM40ccPQj9boZocKWRw57ipClX2c2SkHyQEGX3kRhDo1sIdOvgMohL0QDorIgBwjjCnr44HJWl83WrCe61e7Dhzex2zMWUsjvGHhzxPDCLKxbyaHlI4q5FSbvIbfL6uBIVn32/SDboYEdTawrrQmF0M8c1L/YSFH32A0ydTt02AD2meBmjQrB74EIW8BP3txrqIpq2EhVvOld6NTU6xJhsoQRS1hlH243qnvIEkSBjFLwl1+2Z3kI8m+QQd55SmXqvnH0d/AEXprZJOk+43n1WqpHiHfL2igoJcj8dygo9aNJHbIYk2XjmESzMrhHYNRddATDujR0Xhr8fe5PrWOmeLKFaIuMA6HTKEhZOKg6zpyMuiBIn6e9Jk6ZugfuGjsyZ96k1lWAsd2Tcvs9WXUl4FdzVrtPpfumI9bkCuo7Z6x1sGgJLH4zeiY893d7uV03tiXrXR3cOezC+/tw/NqUZ4unG+w/6hLqdrbPvzcxay0GTG66fmcj9A9sRLWnSgjqymap/gxapDsMXNcW27IcxUQ3YIbgAyhApWgIad2MZTt3MIkH8ymuFwqNc+srO4qnw7PZHRDa3U9iwuF7gU8YRIP8HwTnPXlL4vIhHbcj6MtBsisNTPD1+ZEhO0IeARzRfZbXopRd4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(451199021)(86362001)(5660300002)(186003)(31696002)(31686004)(110136005)(26005)(6506007)(53546011)(2906002)(36756003)(44832011)(41300700001)(8676002)(316002)(8936002)(6512007)(66946007)(66476007)(66556008)(38100700002)(6486002)(2616005)(478600001)(6666004)(83380400001)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1JZMzFqeWx0WFBzdDhQSDJZdy91VU5YanZzS2JObHoveEQ5N3hFNkhDZHJD?= =?utf-8?B?Q2FhZnlidUNJVFZxK3l2cjVIbmpyS2h5ZUd5eG1ST3dyN1lqcTNrQW9sZFBi?= =?utf-8?B?cXEvTlVBSzBZeTk2ZisrYnlJNGxVR3ZjVnR5MHNEVXRWelFTeEo3dVI3ZGlz?= =?utf-8?B?SEZPSWlicmVtb0NpTitJUEVTbW03UVFoNHM0TmRuTktiYXlDbWxIMFN3b2ta?= =?utf-8?B?TWJ6VG9CeDEvZ1IzcWJHMXZTU0RlN0hlWVNQTFo4OXZaZ3JOYlFZNSt0QWFK?= =?utf-8?B?RkpCeU5jZDBkVnE0bnVwWG9HTVk4MW9jcjNaY3dDVVJ3c0JWbEVKcGdUTXE2?= =?utf-8?B?Vm9XaGM1SEVUTE5UN1BIUENXR3hqRkJ3ejdjaUxmOHN1M3ErdWZlK09nZU5s?= =?utf-8?B?QjR4Y0pRUWdtK3NZSzZ2djhWcm41MXJrWUN0aGFqalQ5Qm5RckRZRnVIYTR6?= =?utf-8?B?Mi94MDRIQTcxd2VzbXh4TUtBWFFzL3dhVjBSbTNRU1REVmlhKzJZK2tVaks0?= =?utf-8?B?c21xU0pyb3lqcXg4Zll3ODV4YjBKaUMzOEhGN0ExTXkyM3h0TUQ3b1BxWTls?= =?utf-8?B?aFhOaWlPQzZaWnZxOSs5a25GOUt6VTVodWFNTnJxbWVlbndwQWY0MEF4L0Jp?= =?utf-8?B?KzM2dHJvSlpIZzZoU0dhaVYvM2JjOFZwWE4xL0lURzBKaHlOZzEyMjBUMmw0?= =?utf-8?B?aEdlNDNqOVR5cUUyeHBIaDFlcW9PNWFDbEFrdHRiSTlVQ2VvNitxeVhHUVRU?= =?utf-8?B?RXJyMU9aRkVicnpqK1pQY2IyN0ZweHlNeHRtMUllV3lNRkV0bjQvZVpzMVN6?= =?utf-8?B?ZXRJREdyZzMwMGlySW1LOWp4VzA1SlVYSWI2QmFRQ1RPRkFQYWZiZmN6cmNt?= =?utf-8?B?aTNIM3QxYzcwcWYvV1BmZ0ZLWHFBTGx3a2FXY2hrRzE4Yy83Y1c4S0IvODd6?= =?utf-8?B?Rm9zdWR2ZnlvbnJKaTlkcnF6RmdaMzlVRWFVTVk1WTB1Q2RPMVg0MDNOU29w?= =?utf-8?B?Z0lVVHNLZFdrZEswc2Q5ZHo4RTMxZXJseTIrRzJSTkV4aVg1NHR4SnNPOWh1?= =?utf-8?B?YzRFVExiVEtDUVZvdXkwanVONHBXMjkzY0p2TDRNMzlmdUh0ak1CSEliVWFs?= =?utf-8?B?RGU5S0xOaWJuQ21IdXJ0Ung0YWRRdkNzTUNVR1FzKytOMEtxUnNBNmdtY3d0?= =?utf-8?B?YlczSDhCbzlqMlJSZTl0dmU1MWNtUEVTS3c1aVduamRtY0hOeGVqSk95eXdS?= =?utf-8?B?amlOSk8yTHpic3FXYWVPQWdDL0tPblFJY3QxRkNoTzFMSU0yaWgyWmVoZ2FV?= =?utf-8?B?RjJDNmd6RUoyVXJrZld5MU95ODJDSm5JdCtrOTRrTSt0bkJUL0lNNCtUNU9P?= =?utf-8?B?TjdRRmQyNk5CWE10Vk1tR05Ld2dvWUtQL0hYakRkbDM2aUZ1d3BMSE12Mlhp?= =?utf-8?B?eUJ4OGcvR2dLTHMzbHMvdlRQVGIzYnRFNGJKRkQ5UmkvQk45U1F4blp1YVUz?= =?utf-8?B?ZkpqUGdrTnFjelNaMkE0aEIzcER5M0ZDTE53VDRsd3VDaDlhQk9jS0N5Rldx?= =?utf-8?B?UXptT2ZPWWhQVnlTaXFPTkhIZ3FVWUMyNGJJME12YktvWWZ1UWRpaXlYazVr?= =?utf-8?B?dTdVbDcxM3VqOHhKZWVrYzkyRkxDRkVDVHB1aHVCU2p5WXR6bmdKb05lS3dq?= =?utf-8?B?WDQ0aytSaWhGOTBlOEt6dUs0VkZnTjQwMGwvODBrUUNNZUowd0VCZmQ0QzFR?= =?utf-8?B?bnNZeHRjVzYrSXEzQ2lJRUhXcnZHK3Z0Njh0WnhYTnhOWWx0Q3U4RmI3R2Ez?= =?utf-8?B?WlFDQXg0blZndVFYTG9tL2xsRlFyNWw3a2NXZDkzSmxybGNPRXpJb252QjVL?= =?utf-8?B?RGk5WHdZNGIwL2VSMlRxTmRIMW14NGpZd2llZkVBWFRNY3JLZ3JzSmNJY3lp?= =?utf-8?B?dE00QmNhK0xSdGNETFI1SStlSkNUL25QMXFZc1k1UjRxWEFTbXBxSXRscits?= =?utf-8?B?a2VZNnBHbE5JVWpQUWtUbEg2S084YkpuVnhQa2ZEQjE0YjdyY2xwZ04vc0Ns?= =?utf-8?B?VDJhUFpoMmoySTFQaU84KzljdGRDb2E5bXROVm1ZbXNEN2h3bGxYVzVPZjVZ?= =?utf-8?Q?bnIt5gV9WqZJKLVSrCm9fmi76?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad4b55a-8399-4017-4c04-08db6760a127 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 14:08:12.4422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 60if22qhe1eklI3L+ng6jsM9YZL/xyPgsiC1S6hGBGOw70n0UmJ41zp+n4ZL4W26 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5127 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 8:42 AM, Jie Hai wrote: > This patch supports querying RSS info by telemetry command. > The command is like: > --> /ethdev/rss_info,0 > { > "/ethdev/rss_info": { > "rss_hf": "0x238c", > "rss_key_len": 40, > "rss_key": "6d5a56da255b0ec24167253d43a38fb0d0ca2b\ > cbae7b30b477cb2da38030f20c6a42b73bbeac01fa" > } > } > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev_telemetry.c | 79 +++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c > index d0d55993102b..d42901fe57b1 100644 > --- a/lib/ethdev/rte_ethdev_telemetry.c > +++ b/lib/ethdev/rte_ethdev_telemetry.c > @@ -706,6 +706,83 @@ eth_dev_handle_port_dcb(const char *cmd __rte_unused, > return eth_dev_add_dcb_info(port_id, d); > } > > +static int > +eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d) > +{ > + const uint32_t key_len = rss_conf->rss_key_len * 2 + 1; > + char *rss_key; > + char *key; > + uint32_t i; > + int ret; > + > + key = malloc(key_len); > + if (key == NULL) > + return -ENOMEM; > + Key is to hold only char representation of single byte, so it doesn't need this much space and no need to dynamically allocate/free small space, hence updating in next-net as following: ``` diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c index c64045cb1dad..f246a03e2966 100644 --- a/lib/ethdev/rte_ethdev_telemetry.c +++ b/lib/ethdev/rte_ethdev_telemetry.c @@ -723,19 +723,13 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d) { const uint32_t key_len = rss_conf->rss_key_len * 2 + 1; char *rss_key; - char *key; + char key[3]; /* FF\0 */ uint32_t i; int ret; - key = malloc(key_len); - if (key == NULL) - return -ENOMEM; - rss_key = malloc(key_len); - if (rss_key == NULL) { - ret = -ENOMEM; - goto free_key; - } + if (rss_key == NULL) + return -ENOMEM; rte_tel_data_start_dict(d); rte_tel_data_add_dict_uint_hex(d, "rss_hf", rss_conf->rss_hf, 0); @@ -743,7 +737,7 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d) memset(rss_key, 0, key_len); for (i = 0; i < rss_conf->rss_key_len; i++) { - ret = snprintf(key, key_len, "%02x", rss_conf->rss_key[i]); + ret = snprintf(key, 3, "%02x", rss_conf->rss_key[i]); if (ret < 0) goto free_rss_key; strlcat(rss_key, key, key_len); @@ -752,8 +746,7 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d) free_rss_key: free(rss_key); -free_key: - free(key); + return ret; } ``` > + rss_key = malloc(key_len); > + if (rss_key == NULL) { > + ret = -ENOMEM; > + goto free_key; > + } > + > + rte_tel_data_start_dict(d); > + rte_tel_data_add_dict_uint_hex(d, "rss_hf", rss_conf->rss_hf, 0); > + rte_tel_data_add_dict_uint(d, "rss_key_len", rss_conf->rss_key_len); > + > + memset(rss_key, 0, key_len); > + for (i = 0; i < rss_conf->rss_key_len; i++) { > + ret = snprintf(key, key_len, "%02x", rss_conf->rss_key[i]); > + if (ret < 0) > + goto free_rss_key; > + strlcat(rss_key, key, key_len); > + } > + ret = rte_tel_data_add_dict_string(d, "rss_key", rss_key); > + > +free_rss_key: > + free(rss_key); > +free_key: > + free(key); > + return ret; > +} > + > +static int > +eth_dev_handle_port_rss_info(const char *cmd __rte_unused, > + const char *params, > + struct rte_tel_data *d) > +{ > + struct rte_eth_dev_info dev_info; > + struct rte_eth_rss_conf rss_conf; > + uint16_t port_id; > + char *end_param; > + int ret; > + > + ret = eth_dev_parse_port_params(params, &port_id, &end_param, false); > + if (ret < 0) > + return ret; > + > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) { > + RTE_ETHDEV_LOG(ERR, > + "Failed to get device info, ret = %d\n", ret); > + return ret; > + } > + > + rss_conf.rss_key_len = dev_info.hash_key_size; > + rss_conf.rss_key = malloc(dev_info.hash_key_size); > + if (rss_conf.rss_key == NULL) > + return -ENOMEM; > + This patch cause telemetry unit test failure, because some pmd's provide '0' as 'dev_info.hash_key_size', hence updating as following which sets key size as 40 if 'dev_info.hash_key_size' is 0: ``` @@ -764,6 +757,7 @@ eth_dev_handle_port_rss_info(const char *cmd __rte_unused, { struct rte_eth_dev_info dev_info; struct rte_eth_rss_conf rss_conf; + uint8_t key_len; uint16_t port_id; char *end_param; int ret; @@ -779,8 +773,9 @@ eth_dev_handle_port_rss_info(const char *cmd __rte_unused, return ret; } - rss_conf.rss_key_len = dev_info.hash_key_size; - rss_conf.rss_key = malloc(dev_info.hash_key_size); + key_len = dev_info.hash_key_size ? dev_info.hash_key_size : 40; + rss_conf.rss_key_len = key_len; + rss_conf.rss_key = malloc(key_len); if (rss_conf.rss_key == NULL) return -ENOMEM; ``` > + ret = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); > + if (ret != 0) { > + free(rss_conf.rss_key); > + return ret; > + } > + > + ret = eth_dev_add_rss_info(&rss_conf, d); > + free(rss_conf.rss_key); > + return ret; > +} > + > RTE_INIT(ethdev_init_telemetry) > { > rte_telemetry_register_cmd("/ethdev/list", eth_dev_handle_port_list, > @@ -735,4 +812,6 @@ RTE_INIT(ethdev_init_telemetry) > "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)"); > rte_telemetry_register_cmd("/ethdev/dcb", eth_dev_handle_port_dcb, > "Returns DCB info for a port. Parameters: int port_id"); > + rte_telemetry_register_cmd("/ethdev/rss_info", eth_dev_handle_port_rss_info, > + "Returns RSS info for a port. Parameters: int port_id"); > }