From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E7EFA057C; Thu, 26 Mar 2020 15:04:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50D5F2BAE; Thu, 26 Mar 2020 15:04:40 +0100 (CET) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 11DD71AFF for ; Thu, 26 Mar 2020 15:04:38 +0100 (CET) Received: by mail-lj1-f194.google.com with SMTP id v16so6466117ljk.13 for ; Thu, 26 Mar 2020 07:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=VsaiNwqIkPC1nT525jraZKdZC6zEo7YQ4u2WEbIrEZo=; b=dHkEzQxLHJFIB1dnTkk+WfWcNlStftxZlQl4dz+6pwLbyoBWdbW7PFmcn36tQXD0Qq xFQVUcaZhXdx9CV/P9oNzc/Ymv9lCG7Xsem5N24N24k0nygzYXfY7dBZ/MBuNnDBz950 GxXf+YY0zOuwtchi/ZVebtmf+w2YVKC7Go14mFVfCcXD0HM8Zw5HkPV6BqM6NQZHUMxt yvEPkVHpfoYEOmcDGGRmv6YvuzlQsI3FroDU/trKFc8pphjxBic9uRM25fnBHubKm4H6 aZBzo8dojE9tD2K7x7m9enqOgCBKLHIuHWef6pMQCVEbFsghV5gFpgyeA2iFpEjNVu7I w63A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VsaiNwqIkPC1nT525jraZKdZC6zEo7YQ4u2WEbIrEZo=; b=qeKnIU0x3C7hirnw7q7f+nM6fei64HrBQF627ITdsgolc47bxNjQafjRsyEkxbPoEs Pdh16PRckRxLde6QCcdnfXRpTxgj6n4dXfrzyAdhgx7asL0gI7+rE9McCv+V/2iFaG/I V8Ag1pM2+dKWoo2YbLuk3FVjXx5GdUYbkr3LsSeXoepiWx+vDuvv80qexuz5tJvJ226g eL/SSXtPxwlthQFLZDaUWCBIY8nXf81aDDX0SX4r6kJ7uKxIuWEJtoc+fnf5FPPR0/2F qM92w+IIlL5KCwSBTxjv61NeE9H9d6IlnZWJS3OmxRxg0PqUmvVMWVYxOW6domyN5UEN O/fg== X-Gm-Message-State: ANhLgQ20bhNUfBawIbTCxd8GiZROSCdTxcj58G4X5O7j1JF0Jgerj1H3 4R+NDtxf8Bo0KVqmBRAYpdXxHtfu2Opmmw== X-Google-Smtp-Source: APiQypLjfJ6YfVf3RtQ+6qIGoETYhbjwIHXqGCTTuLh6LMBNB+LKH/WlVVo02PbAAPDoe75F2iXLqg== X-Received: by 2002:a2e:b5ce:: with SMTP id g14mr5309653ljn.25.1585231477163; Thu, 26 Mar 2020 07:04:37 -0700 (PDT) Received: from [192.168.8.100] (user-5-173-56-20.play-internet.pl. [5.173.56.20]) by smtp.gmail.com with ESMTPSA id r23sm1549263lfi.89.2020.03.26.07.04.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2020 07:04:36 -0700 (PDT) To: dev@dpdk.org References: <20200303181817.3448334-1-ferruh.yigit@intel.com> <20200313145200.3257043-1-ferruh.yigit@intel.com> From: Andrzej Ostruszka Message-ID: <94d1026d-814c-a1f9-c80e-2126f5c75520@semihalf.com> Date: Thu, 26 Mar 2020 15:04:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200313145200.3257043-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] log: add API to check if a logtype can log in a given level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/13/20 3:51 PM, Ferruh Yigit wrote: > This is a helper function in case components would like to do more work > than just logging a message based on log level, like for example > collecting some stats if the log type is DEBUG etc.. > > A few existing relevant usage converted to this new API. > > Signed-off-by: Ferruh Yigit > Acked-by: Hyong Youb Kim > Acked-by: Hemant Agrawal > --- > Cc: David Marchand > Cc: Thomas Monjalon > Cc: Stephen Hemminger > > v2: > * Convert API return type to 'bool'. Removed custom definitions from > 'ionic' PMD for this. > > v3: > * Update function comment > * Use new function in `rte_vlog()` > --- > drivers/bus/fslmc/fslmc_bus.c | 7 +------ > drivers/common/qat/qat_logs.c | 7 ++----- > drivers/net/enic/enic_fm_flow.c | 2 +- > drivers/net/mlx5/mlx5_mr.c | 2 +- > lib/librte_eal/common/eal_common_log.c | 22 +++++++++++++++++--- > lib/librte_eal/common/include/rte_log.h | 14 +++++++++++++ > lib/librte_eal/rte_eal_version.map | 3 +++ > lib/librte_flow_classify/rte_flow_classify.c | 7 ++----- > 8 files changed, 43 insertions(+), 21 deletions(-) Ferruh I like this and would like use it for the next round of my patches. Is there any timeline for that? With regards Andrzej Ostruszka Reviewed-by: Andrzej Ostruszka