From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C645A0C43; Wed, 20 Oct 2021 11:47:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26031411BB; Wed, 20 Oct 2021 11:47:47 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 966BC40142 for ; Wed, 20 Oct 2021 11:47:45 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HZ5Mn1P3Bz1DHZ2; Wed, 20 Oct 2021 17:45:57 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 17:47:43 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 17:47:43 +0800 To: David Marchand , CC: Ray Kinsella References: <20211020065944.19617-1-david.marchand@redhat.com> From: fengchengwen Message-ID: <9510b844-5aec-43e6-b324-2358a4f52042@huawei.com> Date: Wed, 20 Oct 2021 17:47:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211020065944.19617-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/10/20 14:59, David Marchand wrote: > No need to expose rte_dma_devices out of the dmadev library. > Existing helpers should be enough, and inlines make use of > rte_dma_fp_objs. > > Signed-off-by: David Marchand > --- > app/test/test_dmadev.c | 5 +++-- > lib/dmadev/rte_dmadev.c | 2 +- > lib/dmadev/rte_dmadev_pmd.h | 2 -- > lib/dmadev/version.map | 1 - > 4 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > index 1e327bd45f..8b58256afc 100644 > --- a/app/test/test_dmadev.c > +++ b/app/test/test_dmadev.c > @@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id) > }; > const int vchan = 0; > > + rte_dma_info_get(dev_id, &info); suggest declare info as: struct rte_dma_stats info = { 0 }; so that the following %s will display NULL if rte_dma_info_get call fail. anyway, Reviewed-by: Chengwen Feng > + > printf("\n### Test dmadev instance %u [%s]\n", > - dev_id, rte_dma_devices[dev_id].data->dev_name); > + dev_id, info.dev_name); > > - rte_dma_info_get(dev_id, &info); > if (info.max_vchans < 1) > ERR_RETURN("Error, no channels available on device id %u\n", dev_id); > > diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c > index 182d32aedb..d4b32b2971 100644 [snip]