From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 439B4A00C4; Sun, 27 Feb 2022 19:07:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC0514068A; Sun, 27 Feb 2022 19:07:24 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id AA9F240683; Sun, 27 Feb 2022 19:07:23 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 482565C004A; Sun, 27 Feb 2022 13:07:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 27 Feb 2022 13:07:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=B2uXLRkc5m9Qtd kwCiFb25RADMfkq/UGd6AJRY7joD8=; b=pschJoJuD/Ck9y13LQARsmnUErIyEL cARcKXE/EbGg7HW7s6hxO4v2ha2WLex/9YRlT77OQxqGZGREjZFCKFNA6d7LPPgp CMNWmG7xUItr4HVIkHEERh/13otO72kGIaKkPNTObTpo4iRu7PqUsoicMmQpR+b8 lkmaASog7swO88CDHJp4SD57rpcExVSHCymgcAxNVP5mTBOz21Gcu4YN+8pauhAe myIG0hmeK5LFkOrpghp3wfs+pVahQI46B//PrlwBSU9GeKMWBifrurqex9CilawJ 6ZxCxjmXC0F6bu6/QLsHdsa/25roEeIbYq3waNA96o8/sznRPLjCnCGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=B2uXLRkc5m9QtdkwCiFb25RADMfkq/UGd6AJRY7jo D8=; b=ARWXd8kLhn+93FvDG9+9NqqZroNG0oPuMePfVPcX4Ihcf7o07boaCWW5u 0lnRJBaXc7CwtatIMhe+Hg+O/HXDxv4xwa6v3DDRDWR3Wn3couXuB5SdilBjHHsQ FIszuQE6WjVMSxQaEdoMPMp0a6V5u3IV4zh6/eCEThxczTCNfEZBhiriaYnh9UVn eHEr81YNO0H6yD5eAm7BnUBtJOoOrzLEOG4lfz1xjX3HB/j+K6i0ygCPwUjam7eV wL5FnQOhMnq/BT1q/h06AzOKppsuOKvr1gXNYann6r3ACIxRaNJBZYRGLzoXycR8 WnFPfmP081vESnHsaA9c1n1pCV3gQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Feb 2022 13:07:21 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, David Hunt Subject: Re: [PATCH] distributor: fix potential overflow bug Date: Sun, 27 Feb 2022 19:07:20 +0100 Message-ID: <9516596.EvYhyI6sBW@thomas> In-Reply-To: <153e9fb1-8568-1c82-0281-ca74bce0376d@intel.com> References: <20220217150239.69876-1-bruce.richardson@intel.com> <153e9fb1-8568-1c82-0281-ca74bce0376d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/02/2022 16:24, David Hunt: > Hi Bruce, > > On 17/2/2022 3:02 PM, Bruce Richardson wrote: > > Coverity flags the fact that the tag values used in distributor are > > 32-bit, which means that when we use bit-manipulation to convert a tag > > match/no-match to a bit in an array, we need to typecast to a 64-bit > > type before shifting past 32 bits. > > > > Coverity issue: 375808 > > Fixes: 08ccf3faa6a9 ("distributor: new packet distributor library") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > LGTM > > Acked-by: David Hunt Applied, thanks.