From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DD04A0524; Fri, 14 May 2021 13:19:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0143F40042; Fri, 14 May 2021 13:19:34 +0200 (CEST) Received: from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 128B840041 for ; Fri, 14 May 2021 13:19:33 +0200 (CEST) Received: from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw02.pantheon.sk (Proxmox) with ESMTP id 938FA18390A; Fri, 14 May 2021 13:19:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=sKtnPkiio6f6w+IceHTW LuagqWg6DXJOZxRggr8urfg=; b=X+rkIxVNceXErr+de8c9U0mJorHJt4dwamqs 6odY3Tcci/1oS570Yw27tCP+DYn3YPqAG+1McyhI9XSKdQ53kiQv3zH5P14PK5Jo KPlyUO4qlpIKSHYCX6hvudzFf9VTno9kjj59mUCfPmuS80cYWwdiyKIpwQF/s4S+ zDc4Klt3dygKUGAIYPMqtefiZtrKHMTICsTjW7dPR4cLOEbACJNUzS7Rk4c/iwa+ vALaECkNI9SMhJVJ+zYatZ+PwqI4asqyzNkaIypsF4PjHolj10eFozeM/FKuJqSU UoRabcW3ukx2f4iscZoXbim0UNJXKh0HIn5l6DYREEsXMQBrRw== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Pavan Nikhilesh Bhagavatula , "Honnappa Nagarahalli" , "thomas@monjalon.net" CC: Jerin Jacob Kollanukkaran , Jan Viktorin , Ruifeng Wang , "Bruce Richardson" , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions Thread-Index: AQHXRcTCFROA70whWE6qWqLNflce9qrdFFeAgAAFcACAAMBqgIAAiSaAgAAcogCAAA6lgIAA45aAgANnoWA= Date: Fri, 14 May 2021 11:19:29 +0000 Message-ID: <95179e29b4cc4bda8708845f9e7c3cc3@pantheon.tech> References: <20210505121423.850-1-pbhagavatula@marvell.com> <1699304.vFISr3HHSL@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, May 12, 2021 11:18 AM > To: Honnappa Nagarahalli ; > thomas@monjalon.net > Cc: Jerin Jacob Kollanukkaran ; Juraj Linke=B9 > ; Jan Viktorin ; Rui= feng > Wang ; Bruce Richardson > ; dev@dpdk.org; nd ; nd > > Subject: RE: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to expr= ess > arch extensions >=20 >=20 > > > > > >> > >> >> >> > >> >> >> > > >> >> >> > The patch still holds true for CRC though as it is listed > >> >> >> > separately below > >> >> >> > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > >> >> >3A__developer.arm.com_architectures_cpu-2Darchitecture_a- > >> >> > >>2D&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DE3SgYMjtKCMVsB- > >> >> >fmvgGV3o- > >> >> > >> > >>>g_fjLhk5Pupi9ijohpc&m=3Di3kC8htMiHjXMoJWUn6QlDVZQCblbFrIJyMc > >> >W > >> >> > >> > >>>d9nAmM&s=3DfA4SM6O3iC2HXIK1qSbOHzxVeHoYqcfUebEOwioHC7c& > >e > >> >=3D > >> >> >> > profile/exploration-tools/feature-names-for-a-profile > >> >> >CRC is mandatory starting in V8.1, refer to Arm-ARM document. > >> >> > > >> >> >> > > >> >> >> > Also, looks like sve2 support in n2 core might be optional as > >> >> >> > per > >> >> >above doc? > >> >> >> I need to check on this. Some of the info here might not be > >public > >> >yet. > >> >> >I found [1]. SVE2 is mandatory feature. > >> >> > > >> >> > >> >> I see thanks for the info I will remove extension from cnxk. > >> >> > >> >> Do you think the extension infra is still useful for other cases? i= .e. > >> >older cores > >> >> or cases where vendor wants to enable some extensions by > >default? > >> >> > >> >> I found a document[1] which describes about extensions not > >enabled > >> >by > >> >> default but supported by a given march. > >> >> In case of n2 I think memory tagging is one such feature > >> >I think the reference is providing a different information than what > >> >you are trying to achieve here. > >> > > >> >It looks like you are trying to address a use case where in the same > >> >CPU IP has different features enabled/disabled on different SoCs. > >> >This is a valid use case from crypto perspective (due to export > >control > >> >reasons) where-in 2 different SoCs might have crypto > >enabled/disabled. > >> >I am not sure if other features can be enabled/disabled. But, Crypto > >> >feature is a good enough reason to address such a use case. > >> > >> Yes, that's my intension apologies if the commit log doesn't clarify > >> it > >properly. > >> > >> > > >> >IMO, we should capture the SoC specific details in SoC specific > >> >files, in this case in 'arm64_cn10k_linux_gcc'. I believe there were > >> >some challenges in doing this. > >> > >> Since, all the flags are populated through soc_* variable and > >> arm64_cn10k_linux_gcc also translates to soc_cn10k I believe the > >extensions > >> should be reported through > >> soc_* variables. > >IMO, there will be more SoCs in the future. I prefer to not grow > >meson.build. >=20 > Problem is native build wouldn't read arm64_*_linux_gcc, it will be reall= y hard to > parse it and read extensions if they are placed there. >=20 Yes, this is the reason we have the SoC configuration in meson.build and no= t anywhere else. In meson 0.47.1, it was the only way to use SoC config in = both native and cross builds. This implies that even these arch extension w= ould need to in meson.build so that we could use those for both native and = cross builds. > >> > >> Also, do you think +crypto needs to be removed from default n2 > >config as its > >> optional? > >Agree. Better to move it to SoC specific configuration. > > > >> > >> >Juraj, do you remember the exact issue? > >> > > >> >> > >> >> [1]https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > >> >3A__developer.arm.com_tools-2Dand-2Dsoftware_open-2Dsource- > >> >2D&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DE3SgYMjtKCMVsB- > >> >fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=3D0oZnXDnO- > >> > >>oYL9lESEaZt_nH_kK8Nc3m0tvdEPpKeFZc&s=3DWxrPoWhkM2QIFGEKezP > >K > >> >D9oEn7nGFvvgS2ul9ZYx-Kg&e=3D > >> >> software/developer-tools/gnu-toolchain/architecture-support > >> >> > >> >> > >> >> >[1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > >> >> >3A__developer.arm.com_ip- > >> >> >2Dproducts_processors_neoverse_neoverse- > >> >> > >> > >>>2Dn2&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DE3SgYMjtKCMVs > >B > >> >- > >> >> >fmvgGV3o- > >> >> > >> > >>>g_fjLhk5Pupi9ijohpc&m=3Di3kC8htMiHjXMoJWUn6QlDVZQCblbFrIJyMc > >> >W > >> >> >d9nAmM&s=3DkP_X-Co0cl4pZ64BZqy5rAFUlkMZE- > >> >3EhTVBabm3SW8&e=3D > >> >> > > >> >> >