From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E394E4C74 for ; Tue, 11 Sep 2018 11:38:27 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67C23406F8B9; Tue, 11 Sep 2018 09:38:27 +0000 (UTC) Received: from [10.36.112.31] (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3E1E32156701; Tue, 11 Sep 2018 09:38:25 +0000 (UTC) To: Nikolay Nikolaev , tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org References: <153202755842.21481.1772155561595981441.stgit@T460> From: Maxime Coquelin Message-ID: <952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com> Date: Tue, 11 Sep 2018 11:38:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <153202755842.21481.1772155561595981441.stgit@T460> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 11 Sep 2018 09:38:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 11 Sep 2018 09:38:27 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 09:38:28 -0000 Hi Nikolay, On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > vhost: vhost_user.c code cleanup > > This patchesries introduce a set of code redesigns in vhost_user.c. > > The goal is to unify and simplify vhost-user message handling. The > patches do not intend to introduce any functional changes. > > v2 changes: > - Fix the comments by Tiwei Bie > - Keep the old behavior > - Fall through when the callback returns VH_RESULT_ERR > - Fall through if the request is out of range > > --- > > Nikolay Nikolaev (5): > vhost: unify VhostUserMsg usage > vhost: make message handling functions prepare the reply > vhost: handle unsupported message types in functions > vhost: unify message handling function signature > vhost: message handling implemented as a callback array > > > lib/librte_vhost/vhost_user.c | 392 ++++++++++++++++++++++------------------- > 1 file changed, 208 insertions(+), 184 deletions(-) > > -- > Signature > Could you please rebase and fix the series (see Iliya comments) on top of git://dpdk.org/next/dpdk-next-virtio master branch? Thanks, Maxime