From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C39843DA3; Mon, 8 Apr 2024 15:12:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04252402C0; Mon, 8 Apr 2024 15:12:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 03C7B40289 for ; Mon, 8 Apr 2024 15:12:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712581926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRzRHNdbvA9YcCyRhkzbcf/N/pNxWqE54zSJUW9/5RE=; b=WncX1eY2iHuLXJExQsoy2ueG8G44q7cyxY4TO2FUHWRQ35+e5ZRaPqCm78DzcZmhPTApzP ekdmpVZ4KUzTjJX4Wv/KHIGhBLFTqvva15rrQLCtg92kf6es4Xyw6OLFiMvaMVnHnleU6t MGjs9bb1WT+XaValO6YthjtT8474+VE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-jQ12_M5-MAeBqbji90B0kg-1; Mon, 08 Apr 2024 09:12:05 -0400 X-MC-Unique: jQ12_M5-MAeBqbji90B0kg-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-43479131062so20936211cf.3 for ; Mon, 08 Apr 2024 06:12:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712581924; x=1713186724; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QRzRHNdbvA9YcCyRhkzbcf/N/pNxWqE54zSJUW9/5RE=; b=d1vUWEnVB3kQZVNfZP3wGdUFGDv4fsgba4XpIR7f2zmBNd/E7ebGhkZ0vSAcS/QI3x 2LSLAfA4nBlS+A9mquC9Ky24+QfyWymV57EUz+OLCg+vD6OHXIxB3uZv70JWFzlEg4mL 8DoZ7srmYXTM9TAvmdItfvGr71CvTh/3gOPTmYTTifWRkBcxjlIqulDg8+wjgZuafAzZ lNhic9aaVuNMtasB9Kd6CekQZNGzgbQKkmHI2yd9wtwd1rY1T7Y8JNx2e97nMJTFae9I jnjY1BZJltol2bxuxzazNh6J6fL+szsW92DV5hM4Zz8pUTC9i8Vzn5hEQZjqs2CeeSch MjVg== X-Gm-Message-State: AOJu0Yzda+WPwKmfx7yUHerZB6i/B50W4yuKM+9HG1DnXiMyIvwTG3OV iPz/inESxVr4DBJ7yC+kEetufvrsyS4RIiGrHgz4Wfo1SW3KoMlSqMYrm86cwRw/6TFg/6et9Iy iWQWpjSogzTRpgeKq4EnGYsBoUbIgQzb2a5LPlH8x X-Received: by 2002:a05:622a:118b:b0:434:66f7:47a3 with SMTP id m11-20020a05622a118b00b0043466f747a3mr10028481qtk.61.1712581924655; Mon, 08 Apr 2024 06:12:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn5h8OaMMDBQ4Sn/xHvn0n/1txfH4mYNaLj8b3tv4tuX03sHVR8CXwiz9hO7sDF9YuKGtAxA== X-Received: by 2002:a05:622a:118b:b0:434:66f7:47a3 with SMTP id m11-20020a05622a118b00b0043466f747a3mr10028452qtk.61.1712581924379; Mon, 08 Apr 2024 06:12:04 -0700 (PDT) Received: from [192.168.0.12] ([78.19.74.23]) by smtp.gmail.com with ESMTPSA id kr19-20020ac861d3000000b004347dd80b8asm1850739qtb.66.2024.04.08.06.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 06:12:03 -0700 (PDT) Message-ID: <9531ba96-d5e9-49aa-93da-823fc4c76549@redhat.com> Date: Mon, 8 Apr 2024 14:12:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v13 2/3] net/af_xdp: fix multi interface support for K8s To: "Loftus, Ciara" , "ferruh.yigit@amd.com" , "stephen@networkplumber.org" , "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liuyonglong@huawei.com" , "Marchand, David" , "Koikkara Reeny, Shibin" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20240404142326.2151118-1-mtahhan@redhat.com> <20240404142326.2151118-3-mtahhan@redhat.com> From: Maryam Tahhan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08/04/2024 11:46, Loftus, Ciara wrote: >> +#ifdef ETH_AF_XDP_UPDATE_XSKMAP >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx >> __rte_unused) >> +{ >> + return xsk_socket__update_xskmap(xsk, map_fd); >> +} >> +#else >> +static __rte_always_inline int >> +update_xskmap(struct xsk_socket *xsk, int map_fd, int xsk_queue_idx) >> +{ >> + int fd = xsk_socket__fd(xsk); > 'fd' computed here is not used in this function so generates an unused variable warning. Just for clarification on the fix - the 3rd argument to the bpf_map_update_elem() should be that xsk fd. So I will update the code to reflect this: ` return bpf_map_update_elem(map_fd, &xsk_queue_idx, &fd, 0);` Thanks again and great catch. BR Maryam >> + return bpf_map_update_elem(map_fd, &xsk_queue_idx, &map_fd, >> 0); >> +} >> +#endif >> +