From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0446D1B184 for ; Tue, 2 Apr 2019 22:48:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9226C21D35; Tue, 2 Apr 2019 16:48:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 16:48:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XjxA7Y14VCazcyhnEgDzi5QEzu36aHkmH5oG2PKasxY=; b=LdxOxJYGPygZ 3jp6dgyE4BOfDXZP9cgJSvTF7RASwHFB45pLO+5awh8esRBt5nHwt0dd+VxPs/BR hj+Be1wRgyPHC71D8g/d++b7xfQM88EuJDpHbUFz+e2XmfI1limn2Sa4nsEnVyvk bpBDCAPnxGzKv0P9ngfqZUMS8zAxh4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XjxA7Y14VCazcyhnEgDzi5QEzu36aHkmH5oG2PKas xY=; b=qiS1D2SG/XlSLb9UFawiial1Od62X9Lac28+47l7n6xtHUpqblIhp1ZHQ GIERqVcyGN6BB1sac5uCzoYgdTqEmTpiJvk1F2Oy+yfnOCNribF4AHxbnchUu32H RLbrI3fkXmIXpsE92N+Ajvg9YFqqb4jvxP2dOIRTaKtBdTNAjGVqdxNZqntkwdf6 eUnvMceNdSzFfyxO1hBkJdwhFmERmUgp6ZGwdaRunsPsMOKMLjuZT01e/jACYaAi xeeq9wqFm13dW/OpCFamqA/QdXs/1wDGandXfwNSk5USp9pGkAWAvB8GAFHFwXn4 D8PmMR9Z5BKr81TLnSPEAhPyk8c5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgddufeefucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 308A8E43A3; Tue, 2 Apr 2019 16:48:00 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 02 Apr 2019 22:47:58 +0200 Message-ID: <9537388.5AKJxibmNW@xps> In-Reply-To: <2058052.CBssHhMYLK@xps> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> <2058052.CBssHhMYLK@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 20:48:02 -0000 02/04/2019 21:56, Thomas Monjalon: > 02/04/2019 05:54, Anand Rawat: > > Added rte_os.h files to support OS specific functionality. > > Updated build system to contain OS headers in the include > > path. > > > > Signed-off-by: Anand Rawat > > Reviewed-by: Pallavi Kadam > > --- > > --- a/meson.build > > +++ b/meson.build > > -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > > +global_inc = include_directories('.', 'config', > > + 'lib/librte_eal/common/include', > > + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) > > After having worked on rte_kni_common.h which is only in Linux, > I think we should add rte_os.h in meson file of each OS: > - lib/librte_eal/linux/eal/meson.build > - lib/librte_eal/freebsd/eal/meson.build > - lib/librte_eal/windows/eal/meson.build I confirm: "global_inc" is used in "includes" variable but not in "headers" variable, so rte_os.h is not installed as other files in "headers". We must fill "env_headers" which is pulled by: headers = common_headers + env_headers I will fix it before merging in master if you agree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DC99DA0679 for ; Tue, 2 Apr 2019 22:48:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2A081B1A0; Tue, 2 Apr 2019 22:48:03 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0446D1B184 for ; Tue, 2 Apr 2019 22:48:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9226C21D35; Tue, 2 Apr 2019 16:48:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 16:48:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XjxA7Y14VCazcyhnEgDzi5QEzu36aHkmH5oG2PKasxY=; b=LdxOxJYGPygZ 3jp6dgyE4BOfDXZP9cgJSvTF7RASwHFB45pLO+5awh8esRBt5nHwt0dd+VxPs/BR hj+Be1wRgyPHC71D8g/d++b7xfQM88EuJDpHbUFz+e2XmfI1limn2Sa4nsEnVyvk bpBDCAPnxGzKv0P9ngfqZUMS8zAxh4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XjxA7Y14VCazcyhnEgDzi5QEzu36aHkmH5oG2PKas xY=; b=qiS1D2SG/XlSLb9UFawiial1Od62X9Lac28+47l7n6xtHUpqblIhp1ZHQ GIERqVcyGN6BB1sac5uCzoYgdTqEmTpiJvk1F2Oy+yfnOCNribF4AHxbnchUu32H RLbrI3fkXmIXpsE92N+Ajvg9YFqqb4jvxP2dOIRTaKtBdTNAjGVqdxNZqntkwdf6 eUnvMceNdSzFfyxO1hBkJdwhFmERmUgp6ZGwdaRunsPsMOKMLjuZT01e/jACYaAi xeeq9wqFm13dW/OpCFamqA/QdXs/1wDGandXfwNSk5USp9pGkAWAvB8GAFHFwXn4 D8PmMR9Z5BKr81TLnSPEAhPyk8c5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgddufeefucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 308A8E43A3; Tue, 2 Apr 2019 16:48:00 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 02 Apr 2019 22:47:58 +0200 Message-ID: <9537388.5AKJxibmNW@xps> In-Reply-To: <2058052.CBssHhMYLK@xps> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> <2058052.CBssHhMYLK@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402204758.beGz6z7bX3nK2GYRjmutO689jmDsPvp3aMJES201nB0@z> 02/04/2019 21:56, Thomas Monjalon: > 02/04/2019 05:54, Anand Rawat: > > Added rte_os.h files to support OS specific functionality. > > Updated build system to contain OS headers in the include > > path. > > > > Signed-off-by: Anand Rawat > > Reviewed-by: Pallavi Kadam > > --- > > --- a/meson.build > > +++ b/meson.build > > -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > > +global_inc = include_directories('.', 'config', > > + 'lib/librte_eal/common/include', > > + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) > > After having worked on rte_kni_common.h which is only in Linux, > I think we should add rte_os.h in meson file of each OS: > - lib/librte_eal/linux/eal/meson.build > - lib/librte_eal/freebsd/eal/meson.build > - lib/librte_eal/windows/eal/meson.build I confirm: "global_inc" is used in "includes" variable but not in "headers" variable, so rte_os.h is not installed as other files in "headers". We must fill "env_headers" which is pulled by: headers = common_headers + env_headers I will fix it before merging in master if you agree.