From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E4844103; Wed, 29 May 2024 16:29:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EBC5402CD; Wed, 29 May 2024 16:29:36 +0200 (CEST) Received: from wfhigh7-smtp.messagingengine.com (wfhigh7-smtp.messagingengine.com [64.147.123.158]) by mails.dpdk.org (Postfix) with ESMTP id E5C29402B9 for ; Wed, 29 May 2024 16:29:35 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id B9711180015E; Wed, 29 May 2024 10:29:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 29 May 2024 10:29:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1716992972; x=1717079372; bh=3mJZ3V5OKQ4NtEOouPPvOjtiMCaH4ej+9Qk0OGN8lCo=; b= taZQTtFEaCAM4wJN4WFcvRGySz7kM8rQMfSQvhdKN7bL7+jQeJITLLxilZbO73Yg vsWP3QPvI5udokm0BzW/XzaGcDM3xVmwuhhzSgO4mynjBjwed75kQK4HyPNxIzGE YlVFg8T7Lj6tyJdjCOIUuW4txo9TsPpykmUws7wMF3OpTGnbKFD532Ownbj0jX3W JgWwRsoat6g/SmPmFx8i9X15qB7wSPIjU3i9TrCQmKR5jReUR3LjBsHXPWDGZ+lc A+EcHQ/U73R63FEhEY70oTQbVmH35/GknyYhuZm/WNccjwakqucvaF8dIVfPkcuN hUTOUwDqLbhlkqp+U1GKAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716992972; x= 1717079372; bh=3mJZ3V5OKQ4NtEOouPPvOjtiMCaH4ej+9Qk0OGN8lCo=; b=c fizf9ws6vsfcGRaVuN1si8TJIjCFFH5/6Hlog1uLXzYFxCNIzQm0dHxNuCU+gXAI 1QqvHU2nEb+ADktSXvp9Ucr85jkoR25Qzck9Cj63+iN+KSvlHKfXOUFSc+5jYcXc f2HmgCeeX92gxtdjusMxMD9/+9RuK6zoKtyh4eZVj9ATv9YP89wZhFrcO22Vu1jo xQtZ3hC4dKCnvMgq6UeiPAlgEjlix0oMNW55IHpkWXOJBH9rw8j8bZkX/izhmyjZ /yPt/FnCoQwDqHLnh5e59ctzP8biwvGQjyNeub0Fk36NCI/Qfm2ChKFtUjqfHbP2 NrNwwSZhanaGtXmKxJ7NQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 May 2024 10:29:31 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Dmitry Kozlyuk , Pallavi Kadam Subject: Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows Date: Wed, 29 May 2024 16:29:29 +0200 Message-ID: <9541360.2WqB4rESCP@thomas> In-Reply-To: <1710262359-14217-3-git-send-email-roretzla@linux.microsoft.com> References: <1701976851-17275-1-git-send-email-roretzla@linux.microsoft.com> <1710262359-14217-1-git-send-email-roretzla@linux.microsoft.com> <1710262359-14217-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/03/2024 17:52, Tyler Retzlaff: > When EAL is built with MSVC it is possible to dynamically load plugins > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC > and provide code to load plugins on Windows. > > Signed-off-by: Tyler Retzlaff > Acked-by: Dmitry Kozlyuk > --- > +#ifdef RTE_EXEC_ENV_WINDOWS > +static void* > +eal_dlopen(const char *pathname) > +{ I'm not sure about having a Windows-specific implementation in lib/eal/common/ Also, the CI is failing with this patchset.