* [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device
@ 2018-05-21 19:18 Ed Czeck
2018-05-21 21:23 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ed Czeck @ 2018-05-21 19:18 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, john.miller, shepard.siegel, thomas, Ed Czeck
Fix on: fbe90cdd776c3ac99c4c56d1b5318a90fcf01602
---
drivers/net/ark/ark_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 62e4fd3..834d8a9 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -390,6 +390,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
if (p == 0) {
/* First port is already allocated by DPDK */
eth_dev = ark->eth_dev;
+ rte_eth_dev_probing_finish(eth_dev);
continue;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device
@ 2018-05-21 19:29 Ed Czeck
2018-05-21 19:42 ` john miller
0 siblings, 1 reply; 6+ messages in thread
From: Ed Czeck @ 2018-05-21 19:29 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, john.miller, shepard.siegel, thomas, Ed Czeck
Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
drivers/net/ark/ark_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 62e4fd3..834d8a9 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -390,6 +390,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
if (p == 0) {
/* First port is already allocated by DPDK */
eth_dev = ark->eth_dev;
+ rte_eth_dev_probing_finish(eth_dev);
continue;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device
2018-05-21 19:29 Ed Czeck
@ 2018-05-21 19:42 ` john miller
2018-05-21 21:26 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: john miller @ 2018-05-21 19:42 UTC (permalink / raw)
To: Ed Czeck; +Cc: dev, ferruh.yigit, Shepard Siegel, thomas
> On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
>
> Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
>
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> ---
> drivers/net/ark/ark_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 62e4fd3..834d8a9 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -390,6 +390,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
> if (p == 0) {
> /* First port is already allocated by DPDK */
> eth_dev = ark->eth_dev;
> + rte_eth_dev_probing_finish(eth_dev);
> continue;
> }
>
> --
> 2.7.4
>
Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device
2018-05-21 19:42 ` john miller
@ 2018-05-21 21:26 ` Thomas Monjalon
2018-05-22 9:52 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-05-21 21:26 UTC (permalink / raw)
To: john miller, Ed Czeck; +Cc: dev, ferruh.yigit, Shepard Siegel
21/05/2018 21:42, john miller:
>
> > On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> >
> > Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
>
> Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Suggested title: fix call to probing finish function for first port
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device
2018-05-21 21:26 ` Thomas Monjalon
@ 2018-05-22 9:52 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-05-22 9:52 UTC (permalink / raw)
To: Thomas Monjalon, john miller, Ed Czeck; +Cc: dev, Shepard Siegel
On 5/21/2018 10:26 PM, Thomas Monjalon wrote:
> 21/05/2018 21:42, john miller:
>>
>>> On May 21, 2018, at 3:29 PM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
>>>
>>> Fix on commit fbe90cdd776c ("ethdev: add probing finish function")
>
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
>
>>> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
>>
>> Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
>
> Suggested title: fix call to probing finish function for first port
Applied to dpdk-next-net/master, thanks.
(suggested title applied)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-22 9:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 19:18 [dpdk-dev] [PATCH] net/ark: Add missing call to probe_finish for first device Ed Czeck
2018-05-21 21:23 ` Thomas Monjalon
2018-05-21 19:29 Ed Czeck
2018-05-21 19:42 ` john miller
2018-05-21 21:26 ` Thomas Monjalon
2018-05-22 9:52 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).