From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB350A0A0F; Fri, 16 Apr 2021 11:55:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90484141BDC; Fri, 16 Apr 2021 11:55:10 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id E6F24141BD7 for ; Fri, 16 Apr 2021 11:55:08 +0200 (CEST) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FMBN11k0RzwSDQ; Fri, 16 Apr 2021 17:52:49 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 16 Apr 2021 17:55:04 +0800 To: Thomas Monjalon , CC: , , References: <1618454426-21457-1-git-send-email-oulijun@huawei.com> <1618562810-20304-1-git-send-email-oulijun@huawei.com> <2292057.lhpI95xzKh@thomas> From: oulijun Message-ID: <957dccf0-f04a-a849-4a4a-8c8a9eb2d9e8@huawei.com> Date: Fri, 16 Apr 2021 17:55:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <2292057.lhpI95xzKh@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/16 16:58, Thomas Monjalon дµÀ: > 16/04/2021 10:46, Lijun Ou: >> Currently, upper-layer application could get queue state only >> through pointers such as dev->data->tx_queue_state[queue_id], >> this is not the recommended way to access it. So this patch >> add get queue state when call rte_eth_rx_queue_info_get and >> rte_eth_tx_queue_info_get API. >> >> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >> it could be ABI compatible. > [...] >> --- a/doc/guides/rel_notes/release_21_05.rst >> +++ b/doc/guides/rel_notes/release_21_05.rst >> @@ -251,6 +251,12 @@ ABI Changes >> function was already marked as internal in the API documentation for it, >> and was not for use by external applications. >> >> +* Added new field ``queue_state`` to ``rte_eth_rxq_info`` structure >> + to provide indicated rxq queue state. >> + >> +* Added new field ``queue_state`` to ``rte_eth_txq_info`` structure >> + to provide indicated txq queue state. > > Not sure we should add a note here for additions which > do not break ABI compatibility. > It may be confusing. > Hi£¬Thmas&Ferruh Do you want to delete it? > > . >