From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 662C1B347
 for <dev@dpdk.org>; Thu, 24 Jul 2014 09:58:06 +0200 (CEST)
Received: by mail-wg0-f50.google.com with SMTP id n12so2286592wgh.33
 for <dev@dpdk.org>; Thu, 24 Jul 2014 00:59:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LAsAi2QTTa55aheaCDj+czVxr5rCDBZCYVZYYeFGv5k=;
 b=S273jRk5jP6BdyYG684UdPuT4Wy3nsHL6MUfLcYUPYKVk10v1pwACp/0+DV5o7MWOx
 wkLds+JhUVAz1VeI2papQR0AA3QmhmPcnuojlCucGoPmKGTs2qma2w9ncH0bsvucoPKN
 6cR4VI9nYuGtLfY4jjO3u3H7OGk9tjNW/dHy6jvVdeT7uKzhGA8zwJOG7acHkiNH9aFf
 2YHda/aa44neQy7uEID+SIrT72gfJinHt/2y+wRQxo565+Wi5auBGNoF+nOLzLRc2ogr
 NIcd6qwO4hJQ0XpNoiXfc9cAyGE+48PBZvxzMHWuZZeEDgJHfEfzKcIXz3IJ+SM/1RU1
 gArQ==
X-Gm-Message-State: ALoCoQnQyEsi9vrTGZ5+eb4eBXu8iZBxQbhJTkvPrHya763yEidnsWbU19ZzdWTn9WJaNxIuKfX8
X-Received: by 10.180.20.15 with SMTP id j15mr6959576wie.60.1406188773495;
 Thu, 24 Jul 2014 00:59:33 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id a13sm13635294wjs.12.2014.07.24.00.59.32
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 24 Jul 2014 00:59:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Thu, 24 Jul 2014 09:59:23 +0200
Message-ID: <9589603.4uh6CsY5aa@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )
In-Reply-To: <1406184149-11531-4-git-send-email-helin.zhang@intel.com>
References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com>
 <1406184149-11531-4-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jul 2014 07:58:07 -0000

2014-07-24 14:42, Helin Zhang:
> Toeplitz and simple XOR hash functions are supported by
> hardware, code changes are to tell the hardware which hash
> function is selected according to the configuration.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

> +CONFIG_RTE_LIBRTE_I40E_HASH_FUNC_TOEPLITZ=y

Is it really a good idea to configure this kind of thing at build time?
Maybe yes, I'm not sure.

-- 
Thomas