DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions
Date: Thu, 1 Jul 2021 19:19:52 +0000	[thread overview]
Message-ID: <95B1B538-E0EC-4C7A-B7C2-C4512CBA6446@intel.com> (raw)
In-Reply-To: <20210701101812.5a380b36@hermes.local>

> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Thu, 1 Jul 2021 17:16:21 +0300
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
>> On 6/16/21 7:15 AM, Stephen Hemminger wrote:
>>> Since these always return 0, they were doing nothing useful.
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
>> I have no strong opinion on the patch, but sometimes even
>> empty functions with comments add value. So, I see no point
>> to touch it. So, I'll wait for maintainer reply.
> There are always many ways to write more obscure and technically correct
> code. It is best if the code is the smallest correct way.
> “I apologize for such a long letter - I didn't have time to write a short one.”
> ― Mark Twain

I agree with Stephen, the extra functions provide no useful feature or even the comments are not very useful IMO.

  reply	other threads:[~2021-07-01 19:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  4:15 [dpdk-dev] [PATCH 0/2] net/tap: remove useless offload setup Stephen Hemminger
2021-06-16  4:15 ` [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions Stephen Hemminger
2021-07-01 14:16   ` Andrew Rybchenko
2021-07-01 17:18     ` Stephen Hemminger
2021-07-01 19:19       ` Wiles, Keith [this message]
2021-07-02  7:56         ` Andrew Rybchenko
2021-06-16  4:15 ` [dpdk-dev] [PATCH 2/2] net/tap: replace offload_capa function with define Stephen Hemminger
2021-07-01 14:18   ` Andrew Rybchenko
2021-07-02 13:26 ` [dpdk-dev] [PATCH 0/2] net/tap: remove useless offload setup Wiles, Keith
2021-07-02 13:36   ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95B1B538-E0EC-4C7A-B7C2-C4512CBA6446@intel.com \
    --to=keith.wiles@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).