From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id D78E9AAC4
 for <dev@dpdk.org>; Fri, 18 May 2018 13:48:04 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 18 May 2018 04:48:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,414,1520924400"; d="scan'208";a="51937081"
Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.73])
 ([163.33.230.73])
 by orsmga003.jf.intel.com with ESMTP; 18 May 2018 04:48:00 -0700
To: dev@dpdk.org
References: <20180518075948.3177-1-remy.horton@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Beilei Xing <beilei.xing@intel.com>
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <95a474f2-624e-bced-2e1e-2351d46caf0d@intel.com>
Date: Fri, 18 May 2018 12:48:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20180518075948.3177-1-remy.horton@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix corruption of VF stats via
 port representor
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 May 2018 11:48:05 -0000

Missing fixline, so v2 coming..

On 18/05/2018 08:59, Remy Horton wrote:
> The resetting of stats on a VF involves the setting of an offset
> that is subtracted from future calls, rather zeroing of counters.
> However doing a stats reset on the port representor was also
> adjusting the values forwarded to the VF, which had the effect of
> corrupting the VF's counters. The fix is for the port representor
> to maintain its own stats offset, so the port representor and VF
> maintain independently-resettable counters
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>