From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A332A0C45; Fri, 15 Oct 2021 09:31:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 199F0410F1; Fri, 15 Oct 2021 09:31:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E2FC40692 for ; Fri, 15 Oct 2021 09:31:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634283065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tadk3H2vB75nQxsMTkrh6Z4LYSgppgdE3ZKn7vouww8=; b=hFkfGKmFHeERu7ZT8aCGRcybkegXHhTTm2uAjv7Vg3IpB+VpT38kUty9hJV/CQXqWFHDed XoZAlQyVObY7faBKTHllfAzVJ1fPJPyYPWQEqmISJQMq6c3L7a9MJmk+GbnrGC9KDuZdEx xQ4h25vxKxaIdWOu1cSVJpUwzLQg3MM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-rZUOyXckOUq48trynm8AgQ-1; Fri, 15 Oct 2021 03:31:02 -0400 X-MC-Unique: rZUOyXckOUq48trynm8AgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6051DA40CE; Fri, 15 Oct 2021 07:30:45 +0000 (UTC) Received: from [10.39.208.20] (unknown [10.39.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9ED9607A1; Fri, 15 Oct 2021 07:30:43 +0000 (UTC) Message-ID: <95bc818a-60d8-e8aa-5b96-061798967e64@redhat.com> Date: Fri, 15 Oct 2021 09:30:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: "Xia, Chenbo" , "Ma, WenwuX" , "dev@dpdk.org" Cc: "Jiang, Cheng1" , "Hu, Jiayu" , "Wang, Yinan" References: <20210910135205.269651-1-wenwux.ma@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 9/10/21 05:17, Xia, Chenbo wrote: > Hi Wenwu, > >> -----Original Message----- >> From: Ma, WenwuX >> Sent: Friday, September 10, 2021 9:52 PM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Jiang, >> Cheng1 ; Hu, Jiayu ; Wang, Yinan >> ; Ma, WenwuX >> Subject: [PATCH] examples/vhost: change the default value of NIC's max queues >> >> vswitch can't launch with 40G FTV due to Device start fails > > Not many people can understand what's FTV. So let's describe it with a driver > name. Example if it's 'i40e': > > vswitch can't launch with a 40G i40e port... > > And Device -> device > >> if NIC’s max queues > the default number of 128, >> so, we changed the default value from 128 to 512. >> > > I'd say it's not cool to still hard-code the MAX_QUEUES so that only 'some' NICs > can work with the example. The app should have a way to check this kind of info > before init/start. But as I would like to see at some point, this example will > be removed and all our tests go to testpmd. Let's not waste too much effort on > this example. > > Besides: it can be a fix. Let's backport it. > > Thanks, > Chenbo > >> Signed-off-by: Wenwu Ma >> --- >> examples/vhost/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/examples/vhost/main.c b/examples/vhost/main.c >> index bc3d71c898..36969a4de5 100644 >> --- a/examples/vhost/main.c >> +++ b/examples/vhost/main.c >> @@ -29,7 +29,7 @@ >> #include "main.h" >> >> #ifndef MAX_QUEUES >> -#define MAX_QUEUES 128 >> +#define MAX_QUEUES 512 >> #endif >> >> /* the maximum number of external ports supported */ >> -- >> 2.25.1 > Are you planning to post a new revision handling Chenbo's comments? Thanks, Maxime