From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3EC18548B for ; Fri, 2 Mar 2018 22:44:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 13:44:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,413,1515484800"; d="scan'208";a="32008645" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.1.6]) ([10.252.1.6]) by orsmga003.jf.intel.com with ESMTP; 02 Mar 2018 13:44:29 -0800 To: Moti Haimovsky , pascal.mazon@6wind.com Cc: dev@dpdk.org, Shahaf Shuler References: <1515601248-39458-2-git-send-email-motih@mellanox.com> <1516197874-133169-1-git-send-email-motih@mellanox.com> <1516197874-133169-2-git-send-email-motih@mellanox.com> From: Ferruh Yigit Message-ID: <95d434f5-438a-19a7-1227-18c1230201c0@intel.com> Date: Fri, 2 Mar 2018 21:44:28 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1516197874-133169-2-git-send-email-motih@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 21:44:33 -0000 On 1/17/2018 2:04 PM, Moti Haimovsky wrote: > Ethdev Rx offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > This commit adds support for the new Rx offloads API. > > Signed-off-by: Moti Haimovsky <...> > +static bool > +tap_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads) > +{ > + uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads; > + uint64_t queue_supp_offloads = tap_rx_offload_get_queue_capa(); > + uint64_t port_supp_offloads = tap_rx_offload_get_port_capa(); > + > + if ((offloads & (queue_supp_offloads | port_supp_offloads)) != > + offloads) > + return false; > + if ((port_offloads ^ offloads) & port_supp_offloads) > + return false; Hi Moti, I am getting following error when tried to use tap with bonding: "Rx queue offloads 0x0 don't match port offloads 0x1000 or supported offloads 0x300e" What is the intention here? I guess it tries to be sure requested queue offloads is subsets of port_offloads and offload_capability. If so not requesting any queue offload should be valid, isn't it? <...>