From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6CCA91B21E for ; Fri, 19 Jan 2018 20:38:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 11:38:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,382,1511856000"; d="scan'208";a="11587152" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2018 11:38:40 -0800 To: Yong Wang , hemant.agrawal@nxp.com, shreyansh.jain@nxp.com Cc: dev@dpdk.org References: <1516276136-618-1-git-send-email-wang.yong19@zte.com.cn> From: Ferruh Yigit Message-ID: <95dc37b3-eb5b-dc2a-1d86-9d7116685023@intel.com> Date: Fri, 19 Jan 2018 19:38:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516276136-618-1-git-send-email-wang.yong19@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 19:38:42 -0000 On 1/18/2018 11:48 AM, Yong Wang wrote: > There are several func calls to rte_zmalloc() which don't do null > point check on the return value. And before return, the memory is not > freed. Fix it by adding null point check and rte_free(). Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Fixes: 62f53995caaf ("net/dpaa: add frame count based tail drop with CGR") Cc: stable@dpdk.org > Signed-off-by: Yong Wang Reviewed-By: Shreyansh Jain (carried from previous version of the patch) Applied to dpdk-next-net/master, thanks.