From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0054.outbound.protection.outlook.com [104.47.40.54]) by dpdk.org (Postfix) with ESMTP id 7308E5F14 for ; Mon, 17 Sep 2018 13:41:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+qKztSiSPtriPSVliT+xEGPF8voRZBYHCejwsKZrTM=; b=NA0bqqjGj/IwoGaMksCDx96Oprn5aUtmsVY2oGbYuaQVz3GEcVHvqVDq5scwfy/1cw0HsBIpsou7VfAtqbf7h3qKzZ+x08gQpVFJUCwI+J98Sle8uG8AdjruhhQ1UY8usy7yn2bwA5U5kHTZzip12MzJLujlQjCAiN8erldRtOE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 11:41:50 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com> <8421735d-1357-e444-9924-390f23827f3e@nxp.com> From: "Joseph, Anoob" Message-ID: <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> Date: Mon, 17 Sep 2018 17:12:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8421735d-1357-e444-9924-390f23827f3e@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR0101CA0050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::12) To SN6PR07MB4911.namprd07.prod.outlook.com (2603:10b6:805:3c::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44473606-0d08-47c7-4312-08d61c92915f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4911; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 3:GcpV37WgRYq3tMki+zMjcYTYSW5ZuqfH/KlowIXOkn+Qn9lFLf/YmI/oWPWkcPMVxqk3vUTQ8VOztupv2tBlvGlA/YpDs8JzGbAdInO1ZEljQsTki1vB73WgUbkHEwPY3JN72i/pXuk1JdkY1bzhKht6NT3rHz5pAtj9klT6OazTvDkz3ckvOujtx/qT8T1kSrqfv/DtcfcX5/OAKJGDcvUJvZCIphVWjtvrylsqTxwNz0SHT/5OobN6egSUfp4v; 25:2tfoUjNBxnREogZEvEtX9OdGYxlJkvbnavtjFuhbyZQN21Z4YeCP9JgzExteqoiE42Tx5olKUG2YY9crjo7/cYQlwtqRYrZEU5zTTns/rwpFV0f64Y0OFmpip77J5CpwGA3ysIDV8UvvG7ue99aaBXoDNPQ1JUjFa4+PkuOa50v0X2acmQsqnjbhtWQDsqvLDaWbjJBlPd20ThALw09ri6o2oQCOTrz73/rO/WZ+snYiXI0Z+V2L0pdc5+tZ3NqoP+TPRaVW7SE1U74yD2/Vb+NA0jmcQktjftB8h91vh14S8wjz8Lmn105YQS1Y6WiXNpDqYiZkeYn1A3AS+Me4sA==; 31:XpYPoIjATbMY6+NB0z7HOZ/g9dRHYl1nRYz8FY9b4aTjSEj34ui5EVfCYfp/vaTFed4Il1GtAQjucuoSHJr9+UlpNsZmTsYdjrHb9CVZDABRGy1Xh23xxPneWRcEsfjXRqF2hhC2taUGuZWp1UBSdXxJWFHH09yRJc4V2ttJ6x/HGjsJ7conEQYiQismEQeoWTjRYN71O+dKrMvSp+YMg41t7mq4v9dv2AXo7KbsaW8= X-MS-TrafficTypeDiagnostic: SN6PR07MB4911: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 20:2SK937GVa93NZIfiCk0/Uu3Si9ogG7G19PC/eA3ur1FPEGMdbwASUEfAUKlQR0VkgvUch76xEbgZgzGRFkY6YacTXk+Lkweh6uRith0OAL9FGKmS5vAR1XLiSo/B9fCxbrcpkQ+Cp57RvcuE+HmIFe7C4Rx1GUSIWXpifuAmWxzjSz0jmhWdwIX1/clEEOXbdLEFJnXVKY0rghg/7xQVSZpXHJiD+l0Wc+p6g1uSm6dkBKbjqvhIZS8l1is+ZnUBUDh5VEDznWZW1oY84UglKR+qxqtzIvXibeP6HTBzCiqz3dYvoBqQvt8rod7hTgHH4inD3hwr31TkLAEa+ae1xCP809L7HooKICAANFkIDrv7ab1Ao0llqJ4c0nV2RVV03bc/XGczt4ekVTt39edTbcgOJY5ZK145nEBqRXDL7RS9/j4tfaq7ML06YI6gHtS0srIRRrMxsdTZbL5N6KiQ6k75FqOPMdZn/15WXEtmD/BDHxn34N650qjfJqha4E87993DW4j8B3fK9fKvSLT4HEXI4SLBro/r3n4Xsl7MY9YNDLCPu/qIvX4pDHOr3iOCxsluPsWVi42oDjPjIRjyGGqH0ZXMX9aREGeRsNX5ZjU=; 4:Fh4/+OSr53KUee5d0msvVcANhD5BQ3kKkFPZAKPLd3j5Wlir8jnkpeF1w6kHnXFFOwR0URbifZ7ZL7lf8FXoOphusOY8f+sS5fbYY9NAc14ASG/WI7u7NLUFAMzRsh8nXD/7862BOFPcccHTrOBBR9l0y0opr9nY+/jSnjfDz0iWPQyo7FfFeYN1CQW3uBZU3gFK5ZovEzvD0IJ7JDBZ9GbfdWgULQfZJVJw1roP/wY4+g96RUkJq/vHEIZ1U6vkLTiTev1SyqprBYguOIUK9w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699050); SRVR:SN6PR07MB4911; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4911; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(136003)(396003)(366004)(39860400002)(376002)(199004)(189003)(11346002)(81166006)(956004)(53546011)(2616005)(229853002)(476003)(6486002)(2870700001)(305945005)(106356001)(25786009)(64126003)(105586002)(3260700006)(7736002)(446003)(53936002)(31696002)(486006)(3846002)(2906002)(6116002)(386003)(93886005)(68736007)(72206003)(8936002)(42882007)(478600001)(36756003)(81156014)(4326008)(52116002)(76176011)(2486003)(52146003)(23676004)(316002)(5660300001)(16526019)(16576012)(110136005)(54906003)(58126008)(31686004)(65826007)(26005)(77096007)(107886003)(6246003)(97736004)(50466002)(47776003)(6666003)(8676002)(66066001)(65956001)(67846002)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4911; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTExOzIzOjE2WUc2ZzdvTmhncW1rYVd2RlAyTFBNS29X?= =?utf-8?B?YVNabDZJamdOM2xZbHhjbmg1TENqL1ZVOVpWdXpPaVc0WHlqOEpSR01xWmkx?= =?utf-8?B?bWMxN0JQVkpkSENSb2ZYZVU5NUQrZ1E1Mjd5dW85cGNnVVUwUGhRRndyajFh?= =?utf-8?B?TUpmZ3lCOTJMOXNheS9JTXphKzRFanY2c3g4SC9tWVhLT3FWc2xxS09INnIx?= =?utf-8?B?Nk5CL0Q1N3hHVVBDWGpoNHVUSFFISXc5Z2QzRlpUV0hlcml2YWVMY0lFeHg5?= =?utf-8?B?OXVkcHpGQXBSRlBqTjVIMUNuZnlySVV1Y0JrWjR4ekt1akVlTXNKWmhJRkI1?= =?utf-8?B?Wi9YU0EzWmxWcmZYOHZhTTVIc1gzT3pTQW1yLy9wL0JNY2cybEZhMDJraVdj?= =?utf-8?B?N09ERXI5MDdGQVNUTnJPRXRFUFZ0OUxNV2dWYjkrZHdMVTVpM2JXang4VG9s?= =?utf-8?B?eGVkNmRrR0ErUDQ5VmVMb1B5OFhtQkU2VDM2YXdXbWlHcVBNbVRxT1JVSjRo?= =?utf-8?B?THFzRjZMR1BKa1ZyRW1PS250cER1ZXZNbHFXNVVoNjNBeU1iVk1CUXJNSGMy?= =?utf-8?B?bmV2dm5jK0o3clNJOFhKc3BadXMyRmF1RW9oa0ltbjRpcDkxYzI5dXAxWHQy?= =?utf-8?B?SFdwTzVxb3prQjZydkFTOVJUZkZNellYZkFnR2QvRkpZM2k2ODZhWERuSlZQ?= =?utf-8?B?d3NaZ1kramY3aFpXdUtJR1pCSjZhM0I2Z3QrSGppaWJucUsyc1pTODNaWCtJ?= =?utf-8?B?VEp1aE9zc2w4THV5MElRTVZ0RmUxbmhUV2ZGaUtYc2xPYUpnYlh6bUxRZllX?= =?utf-8?B?dDFIemJhT0JXQXlPdCtpSWRTMUZDSlZhTDA5aTJSZUFHODV4b0Y3SGhJTXcz?= =?utf-8?B?QkxwdlhjeEsrWTFwbWVRTXl6QlFrK0RyVmlTZWdPUmtScHpWVlM3bVJ2a3Ur?= =?utf-8?B?d09HaTlXWmZjUWdKaWpNaWxIYjNwcFRrOW02ZTZUTXJJODZTTEtGckhaWHJZ?= =?utf-8?B?UytLaUVqZHRFbHhOb0xYU2JXOHZacElCTFlKWlM0Ni9GQUVZbkZ5UUhyd0x6?= =?utf-8?B?eTBHaVVzVkZsa0kwZmRacHh1eFJWR3pabTZhSG94Y2ZrSUM2RS9TV1N6NFlw?= =?utf-8?B?bDFyUEVmS0hNM0h4RjNWcXpBOTY4dGp5aG00cFUyWUcraFk5RDY5akNPWWZH?= =?utf-8?B?ZmJZd2lqZEc1eWdyQTljRjgraTA3emxkNVQrWUc5L3U2Q3U3NS9qdS9MRlNs?= =?utf-8?B?QTk4dEttdEdHMEl4RW4xMzRjZFdNVHU5ZFpPYlJtVHNsS3loL2M0MUNNMjRS?= =?utf-8?B?YUdUSlB4ZS8zRU9BYnA4TXFMWWZrcHFTWVJUYW5rQ1NwNVg4Ym11bjRVdlZL?= =?utf-8?B?bHBTVmNpOXRnK1ZZSWtrek1uVEgwVTBKOVNHZFdrc0NhYmpUUjVBcHhnU0xr?= =?utf-8?B?V1JmeXc1aXovRXdkekg2dWRiYWxlU3Fyc0Qvd2ZVN2VidTcycGI2bSsxMENU?= =?utf-8?B?S1dMVG5GVDVPeVdPWjVmL2tQSTdVdXVtVUhNZFhZcXRIZzBxNVNLaVZ5Q1ZI?= =?utf-8?B?RjZpMVNwalFwdUwwOEhOdCtyYjB3SjUrVy9yd1pVL0k4d3dUUWJhQy9qOW56?= =?utf-8?B?aFNuY1lJYTJONjRQbG9PdFhtdzhEWnlpNTJucWdBeGRSeHFzQVBGMFpUM0pX?= =?utf-8?B?ampHZm93UTNIVWRZdzh1aVlFRmxKVmw0QjhYbllScldMaXlZOFlNSEIyR2Vk?= =?utf-8?B?RytEYVorNzF1aE45VTVGbno3bktzamx5dWJuSFA5L2FMRXJNcEszeEoyK3lT?= =?utf-8?B?bldTWWFiaDcreDdXamIyaHlnVnRsc1B6aGFuQUNJdjQwaHpVWjR0MzRNWC9B?= =?utf-8?B?eEdaVzh1K1NCMEFuMTJ3eXV2c0laRmtBQzFmNnNFb3ZKOENQVTdsVEt1STZ5?= =?utf-8?B?N0prZFlSeFFaWmo0d1BMUHNtZDN3eFVxNEtlUGE3S0MwcTR4MHFpK2puVkRJ?= =?utf-8?B?SWtraDgxMVNIeUxkQzFlbDN2U3ZNYUROYkFGcjhtQ0w5M0swQmptSVZHUk5j?= =?utf-8?Q?p3FtbxZruK9IoXIyRM17vDLDT?= X-Microsoft-Antispam-Message-Info: FvZO2dF1lAKAhe0PpIOOlWL8ceyGsDff4/xZ/eu03oTKBdGkWnQldoXfti/A8L1qPTjbCv9w4Cb+yepvNJGFMSP8U/p8r3JlgwN7ZEF8vA1KciKtvWAX05jxksHWfl+m1ThvJi1nvsX/kCP3yMBjdHBl/bISqJcRG173AANMzhWkpRaJMq05yKWX/bRbuw0ikERkkEAJiQx+EGmKSzqnShBlQzhkrnAwLzHTL67E88ZsxzpxuPZ/COMwQteBA9K9xLW9lTm0KAC2dkOWsZkoLsualVfJC92h0HZM2inNnegQ/cNVQAQIWorhEceX+MPwOsx+Jye/m8NQE9cvZaoMjEsLAh3ud7H0sxS/6bIq2OY= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4911; 6:tPcCXvrcT5MN3d1e8sxuqm6eXxDjkzFywpmSb8iOTrLguUH7bAhDtjVESFe+DYoYR41o4BdS78/pwSDq/+6KH8PbetKFWg3KMsoxyAcTFQc4qpdoiTyV0Qg5ehhbDNauF0EMaMG6Df2yt53Ih1cf7LvEBQm8XQp0XKyLzvPhfBVIjSYsiW3N0FEcaJQGnGlSuQ610LmNvyl+m1X4rGDn3mPsyEJzDWIP4Usjr9o/e3gbyUBrXbtvwD5KGFkiuPBZRZ3ef79zrVvX4aa5kHs7DAdi0fmK4pEWJslhz9zKNKxFXT/DxFfN46Qt+xUOrirTm8k/6XRDQSaux0L6m4qYfrLI2R7lAljfBI3hvRbJf9Ho9uHXomnL6XEeDSJqntFGoCzo3Xa8VLzYf844h++payCKzYD4OzFx6C3zdrpl3aF9LOE18F7bMUpPPygQ5BKiXCBjwErwomygsPO/juf0QQ==; 5:2ZU1E+Cn0DGy0tdRHPjPS0DQR4GXxZmGoWmISC5R6EB3f4WhVCV18ZMknF3XGq9oXBUEVVKvbLerYaH9vzCmkhMVX5D2oyEUQpCnTNtpshaMolicVMd9P2cTKR/vUVGkIIgAWrzDN+jgdbxgm5BjW7QjAvK16GqxmWcfaioQbak=; 7:R1q1iVvo9NZbHaIXUyz6nzIX6ickAdYaN6izxaRrWwi7aLwbA2u+Zi/PFpkpVLhr+4Bhr7qtEHnXrh9JZXJBAL78ycz3yasdb2Dw84tmoJn7irnzrFajiaChUAe51J2RtUxA89xI1s5qwyU8Z1lZZvlxA9QRQp0V6AO0QapNGbNy692J2WmtAHvGtccAFa6Cv2tXRdkz+GGQAQBbexf2lAct1miqqevlJjaLm5G14QUzNhY4S0VZbrWm1cGJj3UD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 11:41:50.4944 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44473606-0d08-47c7-4312-08d61c92915f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4911 Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 11:41:58 -0000 Hi Akhil, On 17-09-2018 16:07, Akhil Goyal wrote: > External Email > >>>> >>> I think it would be better to squash the makefile related changes in >>> the 3/33 patch as the code >>> >>> is actually added in that and here the code is not getting compiled >>> here. >> So the changes in the following files has to be moved to patch 3/33? >>   drivers/crypto/Makefile >>   drivers/crypto/meson.build >>   drivers/crypto/octeontx/Makefile >>   drivers/crypto/octeontx/meson.build >>   mk/rte.app.mk >> >> I think this patch will just have MAINTAINER edit (even that might be >> required to be moved to 3/33?) & changes to config/common_base, after >> that. Is that fine? > In my opinion, you do not need this patch as separate one. > config/common_base can also be added in the 3/33. In that case 02/33 patch would become the first patch right? The same problem would be there too, I guess. The macros added in that patch gets used only in 03/33 patch. Is that fine? The first patch would be a shell patch for most PMD additions. That's the reason we started this way. If you want it changed, will do so. Please do let me know what will be the right approach. Anoob