From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC121A0C4E; Wed, 7 Jul 2021 16:04:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98753413B6; Wed, 7 Jul 2021 16:04:37 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1715E413A8 for ; Wed, 7 Jul 2021 16:04:36 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id BA3FA7F4DA; Wed, 7 Jul 2021 17:04:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru BA3FA7F4DA DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625666675; bh=n9DIYhesuM3bFEKq3rEVsfHzjGAGv042rbfWRZ4I17Q=; h=Subject:To:References:From:Date:In-Reply-To; b=e7DIwEHGOH3pSBJyPYEqVX3Fn5GC/FHMNb+0HWKs8B6PipsZ5zcUtyiz3j6UN5we3 ruLUpd5Mu0k/Jzisao/3NXK9e8/TV0LYhWErtJlat2zcjxBCYqa/8scHywj3N9FKrJ UUJyh0hwEsRQI843EtIwjxj6/QOwNGgHNiUEPqQc= To: Jiawen Wu , dev@dpdk.org References: <20210706095545.10776-1-jiawenwu@trustnetic.com> <20210706095545.10776-15-jiawenwu@trustnetic.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru> Date: Wed, 7 Jul 2021 17:04:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210706095545.10776-15-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/6/21 12:55 PM, Jiawen Wu wrote: > Setup MSI-X interrupt, complete PHY configuration and set device link > speed to start device. Disable interrupt, stop hardware and clear queues > to stop device. > > Signed-off-by: Jiawen Wu WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70: + msleep(1); Any comments? CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1102: FILE: drivers/net/ngbe/ngbe_rxtx.c:531: + +} Above must be fixed. [snip]