DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com
Subject: Re: [dpdk-dev] [PATCH v5 0/4] vhost: Fix and improve NUMA reallocation
Date: Fri, 18 Jun 2021 16:04:31 +0200	[thread overview]
Message-ID: <9601214d-b08c-2ec9-5ef1-797e239bfbf9@redhat.com> (raw)
In-Reply-To: <20210618135735.253770-1-maxime.coquelin@redhat.com>



On 6/18/21 3:57 PM, Maxime Coquelin wrote:
> This patch series first fixes missing reallocations of some
> Virtqueue and device metadata.
> 
> Then, it improves the numa_realloc function by using
> rte_realloc_socket API that takes care of the memcpy &
> freeing. The VQs NUMA IDs are also saved in the VQ metadata
> and used for every allocations so that all allocations
> before NUMA realloc are on the same VQ, later ones are
> allocated on the proper one.
> 
> Finally inflight feature metada are converted from calloc()
> to rte_zmalloc_socket() and their reallocation is handled
> in numa_realloc().
> 
> Changes in v5:
> ==============
> - Do not reallocate if VS is ready (Chenbo)
> - Fix typos & cosmetics (Chenbo)
> - Improve numa_realloc() comment (Chenbo)
> 
> Changes in v4:
> ==============
> - Check Vhose device numa node to avoid rte_realloc_socket
>   to realloc even if already right node/size/align.
> 
> Changes in v3:
> ==============
> - Fix copy/paste issues (David)
> - Ad new patch to fix multiqueue reallocation
> 
> Changes in v2:
> ==============
> - Add missing NUMA realloc in patch 6
> 
> Maxime Coquelin (4):
>   vhost: fix missing memory table NUMA realloc
>   vhost: fix missing guest pages table NUMA realloc
>   vhost: fix missing cache logging NUMA realloc
>   vhost: fix NUMA reallocation with multiqueue
> 
>  lib/vhost/vhost_user.c | 54 ++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 49 insertions(+), 5 deletions(-)
> 

Sorry, please discard this revision, 3 patches are missing.
V6 sent.

Maxime


      parent reply	other threads:[~2021-06-18 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 13:57 Maxime Coquelin
2021-06-18 13:57 ` [dpdk-dev] [PATCH v5 1/4] vhost: fix missing memory table NUMA realloc Maxime Coquelin
2021-06-18 13:57 ` [dpdk-dev] [PATCH v5 2/4] vhost: fix missing guest pages " Maxime Coquelin
2021-06-18 13:57 ` [dpdk-dev] [PATCH v5 3/4] vhost: fix missing cache logging " Maxime Coquelin
2021-06-18 13:57 ` [dpdk-dev] [PATCH v5 4/4] vhost: fix NUMA reallocation with multiqueue Maxime Coquelin
2021-06-18 14:04 ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9601214d-b08c-2ec9-5ef1-797e239bfbf9@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).