From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 668ABA0C46; Fri, 18 Jun 2021 16:05:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7964F410FB; Fri, 18 Jun 2021 16:04:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 01B59410F3 for ; Fri, 18 Jun 2021 16:04:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624025080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gEv1nlR/zRvQZCDiyuNU9zUjjrrz+Bk0Bx2gLTpgwUA=; b=L6VL9BFl0nWhnJ0bTazT7kv83KGRUE1/GWFZB21lAL6fzuVwg/xbFwgecbgd6x9cugMfcf S5DIdbixZkm+FfjB0h3I0QOFb04HMB/MDllJdJhZmscAWSdZdtKvEKCmUiX2OME5Qeo3de KKjcHnWET04kkw1vHy7GFga3JS1p5cQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-iLzKBxXrNWCuvKQKvTc0hg-1; Fri, 18 Jun 2021 10:04:38 -0400 X-MC-Unique: iLzKBxXrNWCuvKQKvTc0hg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5E5ABBEE3; Fri, 18 Jun 2021 14:04:37 +0000 (UTC) Received: from [10.36.110.21] (unknown [10.36.110.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BB4F60C59; Fri, 18 Jun 2021 14:04:33 +0000 (UTC) To: dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com References: <20210618135735.253770-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <9601214d-b08c-2ec9-5ef1-797e239bfbf9@redhat.com> Date: Fri, 18 Jun 2021 16:04:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210618135735.253770-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/4] vhost: Fix and improve NUMA reallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/18/21 3:57 PM, Maxime Coquelin wrote: > This patch series first fixes missing reallocations of some > Virtqueue and device metadata. > > Then, it improves the numa_realloc function by using > rte_realloc_socket API that takes care of the memcpy & > freeing. The VQs NUMA IDs are also saved in the VQ metadata > and used for every allocations so that all allocations > before NUMA realloc are on the same VQ, later ones are > allocated on the proper one. > > Finally inflight feature metada are converted from calloc() > to rte_zmalloc_socket() and their reallocation is handled > in numa_realloc(). > > Changes in v5: > ============== > - Do not reallocate if VS is ready (Chenbo) > - Fix typos & cosmetics (Chenbo) > - Improve numa_realloc() comment (Chenbo) > > Changes in v4: > ============== > - Check Vhose device numa node to avoid rte_realloc_socket > to realloc even if already right node/size/align. > > Changes in v3: > ============== > - Fix copy/paste issues (David) > - Ad new patch to fix multiqueue reallocation > > Changes in v2: > ============== > - Add missing NUMA realloc in patch 6 > > Maxime Coquelin (4): > vhost: fix missing memory table NUMA realloc > vhost: fix missing guest pages table NUMA realloc > vhost: fix missing cache logging NUMA realloc > vhost: fix NUMA reallocation with multiqueue > > lib/vhost/vhost_user.c | 54 ++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 49 insertions(+), 5 deletions(-) > Sorry, please discard this revision, 3 patches are missing. V6 sent. Maxime