From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F22D31BD44; Fri, 21 Dec 2018 14:27:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2018 05:27:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,381,1539673200"; d="scan'208";a="131878401" Received: from klaatz-mobl.ger.corp.intel.com (HELO [10.252.31.78]) ([10.252.31.78]) by fmsmga001.fm.intel.com with ESMTP; 21 Dec 2018 05:27:51 -0800 To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org References: <20181219115950.46386-1-bruce.richardson@intel.com> From: "Laatz, Kevin" Message-ID: <9610a05b-bac2-a964-bbd2-44492ae1da03@intel.com> Date: Fri, 21 Dec 2018 13:27:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181219115950.46386-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error when using ports of different types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 13:27:54 -0000 On 19/12/2018 11:59, Bruce Richardson wrote: > Different NIC ports can have different numbers of xstats on them, which > means that we can't just use the xstats list from the first port registered > in the telemetry library. Instead, we need to check the type of each port - > by checking its ops structure pointer - and register each port type once > with the metrics lib. > > CC: stable@dpdk.org > Fixes: fdbdb3f9ce46 ("telemetry: add initial connection socket") > > Signed-off-by: Bruce Richardson Acked-by: Kevin Laatz