From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC895A0548; Thu, 1 Apr 2021 16:11:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B73EC14131C; Thu, 1 Apr 2021 16:11:44 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id BC8461412BA for ; Thu, 1 Apr 2021 16:11:42 +0200 (CEST) IronPort-SDR: 1XjhJy8jbUqOjmWnx1/5Ef3qFhohIjutPHp64TXOeJbb4zxSmYuv24vciwzcF6hE5N+L2WumuG WTMkMF2uOU1w== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="190018171" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="190018171" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:11:41 -0700 IronPort-SDR: 2lj7NKLVcQOr2i+9Wnzy94/4LRAGmT/pa4oAra3joRswA5VYWH0viSeFr3lVFH37J/3i74CXQ7 f/XKYNfIiV8w== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="455999923" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.245]) ([10.213.201.245]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:11:39 -0700 To: Qi Zhang Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210331095254.2454439-1-qi.z.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9612db77-32b0-17c7-41a5-c2e24bf5a63f@intel.com> Date: Thu, 1 Apr 2021 15:11:35 +0100 MIME-Version: 1.0 In-Reply-To: <20210331095254.2454439-1-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 0/8] ether: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/31/2021 10:52 AM, Qi Zhang wrote: > PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap > data path debug code. As .config has been removed since the meson build, > It is not friendly for new DPDK users to notice those debug options. > > Patch 1/8: introduces new compile options for data path debug in ether > layer, PMD can choose to reuse them to avoid maintain their own. > > - RTE_ETHDEV_DEBUG_RX > - RTE_ETHDEV_DEBUG_TX > > The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to > both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward > compatibility. > > Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the > new build options > > v6: > - fix build issue for -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1" > - s/compile/build/ > > v5: > - Remove RTE_ETHDEV_DEBUG > - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward > compatibility. > > v4: > - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library > for backward compatibility. > - Not replace RTE_LIBRTE_ETHDEV_DEBUG in all PMDs. > > v3: > - rename "RTE_LIBRTE_ETHDEV_xxx" to "RTE_ETHDEV_xxx" > - move document from "overview.rst" page to "build_and_test.rst" > - fix grammar issues. > > v2: > - fix some coding style issues. > > > Qi Zhang (8): > ether: refine debug build option > net/fm10k: refine debug build option > net/e1000: refine debug build option > net/i40e: refine debug build option > net/iavf: refine debug build option > net/ice: refine debug build option > net/ixgbe: refine debug build option > net/igc: refine debug build option > For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.