From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id D8C8A922F for ; Fri, 4 Dec 2015 20:09:20 +0100 (CET) Received: by wmuu63 with SMTP id u63so74004605wmu.0 for ; Fri, 04 Dec 2015 11:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=I8i7dLmrbZts00qh6egU2KsgJm967SkjMRnjMqFQl5g=; b=UG4TNLT+Pi07M1TYI7XfCTnKhDqoD2LhDCHmir25uZAujbGrmeCghN0zYcnJn69T4u gw1JY0VeanrFDoQvtbhscMPEmfs6J4w4lN2IauR68XtfpwfqZV8q54qLmd9HVV62gkoJ BUhlcSnJzawTKQWnSqbzat7aKMHI6UriMVbULBYYHeZ/jBee1w92ZDxsNsVy3x9sd+5s rQulDFSbaRXoBRJSkePB/3qB43LbgadkU4XWI6aE3eIWKyMtn94AP8QX9PVGaWUdbLEc HdCNcpoB1+GpRoJMAxzsglrRGc9lEf3SIHJYUdzDUjii/r0C+AkeNq9EqhlMCsJBUCzC fhsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=I8i7dLmrbZts00qh6egU2KsgJm967SkjMRnjMqFQl5g=; b=G4ppXaSqzXb6VbBQbEwIjeZHTsLzHspZKdnCoSZdRLnCe9j+0ZL/Sv/NwPN2nXuxXw JnxZlOoac5UIy4XO7jPMhvG5DaxHaVlPKZsJTT5E/ow9JxYoXypwLSaTP92rgJX1+7tb icgxUF8RuQGRjzPBi+i29Sh8bWzbzZ4me3o8UokeYrpObit3CLcg9nQJTMCaKsc4R/qw bER8MslyTKuRCuKl2/zknQ6Pa9R3JflLyJhrdF+BIFCTpD4R6Cs4NPdnFSv88QshUt94 0KDm7GAlYRR0sTSd4GjCnZUmE0XR22ey2fuq2xg5/jcjtT3+ZRnLzDOOpK1NcxU26WaZ uUEw== X-Gm-Message-State: ALoCoQlQa7os/35yox3VO8zTTK/VbOZ5gZ12guJ1QvRd/FKYSfe0mPllmxUi9lnEY7dxcT/YhTZQ X-Received: by 10.194.58.5 with SMTP id m5mr19613465wjq.31.1449256160372; Fri, 04 Dec 2015 11:09:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id h4sm13261670wjx.41.2015.12.04.11.09.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Dec 2015 11:09:19 -0800 (PST) From: Thomas Monjalon To: Christian Ehrhardt Date: Fri, 04 Dec 2015 20:08:10 +0100 Message-ID: <9620658.jHQ3iUiUeS@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449126263-18796-1-git-send-email-christian.ehrhardt@canonical.com> References: <1449126263-18796-1-git-send-email-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode - v2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 19:09:21 -0000 2015-12-03 08:04, Christian Ehrhardt: > Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was > enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). > Now the underlying issue is rather simple, the xen code needs libxenstore. > But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was > disabled. > While it is correct to create the DPDK sublib linking only in the > RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked > libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled. > > Updates in Version 2: > Move it out of the --start-group as well > > Signed-off-by: Christian Ehrhardt Reported-by: Thiago Martins Applied, thanks