From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 56521A0C43;
	Thu, 15 Jul 2021 20:31:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D3C554014D;
	Thu, 15 Jul 2021 20:30:59 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 6E12740143
 for <dev@dpdk.org>; Thu, 15 Jul 2021 20:30:58 +0200 (CEST)
Received: from [100.65.0.149] (unknown [5.144.122.139])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B1D827F500;
 Thu, 15 Jul 2021 21:30:57 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B1D827F500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1626373857;
 bh=FBQgRALW3dEll7qk1yzAuHpgFAaap1ARGsur1Y8eCmE=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=E93ewsVg05whG5yRvGpANeifCZtwBuVk8x/zawdivHcFYZXZ6+1T1xiXBZJkKVa9e
 iThnZztja4TWlqn33txoRSmHVxWsaWSrbCzuMf8179PQADl5etkHXKsxS8rzh14Si8
 QQdMWRInZp4eiymhI1Msyb2HvQz1o7nTx0qzdgSA=
To: David Marchand <david.marchand@redhat.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Igor Romanov <igor.romanov@oktetlabs.ru>
Cc: dev <dev@dpdk.org>, Andy Moreton <amoreton@xilinx.com>
References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru>
 <20210702083948.546667-1-andrew.rybchenko@oktetlabs.ru>
 <20210702083948.546667-20-andrew.rybchenko@oktetlabs.ru>
 <CAJFAV8zMUKhqFC0eTGOPAUPDusTH2qwbdVh43K7WKCUDvJH42w@mail.gmail.com>
From: Ivan Malov <Ivan.Malov@oktetlabs.ru>
Message-ID: <96271e97-14e1-39b4-ae25-5ce5300e2083@oktetlabs.ru>
Date: Thu, 15 Jul 2021 21:30:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8zMUKhqFC0eTGOPAUPDusTH2qwbdVh43K7WKCUDvJH42w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 19/20] net/sfc: support flow action COUNT
 in transfer rules
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 15/07/2021 17:58, David Marchand wrote:
> On Fri, Jul 2, 2021 at 10:41 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>> diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst
>> index cf1269cc03..bd08118da7 100644
>> --- a/doc/guides/nics/sfc_efx.rst
>> +++ b/doc/guides/nics/sfc_efx.rst
>> @@ -240,6 +240,8 @@ Supported actions (***transfer*** rules):
>>
>>   - PORT_ID
>>
>> +- COUNT
>> +
>>   - DROP
>>
>>   Validating flow rules depends on the firmware variant.
> 
> 
> Sorry for catching this so late... this patch lacks some rte_flow capa update.
> I can fix when applying if someone confirms this is fine:

Yes, this should be fine.

> 
> diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini
> index 9e66ec4293..f6d998ddc8 100644
> --- a/doc/guides/nics/features/sfc.ini
> +++ b/doc/guides/nics/features/sfc.ini
> @@ -59,6 +59,7 @@ vlan                 = Y
>   vxlan                = Y
> 
>   [rte_flow actions]
> +count                = Y
>   drop                 = Y
>   flag                 = Y
>   mark                 = Y
> 
> 

-- 
Ivan M