From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B5C2C43075;
	Tue, 15 Aug 2023 20:58:08 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 41CFA4114B;
	Tue, 15 Aug 2023 20:58:08 +0200 (CEST)
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mails.dpdk.org (Postfix) with ESMTP id 8A1CC410ED
 for <dev@dpdk.org>; Tue, 15 Aug 2023 20:58:06 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D2CE761BD9;
 Tue, 15 Aug 2023 18:58:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84645C43395;
 Tue, 15 Aug 2023 18:58:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1692125884;
 bh=KwhvFsM9y6ZfxLYPyqpgHaYvGXKldtH7Wrc+7yj0Bqs=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
 b=d0EyG0TRbFusDbVmsPe8k5tcVt9ayGB8Z7slluHGoXx4h7xn+hOzFpHmVm3euzKPH
 mhe2ug3YkLY/bqVAZFPZiDgjulFwL3hlP4AGFYUKaXCYv3N/mml/KK78GIsSpE41t4
 XepK551jxyFxKOFTT9TLgZ+pYA0DQ6BYAs5UCELxC9fNYLk2qmS22Kg2MfSRKqMol9
 7eFBIlbMHMc2d08JBtiXRgKeVS1C7w4GSGTPn+kl1P5ny1xYwL0s4EwWr7PZMxqtVF
 Ts8Gr1z+BP3IAm0a6/y0DUCCNRQ3oUrMbwH02CWUqqR/NOPA/UFWPwzpGMlkT1OM3j
 L/+RHks37zv0A==
Message-ID: <9643dc6e7486019db77ba57b7f073b6c85867315.camel@kernel.org>
Subject: Re: [PATCH v4 0/8] support reinit flow
From: Sinan Kaya <okaya@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Date: Tue, 15 Aug 2023 14:58:03 -0400
In-Reply-To: <20230815104524.5ffcf627@hermes.local>
References: <20230815145023.1386003-1-okaya@kernel.org>
 <20230815104524.5ffcf627@hermes.local>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, 2023-08-15 at 10:45 -0700, Stephen Hemminger wrote:
> > Why?
> > It is not always ideal to reinitialize a DPDK process. Memory needs
> > to be reinitialized, hugetables need to warm up etc.
> 
> 
> 
> 
> I am familiar with the backstory of why this is desirable in your
> case.
> 
> But others may not be. It will work for you, but for the wider the
> 
> range of libraries and drivers it probably won't.
> 
> 

Fair enough.

> 
> As a compromise, can this restart be officially tagged as
> unsupported.

any pointers how to do this?

I have no idea how to mark something unsupported in code.
If this is acceptable in cover letter, I'm happy to do that too.

> 
> I.e. it may work for some drivers and libraries but not all of them.
> 
> If nothing else many parts of DPDK still do leak memory on cleanup
> 
> and currently this is harmless.
> 
> 
> 
> This has enough impact that it probably needs to wait past 23.11
> release.
> 
> 

Sure, no rush. Happy to wait for time slot and accumulate review
feedbacks.

> 
> Could you add a test for restart into standalone tests and test-pmd?

Will do.