From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8A52D388F for ; Wed, 19 Apr 2017 17:50:12 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2017 08:50:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,221,1488873600"; d="scan'208";a="91754420" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.59]) ([10.237.220.59]) by fmsmga006.fm.intel.com with ESMTP; 19 Apr 2017 08:50:04 -0700 Cc: Thomas Monjalon , Olivier Matz , dev@dpdk.org, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, jingjing.wu@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, venky.venkatesan@intel.com, arybchenko@solarflare.com, qiming.yang@intel.com References: <1488902393-7237-1-git-send-email-olivier.matz@6wind.com> <20170329083633.15626-1-olivier.matz@6wind.com> <6733058.qxCdJeOGN1@xps13> From: Ferruh Yigit To: Jing Chen , Andrew Rybchenko , Yuanhan Liu , Maxime Coquelin Message-ID: <964704da-42e8-203d-62bb-29f9c17eac92@intel.com> Date: Wed, 19 Apr 2017 16:50:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <6733058.qxCdJeOGN1@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 0/6] get status of Rx and Tx descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 15:50:14 -0000 On 3/30/2017 2:30 PM, Thomas Monjalon wrote: > 2017-03-29 10:36, Olivier Matz: >> This patchset introduces a new ethdev API: >> - rte_eth_rx_descriptor_status() >> - rte_eth_tx_descriptor_status() >> >> The Rx API is aims to replace rte_eth_rx_descriptor_done() which >> does almost the same, but does not differentiate the case of a >> descriptor used by the driver (not returned to the hw). >> >> The usage of these functions can be: >> - on Rx, anticipate that the cpu is not fast enough to process >> all incoming packets, and take dispositions to solve the >> problem (add more cpus, drop specific packets, ...) >> - on Tx, detect that the link is overloaded, and take dispositions >> to solve the problem (notify flow control, drop specific >> packets) >> >> The patchset updates ixgbe, i40e, e1000, mlx5. >> The other drivers that implement the descriptor_done() API are >> fm10k, sfc, virtio. They are not updated. Reminder for following PMDs: - fm10k - sfc - virtio There are two new eth_dev_ops: rx_descriptor_status tx_descriptor_status "rx_descriptor_status" replaces "rx_descriptor_done" It is suggested to switch to new one, and implement tx_descriptor_status Thanks, ferruh >> If the new API is accepted, the descriptor_done() can be deprecated, >> and examples/l3fwd-power will be updated to. > > Applied, thanks > > Next steps: > - implement it in other drivers > - deprecate descriptor_done API > > Ferruh, please, could you check with drivers maintainers? > Thanks >