From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9BB422B84 for ; Thu, 6 Apr 2017 16:46:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491489964; x=1523025964; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=13qCcTnUOjrFJ68QUamTArTdiqCM24k/Z+neM2qJiq8=; b=m2sI/iWsTrp08UvWeIONykGDWzWhGgliw9WsdtCBfvb7/z+9EjyP2Xjp VuW60Mye8Ot1Gc9amiShUywMrG3q5Q==; Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 07:46:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,160,1488873600"; d="scan'208";a="70315320" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by orsmga002.jf.intel.com with ESMTP; 06 Apr 2017 07:46:02 -0700 To: Thomas Monjalon References: <20170406121428.16883-1-ferruh.yigit@intel.com> <2608561.Cu0AakAGmg@xps13> <9561885.LnGWdCXozX@xps13> Cc: Jerin Jacob , Bruce Richardson , Harry van Haaren , dev@dpdk.org From: Ferruh Yigit Message-ID: <9652ec20-0878-83dc-a93e-167f862fd7e8@intel.com> Date: Thu, 6 Apr 2017 15:46:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9561885.LnGWdCXozX@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/thunderx: disable pmd for older compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 14:46:05 -0000 On 4/6/2017 3:09 PM, Thomas Monjalon wrote: > 2017-04-06 15:05, Ferruh Yigit: >> On 4/6/2017 2:59 PM, Thomas Monjalon wrote: >>> 2017-04-06 14:46, Ferruh Yigit: >>>> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk >>>> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk >>>> @@ -89,4 +89,8 @@ else >>>> ifeq ($(shell test $(GCC_VERSION) -lt 42 && echo 1), 1) >>>> MACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS)) >>>> endif >>>> + >>>> + ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) >>>> + CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n >>>> + endif >>> >>> In previous version you were disabling the PMD inside the PMD Makefile. >>> It was better. >> >> Agreed, but I that is causing a build error in applications. I have >> missed it in previous release because an .a file was already created. >> >> So, need a way to disable linking pmd against application. > > I see. > > If it is disabled here, we won't see the warning in the PMD Makefile? Oh, you are right, warnings in PMD Makefile become useless. I can set another flag in compat headers and check it in pmd makefile, will it be too much noise?