From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 502DCA0C47; Tue, 6 Jul 2021 10:36:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6DE440688; Tue, 6 Jul 2021 10:36:02 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 376B34067E for ; Tue, 6 Jul 2021 10:36:01 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C7C037F517; Tue, 6 Jul 2021 11:36:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C7C037F517 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625560560; bh=q/z9YZ76xd111iD9EiEuOxnYbgPRnuJrn8IMcBGvc60=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=XOqKV3scqZXWFlGL4UfN/3gAAavMqywbff9DUdRMs0NByD7zXgT8npAyQ+krz6rBN 8LwgSyFrv+jdtiX3u5YKgQ5riKlOq7kHs1Py3XPFx2IeI70XBCO6HtHdX42Rp3T6po JrnH5I6aKtQxV2Rb8dr3cg78lsFPqDxRXdQkCrrM= To: Huisong Li , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, "david.marchand@redhat.com" , Ray Kinsella References: <1620460836-38506-1-git-send-email-lihuisong@huawei.com> <1625544608-30590-1-git-send-email-lihuisong@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <966ec9cd-9142-b40d-b059-b63c8ece66bf@oktetlabs.ru> Date: Tue, 6 Jul 2021 11:36:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1625544608-30590-1-git-send-email-lihuisong@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" @David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which is backward compatible with DPDK_21? On 7/6/21 7:10 AM, Huisong Li wrote: > Currently, if dev_configure is not called or fails to be called, users > can still call dev_start successfully. So it is necessary to have a flag > which indicates whether the device is configured, to control whether > dev_start can be called and eliminate dependency on user invocation order. > > The flag stored in "struct rte_eth_dev_data" is more reasonable than > "enum rte_eth_dev_state". "enum rte_eth_dev_state" is private to the > primary and secondary processes, and can be independently controlled. > However, the secondary process does not make resource allocations and > does not call dev_configure(). These are done by the primary process > and can be obtained or used by the secondary process. So this patch > adds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started". > > Signed-off-by: Huisong Li Reviewed-by: Andrew Rybchenko > --- > v1 -> v2: > - adjusting the description of patch. > > --- > lib/ethdev/rte_ethdev.c | 16 ++++++++++++++++ > lib/ethdev/rte_ethdev_core.h | 6 +++++- > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index c607eab..6540432 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -1356,6 +1356,13 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > return -EBUSY; > } > > + /* > + * Ensure that "dev_configured" is always 0 each time prepare to do > + * dev_configure() to avoid any non-anticipated behaviour. > + * And set to 1 when dev_configure() is executed successfully. > + */ > + dev->data->dev_configured = 0; > + > /* Store original config, as rollback required on failure */ > memcpy(&orig_conf, &dev->data->dev_conf, sizeof(dev->data->dev_conf)); > > @@ -1606,6 +1613,8 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > } > > rte_ethdev_trace_configure(port_id, nb_rx_q, nb_tx_q, dev_conf, 0); > + dev->data->dev_configured = 1; > + I think it should be inserted before the trace, since tracing is intentionally put close to return without any empty lines in between. > return 0; > reset_queues: > eth_dev_rx_queue_config(dev, 0); > @@ -1751,6 +1760,13 @@ rte_eth_dev_start(uint16_t port_id) > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_start, -ENOTSUP); > > + if (dev->data->dev_configured == 0) { > + RTE_ETHDEV_LOG(INFO, > + "Device with port_id=%"PRIu16" is not configured.\n", > + port_id); > + return -EINVAL; > + } > + > if (dev->data->dev_started != 0) { > RTE_ETHDEV_LOG(INFO, > "Device with port_id=%"PRIu16" already started\n", > diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h > index 4679d94..edf96de 100644 > --- a/lib/ethdev/rte_ethdev_core.h > +++ b/lib/ethdev/rte_ethdev_core.h > @@ -167,7 +167,11 @@ struct rte_eth_dev_data { > scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */ > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > - lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > + lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > + dev_configured : 1; > + /**< Indicates whether the device is configured. > + * CONFIGURED(1) / NOT CONFIGURED(0). > + */ > uint8_t rx_queue_state[RTE_MAX_QUEUES_PER_PORT]; > /**< Queues state: HAIRPIN(2) / STARTED(1) / STOPPED(0). */ > uint8_t tx_queue_state[RTE_MAX_QUEUES_PER_PORT]; >