From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e
Date: Fri, 17 Oct 2014 09:39:52 +0200 [thread overview]
Message-ID: <9682370.k5Gd5eGDQ1@xps13> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com>
2014-10-17 05:58, Liu, Jijiang:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2014-10-11 13:55, Jijiang Liu:
> > > #
> > > +# Compile tunneling UDP port support
> > > +#
> > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789
> > > +
> > > +#
> >
> > 1) this option is not to "Compile tunneling UDP port support"
> Change the comment as "tunneling UDP default port configuration"
> > 2) why is it a compile time option? should it be an API parameter or a
> > runtime option?
>
> In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port,
> and this value SHOULD be used by default as the destination UDP port.
> Some early implementations of VXLAN have used other values for the
> destination port. To enable interoperability with these implementations,
> the destination port SHOULD be configurable."
Please, do not consider a compile time option like "configurable".
There are some cases where the user cannot or don't want to rebuild DPDK.
> I have provided a API to configure UDP port.
OK, good.
> But a default UDP port number is needed where PF startup if current mode is
> VxLAN mode.
Sorry, I don't understand this part.
Why are you adding a default tunnel when initializing?
Is it not enough to allow adding new tunnels with custom port?
--
Thomas
next prev parent reply other threads:[~2014-10-17 7:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 5:55 [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 1/8]i40e:support VxLAN packet identification in librte_ether Jijiang Liu
2014-10-16 17:07 ` Thomas Monjalon
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Jijiang Liu
2014-10-13 16:12 ` De Lara Guarch, Pablo
2014-10-16 10:19 ` De Lara Guarch, Pablo
2014-10-16 19:56 ` Thomas Monjalon
2014-10-17 5:58 ` Liu, Jijiang
2014-10-17 7:39 ` Thomas Monjalon [this message]
2014-10-20 1:25 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 3/8]app/test-pmd:test VxLAN packet identification Jijiang Liu
2014-10-16 20:01 ` Thomas Monjalon
2014-10-17 5:23 ` Liu, Jijiang
2014-10-17 7:41 ` Thomas Monjalon
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API Jijiang Liu
2014-10-15 16:01 ` De Lara Guarch, Pablo
2014-10-16 1:24 ` Liu, Jijiang
2014-10-16 12:41 ` De Lara Guarch, Pablo
2014-10-16 20:09 ` Thomas Monjalon
2014-10-17 6:53 ` Liu, Jijiang
2014-10-17 7:47 ` Thomas Monjalon
2014-10-20 1:22 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 5/8]i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 6/8]app/testpmd:test VxLAN packet filter API Jijiang Liu
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload Jijiang Liu
2014-10-16 20:34 ` Thomas Monjalon
2014-10-17 5:20 ` Liu, Jijiang
2014-10-11 5:55 ` [dpdk-dev] [PATCH v5 8/8]app/testpmd:test " Jijiang Liu
2014-10-11 7:28 ` [dpdk-dev] [PATCH v5 0/8]Support VxLAN on Fortville Liu, Yong
2014-10-11 7:56 ` Liu, Yong
2014-10-16 20:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9682370.k5Gd5eGDQ1@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).