From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 821A17E7A for ; Fri, 17 Oct 2014 09:32:11 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id hi2so1314902wib.3 for ; Fri, 17 Oct 2014 00:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=eLhcyIPAro77JB50dcEjKyUSDnfAMD561AzZPeHZoIk=; b=fX5jGwU9PmG1E9EUloPl3r+KlqoR5o5Jeu1s0a4SkcZk9e4lFamfHjHhR37fFT8LA5 CjnfX5jX4g9RkggcpoF+H+42pSeZB1yuT6GdRz+glICEKWJfOkETdZJkNWVlcGBPFoGm /osxSeCxD5L4dMw+gT6NbKqKwcodkA9K0R8uwsy9cqPj4605+8piBlEVq3tPytOL2SAY sR0PibZpjAoKO30WMZo4+6qvv5OYMvvrNMwk2O+ED93vomYHVfgtDPILIbP0p6vcNa1P 2EmT2RYygnRJ+WC9fQaI7yrR9+EXFCfQLU4fTz3ehNNP/YFZU8l/lvDzw0dFxVxgJIgE kZRw== X-Gm-Message-State: ALoCoQnxhEwK5P50lrWLNYDZvIwYURaOX9n24qBMfgZwKWHrqvEre6c/vBpA5bAynKzRDrZuL+bP X-Received: by 10.194.104.170 with SMTP id gf10mr8389089wjb.88.1413531608389; Fri, 17 Oct 2014 00:40:08 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id mc4sm1076877wic.6.2014.10.17.00.40.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Oct 2014 00:40:07 -0700 (PDT) From: Thomas Monjalon To: "Liu, Jijiang" Date: Fri, 17 Oct 2014 09:39:52 +0200 Message-ID: <9682370.k5Gd5eGDQ1@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <3781474.dkZOSRuQuF@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 07:32:11 -0000 2014-10-17 05:58, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-11 13:55, Jijiang Liu: > > > # > > > +# Compile tunneling UDP port support > > > +# > > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789 > > > + > > > +# > > > > 1) this option is not to "Compile tunneling UDP port support" > Change the comment as "tunneling UDP default port configuration" > > 2) why is it a compile time option? should it be an API parameter or a > > runtime option? > > In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port, > and this value SHOULD be used by default as the destination UDP port. > Some early implementations of VXLAN have used other values for the > destination port. To enable interoperability with these implementations, > the destination port SHOULD be configurable." Please, do not consider a compile time option like "configurable". There are some cases where the user cannot or don't want to rebuild DPDK. > I have provided a API to configure UDP port. OK, good. > But a default UDP port number is needed where PF startup if current mode is > VxLAN mode. Sorry, I don't understand this part. Why are you adding a default tunnel when initializing? Is it not enough to allow adding new tunnels with custom port? -- Thomas