Re: [dpdk-dev] [PATCH v3 00/11] Port XStats

[Tom Crugnale <tcrugnale@sandvine.com>]

Hi Harry,

We are planning on using the xstats API for periodic stats collection through a polling thread.  This would be done in a generic NIC agnostic manner, which would require that the xstats identifiers have consistent naming amongst all of the NIC types.  It would likely be polled several times per second and would only gather a subset of all available xstats types.  

I have reviewed your patches and am interested in providing some API enhancements and bugfixes.  Are you willing to provide feedback on such changes?

Thank you,
Tom

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
Sent: Thursday, October 22, 2015 11:48 AM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 00/11] Port XStats

This patchset adds an implementation of the xstats_get() and xstats_reset() API to the following PMDs: virtio, igb, igbvf, ixgbe, ixgbevf, i40e, i40evf and fm10k.

The xstats API allows DPDK apps to gain access to extended statistics from each port on a NIC. These statistics are structured as per a scheme detailed in the patch for the doc/prog_guide.


Harry van Haaren (11):
  doc: add extended statistics notes
  doc: add extended statistics to prog_guide
  ethdev: update xstats_get() strings and Q handling
  virtio: add xstats() implementation
  igb: add xstats() implementation
  igbvf: add xstats() implementation
  ixgbe: update statistic strings to scheme
  ixgbevf: add xstats() functions to VF
  i40e: add xstats() implementation
  i40evf: add xstats() implementation
  fm10k: add xstats() implementation

 doc/guides/prog_guide/poll_mode_drv.rst |  51 ++++-
 doc/guides/rel_notes/release_2_2.rst    |  12 ++
 drivers/net/e1000/igb_ethdev.c          | 194 +++++++++++++++++-
 drivers/net/fm10k/fm10k_ethdev.c        |  87 ++++++++
 drivers/net/i40e/i40e_ethdev.c          | 265 +++++++++++++++++++++++-
 drivers/net/i40e/i40e_ethdev_vf.c       |  89 +++++++-
 drivers/net/ixgbe/ixgbe_ethdev.c        | 346 +++++++++++++++++++++++++++++---
 drivers/net/virtio/virtio_ethdev.c      |  98 ++++++++-
 drivers/net/virtio/virtio_rxtx.c        |  32 +++
 drivers/net/virtio/virtqueue.h          |   4 +
 lib/librte_ether/rte_ethdev.c           |  38 ++--
 11 files changed, 1154 insertions(+), 62 deletions(-)

--
1.9.1