From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by dpdk.org (Postfix) with ESMTP id D370211F5 for ; Wed, 28 Oct 2015 18:35:10 +0100 (CET) Received: from WTL-EXCHP-1.sandvine.com ([fe80::ac6b:cc1e:f2ff:93aa]) by wtl-exchp-2.sandvine.com ([::1]) with mapi id 14.03.0195.001; Wed, 28 Oct 2015 13:35:11 -0400 From: Tom Crugnale To: Harry van Haaren , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 00/11] Port XStats Thread-Index: AQHRDOEzOJ084RKu3ESG/zJCqVT5RZ6BMnKw Date: Wed, 28 Oct 2015 17:35:09 +0000 Message-ID: <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> References: <1443606022-13581-2-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.200.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 00/11] Port XStats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 17:35:11 -0000 Hi Harry, We are planning on using the xstats API for periodic stats collection throu= gh a polling thread. This would be done in a generic NIC agnostic manner, = which would require that the xstats identifiers have consistent naming amon= gst all of the NIC types. It would likely be polled several times per seco= nd and would only gather a subset of all available xstats types. =20 I have reviewed your patches and am interested in providing some API enhanc= ements and bugfixes. Are you willing to provide feedback on such changes? Thank you, Tom -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren Sent: Thursday, October 22, 2015 11:48 AM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v3 00/11] Port XStats This patchset adds an implementation of the xstats_get() and xstats_reset()= API to the following PMDs: virtio, igb, igbvf, ixgbe, ixgbevf, i40e, i40ev= f and fm10k. The xstats API allows DPDK apps to gain access to extended statistics from = each port on a NIC. These statistics are structured as per a scheme detaile= d in the patch for the doc/prog_guide. Harry van Haaren (11): doc: add extended statistics notes doc: add extended statistics to prog_guide ethdev: update xstats_get() strings and Q handling virtio: add xstats() implementation igb: add xstats() implementation igbvf: add xstats() implementation ixgbe: update statistic strings to scheme ixgbevf: add xstats() functions to VF i40e: add xstats() implementation i40evf: add xstats() implementation fm10k: add xstats() implementation doc/guides/prog_guide/poll_mode_drv.rst | 51 ++++- doc/guides/rel_notes/release_2_2.rst | 12 ++ drivers/net/e1000/igb_ethdev.c | 194 +++++++++++++++++- drivers/net/fm10k/fm10k_ethdev.c | 87 ++++++++ drivers/net/i40e/i40e_ethdev.c | 265 +++++++++++++++++++++++- drivers/net/i40e/i40e_ethdev_vf.c | 89 +++++++- drivers/net/ixgbe/ixgbe_ethdev.c | 346 ++++++++++++++++++++++++++++= +--- drivers/net/virtio/virtio_ethdev.c | 98 ++++++++- drivers/net/virtio/virtio_rxtx.c | 32 +++ drivers/net/virtio/virtqueue.h | 4 + lib/librte_ether/rte_ethdev.c | 38 ++-- 11 files changed, 1154 insertions(+), 62 deletions(-) -- 1.9.1