From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by dpdk.org (Postfix) with ESMTP id 28FD4A6A for ; Thu, 29 Oct 2015 01:55:36 +0100 (CET) Received: from BLR-EXCHP-2.sandvine.com (192.168.196.172) by wtl-exchp-1.sandvine.com (192.168.194.176) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 28 Oct 2015 20:55:34 -0400 Received: from WTL-EXCHP-1.sandvine.com ([fe80::ac6b:cc1e:f2ff:93aa]) by blr-exchp-2.sandvine.com ([fe80::6c6d:7108:c63c:9055%14]) with mapi id 14.03.0181.006; Wed, 28 Oct 2015 20:55:34 -0400 From: Tom Crugnale To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v3 00/11] Port XStats Thread-Index: AQHRDOEzOJ084RKu3ESG/zJCqVT5RZ6BMnKwgACHFQD///H4YA== Date: Thu, 29 Oct 2015 00:55:33 +0000 Message-ID: <9689034CEF26614CAB4B447EEAAF98E918241CB2@wtl-exchp-1.sandvine.com> References: <1443606022-13581-2-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> <9689034CEF26614CAB4B447EEAAF98E918241AD3@wtl-exchp-1.sandvine.com> <20151029063216.4675da65@samsung9> In-Reply-To: <20151029063216.4675da65@samsung9> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.200.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 00/11] Port XStats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 00:55:36 -0000 I understand. Is this the reason that that strings were used to identify t= he xstat types? An enum type would be much more efficient instead of doing= string copies when retrieving the stats, but the number of enum entries wo= uld quickly grow out of control as device specific stats were added. In this case, I'm actually referring to the stats that are common to all NI= Cs. For example, for the received fragmented packets counter, there are th= ree strings that identify this value: rx_fragment_packets (igb), rx_fragmen= t_errors (ixgbe), rx_fragmented_packets (i40e). I was thinking of making those names consistent. Perhaps the reason why th= ey were different in the first place is that each of the device datasheets = refers to these exact names. Tom -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Wednesday, October 28, 2015 5:32 PM To: Tom Crugnale Cc: Harry van Haaren; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 00/11] Port XStats On Wed, 28 Oct 2015 17:35:09 +0000 Tom Crugnale wrote: > Hi Harry, >=20 > We are planning on using the xstats API for periodic stats collection thr= ough a polling thread. This would be done in a generic NIC agnostic manner= , which would require that the xstats identifiers have consistent naming am= ongst all of the NIC types. It would likely be polled several times per se= cond and would only gather a subset of all available xstats types. =20 >=20 > I have reviewed your patches and am interested in providing some API enha= ncements and bugfixes. Are you willing to provide feedback on such changes= ? >=20 > Thank you, > Tom The whole point of xstats is to allow device specific statistics. Consistent use of names is good from a user interface point of view, but pr= obably not a hard requirement.