From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89A97A0A02; Fri, 16 Apr 2021 20:40:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C1AA161D46; Fri, 16 Apr 2021 20:40:33 +0200 (CEST) Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by mails.dpdk.org (Postfix) with ESMTP id 2DCC8161D3F for <dev@dpdk.org>; Fri, 16 Apr 2021 20:40:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 1FD03149F; Fri, 16 Apr 2021 14:40:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Apr 2021 14:40:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8ep4ffKWFRKgGWhk9+qFyH9Wv4QZ5r6DOzvhSAce8KQ=; b=QQEmwD6ShqsWQn4o aYdSLqrbjaQ3pvKJZl2+t9zMgvYGQEiohbKchivWyh2Da4Ep1VdUbMlz9NHoBqYB wyzYkFd9FnA8bBDEgsd5opImJ6v0QQ1spel64Tf7BKXme1peF5n7wqOrFDtv54Vp YVKTbXMxu0LlQI9w4GU0l7lbQRqNHbWAwvZj4MRQqU4HmB6dGlPVBngsC8xYeGib 6LAIgnstq/2Fy4QMwSYxb2Rj0wwcr3uZf/9gRnkbE+pOVdaurQ8Om7EiPdidgC/m p5Zxtm8x1hPFdoKhcUROcMwLmLxv8WoYqj1N0TbfG+/CAJS7cNyDLfMdqxZFD2MK YUJEAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8ep4ffKWFRKgGWhk9+qFyH9Wv4QZ5r6DOzvhSAce8 KQ=; b=S3C3eGINIG9zCzxKZ+2CgbX3TRKtqCGdXx6uqv4xhNiwLLteh0dO+BYQH vewMHTe6ForQy2EQlOXqLre4VpM027/KBEf1DuIYVy0pY29bU/lYwOm6yGblIjqf HO6SmUqrSdQ3bxyCh4doM2Mnyt/v2eyFEp6qQJSy06lEnoiwFW0pxV7CCCbMwCIy W+tAXyoG71+mJ4CTMod9AMYgLzXe/ZGX4h6zuv6K5vnPmrW9vVxihKXeTbZjS5Wi Vptk7xzRCdPB1Tbx7tA4wx7mJOzOpBKLGgIhnmRwnCgiA1W9wizNwAbTduXZ5Gf6 j+XH0FjSNjNSkFRSujye2fkcbJWKQ== X-ME-Sender: <xms:G9p5YK2OZOJsmNfDVLA86k-CYJJTOSF5ncT17Iapq2Zxm84erHXz4A> <xme:G9p5YNFJcpKWQEPku89wt_e_XBUzyAjQFor2LOCyX1eiav6g9ghpwYeA1VJoVk7pv VSeRxehOsMlwea7Xg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelhedgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:G9p5YC6MB0vgn4kJ9KkMvP_jiaVcEGU0AIKIYCl-gGTIAAvQOHuyZQ> <xmx:G9p5YL1vcx2wjfSq99ZvMFqeKT6RUsh9oG4sFccQoUQVfI2_r1TeXg> <xmx:G9p5YNElCmVv6-eAI7ltyTIvmI8uKvTo-tBjYMDtnAt7ZU8ezCFOfw> <xmx:HNp5YDbciRjLkGEilV7x8NEqjUs-2YBOA0RhtDhLFL5DSNsfQc-5XRL_Ey8> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D378B108005B; Fri, 16 Apr 2021 14:40:26 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com>, Shepard Siegel <shepard.siegel@atomicrules.com>, Qiming Yang <qiming.yang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Rosen Xu <rosen.xu@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com> Cc: "Mcnamara, John" <john.mcnamara@intel.com>, Ciara Power <ciara.power@intel.com>, "Min Hu (Connor)" <humin29@huawei.com> Date: Fri, 16 Apr 2021 20:40:25 +0200 Message-ID: <9694923.JHvA49bgKg@thomas> In-Reply-To: <a7fa69c8-a402-672a-817a-967c6b619188@huawei.com> References: <1618051221-19962-1-git-send-email-humin29@huawei.com> <CAJFAV8wEe290ry1AwxuZdB2qLKqsYAkcdW6tDSo_coEM6=PsDQ@mail.gmail.com> <a7fa69c8-a402-672a-817a-967c6b619188@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/7] support set thread name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 13/04/2021 03:12, Min Hu (Connor): > =E5=9C=A8 2021/4/12 15:19, David Marchand =E5=86=99=E9=81=93: > > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) <humin29@huawei.com> w= rote: > >> > >> This set of patches support set thread name for debugging. > >> > >> Chengwen Feng (7): > >> net/ark: support set thread name > >> net/ice: support set VSI reset thread name > >> vdpa/ifc: support set notify and vring relay thread name > >> raw/ifpga: support set monitor thread name > >> examples/performance-thread: support set thread name > >> telemetry: support set init threads name > >> examples/vhost_blk: support set ctrl worker thread name > >=20 > > Rather than add those calls, can maintainers check if their component > > can use ctrl threads instead? > > rte_ctrl_thread_create ensures both that the name is set, and that the > > ctrl thread won't run on the same cpu as "datapath" threads. > >=20 > > I also saw some issues with components creating threads. > > I'll post a series addressing those later (net/ark, net/ice not > > detaching/joining created threads + telemetry not checking > > pthread_create failures). > >=20 > Totally agree with David. > By the way, for "telemetry not checking pthread_create failures", I have > sent patches to fix it. Please check it out. > Thanks. Do I understand correctly that we prefer switching to rte_ctrl_thread_create() instead of this patch series adding rte_thread_setname()? Any volunteer to add the use of rte_ctrl_thread_create() in these drivers and examples?