From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C71D43B64; Wed, 21 Feb 2024 17:35:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1055740685; Wed, 21 Feb 2024 17:35:12 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2064.outbound.protection.outlook.com [40.107.212.64]) by mails.dpdk.org (Postfix) with ESMTP id 24A67402CE; Wed, 21 Feb 2024 17:35:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bK6TTaiWbAnS1h1uye7MytLezjjNrZv3A/kZp8c9zL+Wt7hZnH53lQB9ibPQL/6KXObgQ3tDJpuW/X4gh3a0veIU8pm/rv8lslA8Fkj1QdNMzE5SeGtvmsucDloLbKQe5XBA8fd/AlrEtfaa7FOsdcx2LX/8I0qc7BxQU4LLDFI6mHnCMUzfqtZbbAnFKTHJQ6ogyYKyc0Us8OfamrP3ndK9pBLq/VfM9m3C6mLY9OeiGJ+Mkj13j/9mZAscY5f5eKQL9oGDkWtOmF4wH3o8Ph3zMqD9OxPbVOGL89adhB9N/LmN+beXAtnGxXxQ6Wevl7K8lzHRrUxLWAnmnjTH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjrLIFuuVGlk0LKB0qSk2lu3m2Cz5sJpIk4ALyVAPOk=; b=TspMC98GgxHpxwmi8+07fI/+5xSSiOM8F6JnLqc+8d3IlUC2vpmyXGsNyLeSJ2iCYvByQn9puprdkaUZEda0jwjFaGcc4AxLyE3omfFw2gojckqONj+3dbV8d2L+vuvBLolmiCxqyxlUSi8aKTDRyI42Hpaifg/LJN7WGNdscJm25A+4jieXM1WzJr06XjC014OVJON3yAs5ZLphpG/p2zlXRMnUFrmsjypmxCYgBdJY5ifUgQDrr565jlLPqitg939rXnWGvgQUZhesYdZnmj1V6PvpqlDl1CIaNvdVlW5BK7uiEkpf2xLeNLB6P2tiNUYQX1DJ9bu925+iPlnS/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjrLIFuuVGlk0LKB0qSk2lu3m2Cz5sJpIk4ALyVAPOk=; b=Gy5Od+tzxA8GKzLAIXGyppa0EUDFJnzRxwhtf+y0b+jHWRd6bnJmNGt61K0MoaThFYZMHCUskJmEF1H2Wv+Q3iir3gNRXlK6TB31CCPRCOEaEiXmSk6GIhCphEjU0DAEXabtyE08vXdwo10PczXDh/Is/vKFMtOSVILb16lf2T8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8227.namprd12.prod.outlook.com (2603:10b6:208:406::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 16:35:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 16:35:05 +0000 Message-ID: <9698f520-f64c-41ea-8159-52932b96b61b@amd.com> Date: Wed, 21 Feb 2024 16:35:04 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] net/mlx5: fix modify flex item error Content-Language: en-US To: Rongwei Liu , dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, thomas@monjalon.net Cc: michaelba@nvidia.com, stable@dpdk.org, Dariusz Sosnowski References: <20240221071043.3309205-1-rongweil@nvidia.com> <20240221071043.3309205-3-rongweil@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240221071043.3309205-3-rongweil@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P190CA0006.EURP190.PROD.OUTLOOK.COM (2603:10a6:10:550::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8227:EE_ X-MS-Office365-Filtering-Correlation-Id: c2ae8d5f-a52f-43f9-e81a-08dc32fb0f5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tAcgoWtu9NxA6b577GqW5IRHvv70wFn8MnrKpZdAwcigcrnyEs2b0m4EDcUzTs1hpoC5rVnc47cO/kpWW7SO5pjOIF6xcU/YTghkVA7id5HA+N7s56faiaQCjgqjvkq8fJ1HOOlCPIikzIfRJGnGCkoi+X680M8TnM26Rs9sFistPEjSHMTH7PYf7vRbkeUh9dhWfmFTRwpfasXDYGM1avBu1ZCdHrcZ4tZg4Qi0R44XIOx7m3vB78w7QlOUQvMlTncpFokUJiWT1c1sTYod9Lg2Jpkc7PeXQqdmPRtpdEYkxL9x1Js7WNKtQ4eQnBoRYPwNUYaTZPIEo0kiL/x/rdKgnWU9I2i/C4IELSoz+jMine7OTFXXdMIrU+egoDelXhgk9n7fatNLx6TswpMFabFBkvmhV/rocFsSimqNDP37OGDlEOrAfroHcN+uiDQ3hcru4SWk6/DWZCRMjtdWhB7ylA4OJVU9RXQ8iv4uB/OOXKWjJeVLnfRPuNvvGfGDaJSVT9epAyOJ99wU+buHcIL/FwOUyudfFPEum3noCeA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUJxYmUvc3pZNmVKckRuMGVOaE5xSHo2ekdiajdkazdvVkZWZEtKck5hZ01p?= =?utf-8?B?SGVXNzVDT3A4MHROanJLano2YkxML3BWMXBnUUxwS0tjNHRFeWxCejJod2Z6?= =?utf-8?B?TFZhZ080T0c4SDdDMFpQYTYraURENXhuNWVmaTc1OWRrN2U1Mng4VjNMdXJQ?= =?utf-8?B?bU5Ba0EzTzA5dkxIVW05ZHNkSXN4WStWMWVITTFGZm9DUXkvbWZ2bTdMeTlN?= =?utf-8?B?MXRwQ3J2WDNrRDk2VW1lMGZnUGdlRmJnbE1PVzdHV01WeHBDQS94WkRPTUVU?= =?utf-8?B?cC9mTFNKNHhheS9OZDg0Mmo5UG9FUWFtNklaS29oU2RlOTBJcEV6eEtuWUVN?= =?utf-8?B?QmwxOUFvNTRCcGlXbE4rbGJKK0g5TXVVeTNmNVdSblJNTTB2ZldDRTc0aU1k?= =?utf-8?B?U3QvYmdBSUdtL3kxc3hQVWNpUFBHWDYxSFFwcHhoWmVkampFMnQrMjhDc3ZN?= =?utf-8?B?Z2FGRDBPR3ZLZmdYL1BmbGZVM1Zocm9DVmh2aGRXamZtSWt6OU0xZThodTdZ?= =?utf-8?B?OXM1Qm91UysvMVZnY2FTZE9HT0htbnI1b1l5WldNL0dUZ3VnYjBueWJpOU9p?= =?utf-8?B?dzQyYTdPek9XU2JES1UrUlM5U1NDVkxIbXVjaFFjZ2xvdjNRZnlrRW9FY0Iv?= =?utf-8?B?V0pIWStwZ3lSNHcycnNkYzFtbGtmZWtVeFYyT2JsaVA5cnlCVUlIU2V0MjQ1?= =?utf-8?B?bGVycldUUHNxNmtoeFd6eUc3ZmRXME4yd2pYeHh6VzRaWWtxeEVqTmZBQUR5?= =?utf-8?B?dVVwdG9qM0J3WDRsUjdWRDF2dENTQjRPcUZDQU44NnQxQXFFUld2ZDVuU0xH?= =?utf-8?B?Z1VsMFZEWkYvMitJZ2JXNFh6a2dBN0hCMVFMbFMyeTY2YytMaTd2d080WHVr?= =?utf-8?B?VlE0V1MvZytsem40WUJjcmF0Z25qc1VmZnlIdjFpZmRyMHNUcUR3RmtoSU9N?= =?utf-8?B?VW82RWMxS3NJRDNYZTl4NEdyRkxIeG1KL3JqV1VXNE5hUG1uTjdaaUc4dVFP?= =?utf-8?B?WlpXbjNDQng2Q2d0eU9SaEZTdGwyL1pwVGY0anVkRmtURUZBOGpEVVZYREZl?= =?utf-8?B?blZsb1VTRkRSZk9PZ2ZzK0RJbloxNDN0TU5TSmQ2OGQweFA0dkQ1cUQ0SDZL?= =?utf-8?B?Yi9sbHhJOHdIR0w3N3ZmSDgrcGxrbm5OWVVBME9xSU9EbEZLMXA4c0V0MEkx?= =?utf-8?B?SFdpQUNnUWI4K2VrcW1VTVRQQXpxeUdFWGk5ZmFQUGFhUURNckJWYXB2NHdG?= =?utf-8?B?eXVXU1h0SWxvK0VpOGIxZjErczdBQ0l6dUNVdDd5RDA3aDl6VmVUcWI1Q0Nk?= =?utf-8?B?aEx4RU42eVZTNHRKeTNFY1JrVlZ0WjhPN3FBMHorbHpGRHcwRElMQU5qdFpr?= =?utf-8?B?eTBGb0hCU3RsaEx5Qy9JZUlPcHRsZTdIMno4cVV2eVdaQjNtb1owek9kRTB2?= =?utf-8?B?MUMxUDJJOG5WU09JNEt0N0psWkxPdnpBSWp0QmYzWHRndGNhNVMvcUY2bUEv?= =?utf-8?B?WWR6eXBGdEgyMS85dzE1UFI2V01LWWQvNWFHczJLaXZFa2lFUEFlWVJGQnRj?= =?utf-8?B?ZUdXdURibWVTSVl5QTNsamZrYk5sVS9JZHVTR2tLZ2MwUkxJY0dlODJrcmt3?= =?utf-8?B?alZ6Vlo4bnRYbElOYzdhQS8rdGpOelg0NXM4d1Q5NUpwTlVlUFJtUHVyZkdL?= =?utf-8?B?ci9TdXFpU0xhTTFKb2ErTHdoelBMOXN2QlV2Nk1FNGNMSkVtYnVTWk95YUFQ?= =?utf-8?B?OHM3RUdlaEdoSk9walM1VmVLRk1MbjhqMnk0cGpFNjJCM2NMTnA2VHFMd3Z2?= =?utf-8?B?aGlGK0FMVjYzME5nZG9Nd1kwak1lWGJEalhlc0dhNWRZaXovcElWV1FidUtz?= =?utf-8?B?OUw5OStBSHZTRkJ1S0lMVlRoOVJDeW13ZVY2UjVibGk1b3FDbFMrcncrQkxk?= =?utf-8?B?VmI2OXJJaU9XeElaby9VQjM3WW9GVG5LME5qSGo2RVZSdHJnWVJlMUN0UDZD?= =?utf-8?B?WHR0S1RRUi9wUjBvOE9Va0h1cFgya2tObnRUQml2TVFjMTJUczNkWnBaaWZG?= =?utf-8?B?dUlFS21RSXNRM0dKUXFEWmxLNFBwdXpybVVpQTBiQlZSNUFWd0FsSjJvc1dT?= =?utf-8?Q?ez3/B8OqUIMVxsZl9TGQjumLU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2ae8d5f-a52f-43f9-e81a-08dc32fb0f5c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 16:35:05.7877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uig+OHU+vjDj8kNIp+Wxs4iT9gxsQ/LeR15hHDept/3WUdcfFzVPpBi9PP8oyUtU X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8227 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2024 7:10 AM, Rongwei Liu wrote: > In the rte_flow_field_data structure, the flex item handle is part > of union with other members like level/tag_index. > > If the user wants to modify the flex item as source or destination, > there should not be any checking against zero. > > Signed-off-by: Rongwei Liu > Fixes: 7ea38955b ("ethdev: update MPLS header modification API") > Cc: michaelba@nvidia.com > Cc: stable@dpdk.org > Acked-by: Dariusz Sosnowski > Hi Rongwei, I can't (also CI can't) apply this patch, on which tree it is based on?