From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C59E84242A; Fri, 20 Jan 2023 04:51:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC69240223; Fri, 20 Jan 2023 04:51:54 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 77E14400D5 for ; Fri, 20 Jan 2023 04:51:53 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Nylrd2CqpzJrHX; Fri, 20 Jan 2023 11:50:25 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 20 Jan 2023 11:51:50 +0800 Subject: Re: [PATCH v2 5/5] ethdev: telemetry xstats support hide zero To: Bruce Richardson CC: , , , , , References: <20221219090723.29356-1-fengchengwen@huawei.com> <20230111120630.31172-1-fengchengwen@huawei.com> <20230111120630.31172-6-fengchengwen@huawei.com> From: fengchengwen Message-ID: <96a22fa7-be51-70b2-188f-c9ac3803aee3@huawei.com> Date: Fri, 20 Jan 2023 11:51:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, On 2023/1/11 22:08, Bruce Richardson wrote: > On Wed, Jan 11, 2023 at 12:06:30PM +0000, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> >> Signed-off-by: Chengwen Feng >> --- >> lib/ethdev/rte_ethdev.c | 28 ++++++++++++++++++++++------ >> 1 file changed, 22 insertions(+), 6 deletions(-) >> >> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c >> index 2fc593b865..77cacc0829 100644 >> --- a/lib/ethdev/rte_ethdev.c >> +++ b/lib/ethdev/rte_ethdev.c >> @@ -5870,20 +5870,33 @@ eth_dev_handle_port_xstats(const char *cmd __rte_unused, >> { >> struct rte_eth_xstat *eth_xstats; >> struct rte_eth_xstat_name *xstat_names; >> + char *end_param, *hide_param; >> int port_id, num_xstats; >> + int hide_zero = 0; >> int i, ret; >> - char *end_param; >> >> if (params == NULL || strlen(params) == 0 || !isdigit(*params)) >> return -1; >> >> port_id = strtoul(params, &end_param, 0); >> - if (*end_param != '\0') >> - RTE_ETHDEV_LOG(NOTICE, >> - "Extra parameters passed to ethdev telemetry command, ignoring\n"); >> if (!rte_eth_dev_is_valid_port(port_id)) >> return -1; >> >> + if (*end_param != '\0') { >> + hide_param = strtok(end_param, ","); >> + if (!hide_param || strlen(hide_param) == 0 || !isdigit(*hide_param)) >> + return -EINVAL; >> + hide_zero = strtoul(hide_param, &end_param, 0); >> + if (*end_param != '\0') >> + RTE_ETHDEV_LOG(NOTICE, >> + "Extra parameters passed to ethdev telemetry command, ignoring\n"); >> + if (hide_zero != 0 && hide_zero != 1) { >> + hide_zero = !!hide_zero; >> + RTE_ETHDEV_LOG(NOTICE, >> + "Hide zero parameter is non-boolean, cast to boolean\n"); >> + } >> + } >> + > > I'm not sure about this adding of an extra flag as a 0/1 value. That would > seem to make it confusing with a queue number or extra port number. For > such an optional parameter, I think a string value would be clearer. A > number of alternatives I'd suggest - in order of my preference (least > preferred to most preferred): > > * have the extra parameter as a literal string "hide_zeros" which is > matched against rather than looking for 0/1, or alternatively add string "hide_zeros" requires more characters, it may not user friendly. > > * add a new command /ethdev/xstats_nonzero which does this, the same > callback can be reusued, just checking the command given, or finally, The new command may cause confusion. > > * if this is primarily for the benefit of users using the telemetry script > to interactively view stats, then the functionality could be implemented > in the script itself rather than in the backend. We could add some > setting, or extra flag to the display code, to possibly filter out zeros > in the display. This may causes the display logic to be coupled with the command name. > > Thoughts? I prefer add optional parameter, and the optional parameter should be simpler, just a number here. And for clearer expression, I reword the help string in V4: Returns the extended stats for a port. Parameters: int port_id, bool hide_zero (Optional, non-zero indicates hide zero xstats) Thanks. > > /Bruce > . >