From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D1AEA0548; Thu, 27 May 2021 11:51:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEDA4407FF; Thu, 27 May 2021 11:51:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4DABC40143; Thu, 27 May 2021 11:51:25 +0200 (CEST) IronPort-SDR: UpzkMAqhuoX54Mq7NUQUSLCwZ/0r82oRCQ8RyEjTzCnSGToG+PCrx3dGenipCBOy56QSf61xRN dZ3ztHbP9frA== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="189813913" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="189813913" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 02:51:23 -0700 IronPort-SDR: uObJyk0LGdKAGSkt5d4iEOLGPpp0t4H6cH/Gf3+liZG39RKAZUcy1uWqCLbs8iPceYWMk1rgda bLYw9Yjpgnhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="436492329" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 27 May 2021 02:51:22 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 27 May 2021 02:51:21 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 27 May 2021 17:51:19 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Thu, 27 May 2021 17:51:19 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wang, Haiyue" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Wu, Jingjing" Thread-Topic: [PATCH v1] net/iavf: fix RSS key access out of index Thread-Index: AQHXTIfJf853O5OpBkSGw8oGEaQwgKrrDmcAgAwUFXA= Date: Thu, 27 May 2021 09:51:19 +0000 Message-ID: <96aeedf988c048909038651a1f2d0380@intel.com> References: <20210519075933.11807-1-haiyue.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: fix RSS key access out of index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, May 20, 2021 9:24 AM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; stable@dpdk.org; Wu, Jingjing > > Subject: RE: [PATCH v1] net/iavf: fix RSS key access out of index >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Haiyue > > Sent: Wednesday, May 19, 2021 4:00 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Wang, Haiyue > > ; stable@dpdk.org; Wu, Jingjing > > ; Xing, Beilei > > Subject: [PATCH v1] net/iavf: fix RSS key access out of index > > > > The array rss_key has size 'vf->vf_res->rss_key_size', the array index > > should be less than that. > > > > Cc: stable@dpdk.org > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > > > Signed-off-by: Haiyue Wang > > --- > > drivers/net/iavf/iavf_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index d688c31cfb..cb38fe81e1 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -366,7 +366,7 @@ iavf_init_rss(struct iavf_adapter *adapter) > > /* configure RSS key */ > > if (!rss_conf->rss_key) { > > /* Calculate the default hash key */ > > - for (i =3D 0; i <=3D vf->vf_res->rss_key_size; i++) > > + for (i =3D 0; i < vf->vf_res->rss_key_size; i++) > > vf->rss_key[i] =3D (uint8_t)rte_rand(); > > } else > > rte_memcpy(vf->rss_key, rss_conf->rss_key, > > -- > > 2.31.1 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi