From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5804A0C4B; Thu, 14 Oct 2021 17:51:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 604E6411FE; Thu, 14 Oct 2021 17:51:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1FB724112E for ; Thu, 14 Oct 2021 17:51:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="291191852" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="291191852" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 08:51:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="525103895" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 14 Oct 2021 08:51:16 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 08:51:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 08:51:15 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 05:39:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJLC7TFH+Yr/cYSCey0e+eoj1HKok4/h5Gl7FbW4b0au2cYrFkNPtQ70hlfanvRyX8Tj97fEPIfbHjTCEMpQt7b3pQsAJMb1StyxW1qsT8Le0Gtx6aq5HfE1GbtKBJ9YaSDGsPQ8ak77j2lUR1ySnw9EoWbcZgev0H7Mgkox7Tsr1B88+b9+R/2Ue3cy+Cvbju3qYeD4Slcsy4HxRUSbnf77S2Ttibgtuy/U3n22Pt85qQN3DYxPuDKO86CziWegDia/CH8Sr1BXEyV48rYeulxmWqbTmAZo+oJboBwXwTV/ylfz2y7IqeDRQgHBU/BydlIef83YZrav0Ux3uUdguA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1opZwrL2VCwp/rdNRUjKdAuf1V1C5ggvGN7LnhoXDE=; b=K/HH8hhbDcZhw8sgwanNa/ydZTj3g7x3Yj7qrYhTDa9xswAWrUPVlsP/nM6e5/A/LEFDQ9T6BU+13dPCyoXo8nDPP0miDM9pT37VVmJToILgxfRzsLn0TuCVmEjfYsfSCCUJqaYI96JCWswVfklXcKpnsgswq4NiDd4gaHkVAVFIplNin/nS/cXCvz103zsTDsCnGHej5Ve2YsVUaUUo9A1rFhx6RXl7rGGVnn0Xe5sLFPgAbUFH3L95Yt6tu/NIdEaQhzh8YA3yzCnggNxZ44KcVFz+vZN/BM7CeodjvT0Fvr9ulk2a/+a/e4cCY7Y+pA8DkYYC3mVPGUmvQvhxzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1opZwrL2VCwp/rdNRUjKdAuf1V1C5ggvGN7LnhoXDE=; b=sxDZs6rlrny5GpRy8XxPE6IaKr6GpH/nGqpcLeG5kpJ7XQ7YmldCgJsQLexHMIBtMF99+WARrxRYq9C8TBQizNGNCZ5fCOsbO5GRId3RhtX32V892CCty19a0mBrahu5Ue3DX5uvGP3yBVUtTsWyFUNSgW1Ry3va+J2zdy1Q3OU= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Thu, 14 Oct 2021 12:37:17 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.017; Thu, 14 Oct 2021 12:37:17 +0000 Message-ID: <96d94d78-16b4-4cc4-587a-49fa33f1f766@intel.com> Date: Thu, 14 Oct 2021 13:37:11 +0100 Content-Language: en-US To: Viacheslav Ovsiienko , CC: , , , , , References: <20210910141609.8410-1-viacheslavo@nvidia.com> <20211013184516.25338-1-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211013184516.25338-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR06CA0013.eurprd06.prod.outlook.com (2603:10a6:10:1db::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR06CA0013.eurprd06.prod.outlook.com (2603:10a6:10:1db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 12:37:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c661e430-514f-4406-751f-08d98f0f5ba8 X-MS-TrafficTypeDiagnostic: PH0PR11MB5030: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3/+Bxy9mcWvHoa6dmRedgzkR0mUAM1FSS2K5s/EvCtTBszlbF9hCuE6Nk6gbPp9VssnsaqxjFHdLNgXDEb5LEzqCPsSh0S7HTYdXzuLZdfMh8cYbLco7sP6T9JPN3GVst0QTpROR6j0iRpiUAeokBRbcXduAXIJxbe8V50mZI2LzVDlUESSUlvMY+0L9vCCdonF++rEbVZYoLchxew8MRLSvS6tmZ+6JoyxkZfrRUIgSMn3k7VamL+egOZT+37iwdFVcrYBaq2xIVha+ZRXD2tVUvhzMlsAl/pBeeMwLUnc3B2oWCW90t/b1pKF60YsHL0DaUOWv4TlJffOkBy1W8svntEVBxPIMDpEbp60UFj3hm093aWnXK2I9llIyRx5YV17LcU77Ljr7rek4d4i40LuldxAQKVjtyP2TnHTIMxWfwn/XJD6sr0RRnHJibVY57GDkZ0gJHdvTrT9MxVNvyK9uVNTBDhxqpBDM7I0hWhHtFHaEa5QkEW0Ta2G6Nr/9S+X+2tX7f3vL5niSeG8iKhRxZLfJBsfTXiZBXUq5cu6R4evqX9Vui9Ms6bbefxl1oygVez4PMq7+2dJMwIvU2CeRGirYMDricNKtDhBgwHTH6Z/hkgv2Z0JGTMJ9PK5nbHL/q/8zkcJ5UNRZVXcK3n093P6sGWCg4NpE81N1SZ0eLzuMTevjrZm1lhAfH4aamq2RXxlsiZUu4VD9lq4m4pxZZTQ6n3FouMkBdPXqfPMROhbQvYwnGUILc1D9swNKxyUWbv/LYJsX8/X71pyB7T91BpxqypnCo7hGCgZOqhMv4YkO/LbwAHcukWPAQid5WdGmYFYEU9Omqhg20Ry0Yw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(66946007)(36756003)(16576012)(66476007)(5660300002)(2616005)(6486002)(83380400001)(26005)(8936002)(8676002)(53546011)(86362001)(15650500001)(31696002)(966005)(31686004)(2906002)(38100700002)(44832011)(6666004)(316002)(956004)(508600001)(82960400001)(66556008)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWZXQnJlMGJEU2YzMFNuODRmRXJJVW41L21wUm1TUmFtMkNjMmhRUkx3Tkwx?= =?utf-8?B?WUVYUi9NUWlIYTgzU0tPUEE3SGRqNkp2TWsreDhhV1p1ZzBleDFVcVJTT3JW?= =?utf-8?B?NjdXMmkvZ3RrNHB1REN0UEs2OGhraE1FM0xaS2QwZ2pseGNhT3RDT2J6R0Jt?= =?utf-8?B?OFVxUGlwNncwWWI2ZWxUTWJVcUZBQ0NTM3l4NFU1ZDEzZThFRzV1dWp1R0ww?= =?utf-8?B?YzVzcERFSGR5WmtCR1F5cERkUWNWRGYvMFEvOUtLdDBYUDZ2S0E1UDZKeE54?= =?utf-8?B?bTU2YUU0QnFJdVZzWFIybklCZ056Y1BDbWdtTE9ERmpHQWhwU3VHSmhvNGtT?= =?utf-8?B?TktKYlBCd25MUlNwUGhXdnlOeHlmZ1BCcUNaQjJkSHZkYjJjNTRxOStleG52?= =?utf-8?B?Q0FDeERyb1ZDMGx0akgyWFlnUENOblEySUlrRHBqVnhIbkNSclhqOVVndk9k?= =?utf-8?B?UFdrYThvakRtWURvUGJQVUcrQkJxMUdvUmFybXo2NUovT1FMTGRIWWxrcjl2?= =?utf-8?B?UGI1SmF2Z0xmRklIeHdjQllTOUZRenlXUmx3ZlNkU1pkTXVPSlhEWE9nNG0w?= =?utf-8?B?MlkraVFjZ2RST3d6T0FUWEczTTdmTVRHSE1FVnRTTWFGd3BjRkk3dVlEY0tv?= =?utf-8?B?aDE1SDFYNHVtaVJVR3dyRkIxelYvRlM4MzBNRkpuWmszeXlqc01Vd01nbkcy?= =?utf-8?B?SHhFWXZtMTdUUkZaT3Bsa1hxUndBanpTSHJ0OVRwZEdjcVR0RWQwOHJQQU9G?= =?utf-8?B?ZEFidVB2VGFySlNRaEhDWm8xTGNDSjlsUkhwSnlyNmxGV2Ira3NzNjBWeGhC?= =?utf-8?B?MElHK09RK1cwaW5PWXh1akdZcjEwYWsybDZiYkthMlVEWnVSYWpnM2FNVWoz?= =?utf-8?B?c25iKzRJcDZjbVE2SC9FajljbFpJMEswVVRNaDdTbnlHYU5wVGlkWU84ZjBs?= =?utf-8?B?YjJqN1NZWVk0VldSYlg0bm51WHRsbWdBQ2FyZ2NFOElGeEV3Q29pT0NxYkZM?= =?utf-8?B?a0IzeTZsSEZXMDdEV0liMnZVNlVGY2RQSUx3UUVORjg1ZDl4eEZ0RW5ScFdX?= =?utf-8?B?L0thd2tDa1JtcHVRNmdwTXgwcVJhckNwN1ZWd3QzNGd4VGt2UkNCS1BCZHZN?= =?utf-8?B?OXh1OGVKVUdFUWJBN2pYdGtlWG5uVmcycGQ1YjM4Smx5S1diblh5UnlRY3Ex?= =?utf-8?B?SGU4cUoxcDg0Mk9rZjJsVjBMVFBvV1FzMkFRMmdXV000UDdNZHp1MXZIRzd6?= =?utf-8?B?bDhJUG9MbG85T3dBMXRzTEJXazNBYW92WmNabHZWMUNHWlNXeHdVLzc1N0lw?= =?utf-8?B?WFBxS0wvRnFDVEVVdEUyQkREcW4rWlp6OTBMMjZzS3U5Z282YVF3WE1QWDF6?= =?utf-8?B?TFJ0RTZIZ3JmMTNwZGw5MGxqbnhnUmhjelJUNEtpaGpUWDE2ZFFIdWEvaWVL?= =?utf-8?B?eDRic0VTbk8reXdmdXVVS2c4UzQ3SFJ5dW9BV0Erakt3UXRKNThJdVJEMGxm?= =?utf-8?B?ODdIbFVwSkx0ck9RYWFuTHJPMFMwdnVPTGY2WEpWU3JCYzhHcGJyMituS25m?= =?utf-8?B?RkVvcC9FYkNRQ2QxRjF1QnMrNVM0WFJhZDFmYWNIS0NCODZkemZKY3RickJh?= =?utf-8?B?bVdNZXU4ZktHQzA4N212WlBrSEZzQnptNjJWL2dHdzQwU3lKa1B1R0hITktw?= =?utf-8?B?UmFCQ3VVVFN0d0F4RUFaT0RjdXhKWG9uNGRaUkhldVVhYUVhbTEwTFJ6Sy9G?= =?utf-8?Q?NfVnOEfWT9ScdWZER5P6nc0wyljNzMklyaDzWkZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: c661e430-514f-4406-751f-08d98f0f5ba8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 12:37:17.7541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6AJnGBaIG7YHg5Ks5jI7uD5JnEB7Xe4wGU8EU8EeTr+WYeWOIyHQ1ZwXSzmxMBq3n5dcBgU4wiyPqTRtbVY4cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5030 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 7:45 PM, Viacheslav Ovsiienko wrote: > The generic modify field flow action introduced in [1] has > some issues related to the immediate source operand: > > - immediate source can be presented either as an unsigned > 64-bit integer or pointer to data pattern in memory. > There was no explicit pointer field defined in the union > > - the byte ordering for 64-bit integer was not specified. > Many fields have lesser lengths and byte ordering > is crucial. > > - how the bit offset is applied to the immediate source > field was not defined and documented > > - 64-bit integer size is not enough to provide MAC and > IPv6 addresses > > In order to cover the issues and exclude any ambiguities > the following is done: > > - introduce the explicit pointer field > in rte_flow_action_modify_data structure > > - replace the 64-bit unsigned integer with 16-byte array > > - update the modify field flow action documentation > > Appropriate commit message has been removed. > > [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") > [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ > [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ > [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ > [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ > [6] v3 - http://patches.dpdk.org/project/dpdk/cover/20211012080631.28504-1-viacheslavo@nvidia.com/ > [7] v4 - http://patches.dpdk.org/project/dpdk/cover/20211012104919.13145-1-viacheslavo@nvidia.com/ > [8] v5 - http://patches.dpdk.org/project/dpdk/patch/20211012202557.30295-2-viacheslavo@nvidia.com/ > > v2: - comments addressed > - documentation updated > - typos fixed > - mlx5 PMD updated > > v3: - comments addressed > - documentation updated > - typos fixed > > v4: - removed errorneously added Ack by Ori K. for mlx5 patch > - mlx5 patch updated - bug fixes and cleanup > > v5: - fix compilation issue with unused variable in mlx5 > > v6: - fix compilation issue with unused variable in mlx5 > > Viacheslav Ovsiienko (5): > ethdev: update modify field flow action > ethdev: fix missed experimental tag for modify field action > app/testpmd: update modify field flow action support > app/testpmd: fix hex string parser in flow commands > net/mlx5: update modify field action > Series applied to dpdk-next-net/main, thanks.