From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 3DBC111C5 for ; Wed, 4 Mar 2015 16:15:55 +0100 (CET) Received: by wibbs8 with SMTP id bs8so3811wib.0 for ; Wed, 04 Mar 2015 07:15:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=n66FL8Ugx4wkGZroRqoxceBTbkXa5AmP1zwzbRkqTGI=; b=Lp3+5SQT1JEfYs6DAT73UVxYVQ1WfH12eF0KjEVDFCZ1PKc548Wk0EtGbhWdGoSHhJ OY2kzQwL7PrJl42C9aWBKDtr7FoP+yK3Oi+DmycSAWVw+Hw90UbEUv2iT3NMCf8SrXCH 6Tguu1o/T9e61Wf0yFijvX5hKTVv5/s4lECanbRoPa63hCmflyZH1lnMCHChdcGhOE/9 DAKYA/54mtUjfbndyI/F51LhEb05iGOZpC/mxT2uOy0pGXrYLNOe2FZKgMF0Fbtrhq/g fCQlUTqmSmh3HW+5th+sc5cYEoEwMst3aSCDoVYYqYAis20flW2Qb128ZI51ZESCbr5h aqJg== X-Gm-Message-State: ALoCoQkMNlaNvX0Q+nONfJ66wfXK77El0irtbLbpuaTRq1ZYUt83FLstkXBmmZGsZCWfKRsbptJc X-Received: by 10.181.8.225 with SMTP id dn1mr58146698wid.55.1425482153990; Wed, 04 Mar 2015 07:15:53 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q20sm3801114wiw.7.2015.03.04.07.15.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 07:15:52 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Wed, 04 Mar 2015 16:15:18 +0100 Message-ID: <9723665.VmRFLHRQpO@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150304143940.GA6187@neilslaptop.think-freely.org> References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <3858426.kLEMBMBQqi@xps13> <20150304143940.GA6187@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 15:15:55 -0000 2015-03-04 09:39, Neil Horman: > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote: > > Hi Neil, > > > > I remove parts that I agree and reply to those which deserve more discussion. > > > > 2015-03-04 06:49, Neil Horman: > > > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote: > > > > 2015-02-02 13:18, Neil Horman: > > > > > +# Validate that we have all the arguments we need > > > > > +if [ ! -d ./.git ] > > > > > +then > > > > > + log "WARN" "You must be in the root of the dpdk git tree" > > > > > + log "WARN" "You are in $PWD" > > > > > + cleanup_and_exit 1 > > > > > +fi > > > > > > > > Why not cd $(dirname $0)/.. instead of returning an error? > > > > > > Why would that help in finding the base of the git tree. Theres no guarantee > > > that you are in a subdirectory of a git tree. I suppose we can try it > > > recursively until we hit /, but it seems just as easy and clear to tell the user > > > whats needed. > > > > No I'm saying that you could avoid this check by going into the right > > directory from the beginning. > > We know that the root dir is $(dirname $0)/.. because this script is in > > scripts/ directory. > > > That only helps if you start from the right directory. If you run this command > from some other location, your solution just breaks. Why it would break? $(dirname $0) is always reachable because you launched $0. The only exception is for the case the PATH variable is used to find the DPDK scripts/ directory (should not happen). > > > > > +# Make sure we configure SHARED libraries > > > > > +# Also turn off IGB and KNI as those require kernel headers to build > > > > > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > > > > > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > > > > > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET > > > > > > > > Why not tuning configuration after make config in .config file? > > > > > > > Because this way we save a reconfig (from a developer viewpoint), you should run > > > make config again after changing configs, and so this way you save doing that. > > > > No, you run make config once and update .config file. That's the recommended > > way to configure DPDK. > > defconfig files are default configurations and should stay read-only. > > They get overwritten when we do the git resets. Its silly to modify your config > file after you run make config, in the event the make target has to re-read any > modified options and adjust dependent config files accordingly. I understand > that doesn't happen now, but its common practice for every open source project > in existance. I'm not sure to understand. Maybe an example would help. By the way, your method works.