From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FB60A0487 for ; Sat, 6 Jul 2019 10:41:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCF462F42; Sat, 6 Jul 2019 10:41:35 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1D22D2C60; Sat, 6 Jul 2019 10:41:34 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id A9D01280069; Sat, 6 Jul 2019 08:41:32 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.81) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 6 Jul 2019 09:41:26 +0100 To: "Iremonger, Bernard" , "Nicolau, Radu" , Akhil Goyal CC: "dev@dpdk.org" , Dilshod Urazov , "stable@dpdk.org" References: <1562329089-4354-1-git-send-email-arybchenko@solarflare.com> <8CEF83825BEC744B83065625E567D7C260DCA66F@IRSMSX108.ger.corp.intel.com> From: Andrew Rybchenko Message-ID: <972bcbf5-2dc1-39ba-2a27-9684dc065b27@solarflare.com> Date: Sat, 6 Jul 2019 11:41:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DCA66F@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.81] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24742.003 X-TM-AS-Result: No-11.869100-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OHmLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jRigV5T7Tqqly0V 8XqCfHoEl8V6ZKEJA0+TH1CW/Tkdqjfa6I248QZMGi6hW8XaLRk1X1Ls767cpljBUeMsjed6QBz oPKhLashk1QMds9nkrXk5w+l3wsE1yGOiXr1rOL74KPASpfWnuQHgke2JqaQsEJ1+mMAooFxIVI Dp1pd6gIuBwqiWOKVGEAa86knd6j5JI5ZUl647UDl/1fD/GopdWQy9YC5qGvz6APa9i04WGCq2r l3dzGQ1c4YZVWIe0Cby3lNWhqcvoPOEK365y7RNdj7i7ku6cijRGRBCQPJPnw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.869100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24742.003 X-MDID: 1562402493-VULsgaFofljd Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05.07.2019 16:46, Iremonger, Bernard wrote: > Hi Andrew, Dilshod > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Friday, July 5, 2019 1:18 PM >> To: Nicolau, Radu ; Akhil Goyal >> >> Cc: dev@dpdk.org; Dilshod Urazov ; >> stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive >> rte_errno >> >> From: Dilshod Urazov >> >> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dilshod Urazov >> Signed-off-by: Andrew Rybchenko >> --- >> examples/ipsec-secgw/sa.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index >> 8d47d1def..8044066a8 100644 >> --- a/examples/ipsec-secgw/sa.c >> +++ b/examples/ipsec-secgw/sa.c >> @@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id) >> RTE_MEMZONE_1GB | >> RTE_MEMZONE_SIZE_HINT_ONLY); >> if (mz == NULL) { >> printf("Failed to allocate SA DB memory\n"); >> - rte_errno = -ENOMEM; >> + rte_errno = ENOMEM; >> return NULL; >> } >> >> -- >> 2.17.1 > ./devtools/check-git-log.sh -1 > Wrong headline format: > examples/ipsec-secgw: fix to set positive rte_errno > > Otherwise > Acked-by: Bernard Iremonger It does not like underscore in headline. I think in this case it is better to keep it as is instead of trying to describe rte_errno is a different way. Thanks.