From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nirmoy Das <ndas@suse.de>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3
Date: Fri, 6 Oct 2017 22:42:03 +0100 [thread overview]
Message-ID: <9730e482-04b0-a945-a10f-013cce777dae@intel.com> (raw)
In-Reply-To: <6ed1338c-e9b3-6765-b31b-7f1156f31dbd@suse.de>
On 9/5/2017 10:55 AM, Nirmoy Das wrote:
>
>
> On 09/04/2017 11:46 AM, Ferruh Yigit wrote:
>> On 8/29/2017 4:06 PM, Nirmoy Das wrote:
>>> compilation error:
>>> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error:
>>> ‘struct net_device’ has no member named ‘trans_start’
>>> dev->trans_start = jiffies;
>>>
>>> Signed-off-by: Nirmoy Das <ndas@suse.de>
<...>
>>> @@ -55,7 +83,9 @@
>>>
>>> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0) || \
>>> (defined(RHEL_RELEASE_CODE) && \
>>> - RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))
>>> + RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) || \
>>> + (defined(SLE_VERSION_CODE) && \
>> defined check is not required, since SLE_VERSION_CODE always defined [1].
>>
>> It can be either:
>> a) (SLE_VERSION_CODE && SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
>> or directly check:
>> b) (SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
> Thanks for your comments I will modify the patch.
Hi Nirmoy,
Reminder of this patch, would be able to send a new version?
Thanks,
ferruh
>>
>>> + SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
>>> #define HAVE_TRANS_START_HELPER
>>> #endif
>>>
>>>
> Regards,
> Nirmoy
>
>
next prev parent reply other threads:[~2017-10-06 21:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:06 Nirmoy Das
2017-08-29 15:12 ` Stephen Hemminger
2017-09-04 9:47 ` Ferruh Yigit
2017-09-04 9:46 ` Ferruh Yigit
2017-09-05 9:55 ` Nirmoy Das
2017-10-06 21:42 ` Ferruh Yigit [this message]
2017-10-09 22:04 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2017-10-13 22:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9730e482-04b0-a945-a10f-013cce777dae@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).