From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0066.outbound.protection.outlook.com [104.47.42.66]) by dpdk.org (Postfix) with ESMTP id 0CBD65F2A for ; Tue, 3 Jul 2018 15:15:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMiLLqAQglJ0mtYGpUdrbaeAQ1H6hSSvYjx9LFOzGoY=; b=J4Z06C6tTcdEC0mzOqrLBIyxcw3Ijl5O9bT0tVLTgYnuZ0GRbKQfR2ZxwxKZE1wmrKGnOsWEWKtjZSK/qKrcQv8gy0QxVxxSjNzaDOe5ezALC00SZApfo57lq8q2sJqkKSX2I6w/GhLCVAXueiicJqlTdbN3cUTpIf6xs344TrU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Tue, 3 Jul 2018 13:12:45 +0000 To: Sunil Kumar Kori , Bruce Richardson , Jerin Jacob , Pablo de Lara Cc: Hemant Agrawal , Narayana Prasad , Nikhil Rao , Pavan Nikhilesh , "dev@dpdk.org" References: <1528478659-15859-1-git-send-email-anoob.joseph@caviumnetworks.com> <1528478659-15859-2-git-send-email-anoob.joseph@caviumnetworks.com> <12a1fc10-6879-4e1a-bcb4-ec66a9494346@caviumnetworks.com> From: "Joseph, Anoob" Message-ID: <973d9ea5-924a-cbc9-8aba-42c35e672c87@caviumnetworks.com> Date: Tue, 3 Jul 2018 18:43:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::33) To DM6PR07MB4905.namprd07.prod.outlook.com (2603:10b6:5:a3::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 784f763c-acc3-4ae8-ecc6-08d5e0e6acb9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB4905; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 3:kR2ApzB6MisT61ByXvmMff7zrOgqSTYlnbWdpkCGrDXzAGkMHaKs9dpjsbKunPXfOMIi59+HUiYGOwCBpRNb61+W71aTOBr69gkxpNhIg/3x4cQCTgkRfmri2k0AB37b+NhYe+qvZ7q/ekpFlal+CiQ9IDOqZYwirm+f3I/7+r9VYJMl/T2Xj3t+CIo94Muuk2XdTxP5L46jS8rlqafLSnVWzX2fklwFDrOwY5EsQQ1aq9Qaz+R4B2AC5c8EM/A4; 25:4WNOSJvqWpFpklIJR9ikTxcWNznQWt9DN2Rsp3pD1nvhrTe4aGg4TkICL1k7cQMBLY2vHgffLrcrp9OBgkMgcrlBJNuL7e+nfZkhSP0yZbeAgLA7KO4HInFfi7f7YtFfgowoLvUriYbjUMSg3tgx/kT74/gbWxWitKrpvDvdNDfrW53jOw5ZkKykXh47nUUF22MkAnJ+PvuIZWuCSxFzoelBSIsNiaddaHTJlc5E5Hvnf3BW6nN+MNpBQ+70tnQ7FfYVMIY2FeBEPV2HTovAPbc8MJVYpD6oz/RXWy+1T822NZ25+bVycJkzlmXwDSiR43HeeI7X08g6tcz6RR1Blg==; 31:o7CeDYExx+RRHx/CRHgXRzEv7ZIMU5+t9ER8yj7bNJt6ZQ6Hjv+kqahTHsINa3nF7zWGsFQjfNB2aflJMY2vukUd+pV8qWiFbVzJ02FdHpC+YPfE0OehJX7EbcClw9tvqoK/W7GGo/GMpqW8tZVqKES8dOpgQgjE3qP1cy8xylEgesPdzCLkazRTmDa13NH6rcgzaVUHtThuPFTAhzij7LKhGbxTgnOxMlyYtd8b0TI= X-MS-TrafficTypeDiagnostic: DM6PR07MB4905: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 20:9uu6MT13+rnsWIQPDA2+uiDMjsN7biKZfCS/ES3eYqtJzGUkc/tDsbaFK7uXEvPJcsA4RdQbwiTh809iqZb1t9RSlkfUBu+joTe5KoMfB/LkdW0AXJ9OzxJ9Gwp6l+j+6Qcn/ucsub4VQ871m/qoVj1LSBVesy6LocX6qIog7M7xuoA4TUpxkPHoG/d7t/AtWCoHxO5U9kioWjREXr/v11aeJDlCirm8Ukjb8SxJl2HK9qYLxVe/nCh4iWe3/wivCx6AHEsq5Or21xSK5Z8/CtOQv0JZO1ERJDSzVE/+IWRMU8s78W9liW/hJLJTf5ctn9AdAktN++zAaY0qxMiqyvk1m892o+YpQXKe7cJDVxktfj6/RksQtxfr+ONt4Ko5jJsviONBNsUBmS3W9KhkBWuawm0t4jk5w7VoBBo8vhpp+39zVXnKr0W/tC5XguTTmznAYCwgFghCFtbfixPy80Flt93xrztN9A+D251XUwjXf+i/CZpyRJil/kL2sKpSvtsNzHUo6+uCVakT8NXrOA/nzIpPOGCmP+l5/A7rMRr+70iHbd8pN+ily2wbEmei5kZtfxAJ1u246iZPEGUTwFJHGtyLvY4cesOpw9saoVE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3002001)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DM6PR07MB4905; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4905; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 4:LZDA4SYzroN1c246PBLBwcGayN0AOaRpWfJmlJz+WO0fsvNWZsBLF3lDpNGvAU7eXkLQJsY41TJrxjLboKqEfPX7S/vcH/ROKGQ//j7PFvNfR2W5D/Mt+JASw9TslZSppmPPFWTJxI7XmGKDLUdq19aqewWYnVcVIAvUTZBjJ2QZpc2VQMPfvIwAPq1JbPfi7Qu4h54C0k302y/93hSkuV8ZXhRTMmgUudOzPOlvYtExQRgOAJAMtK0BcozHXLeXU0ulJCvtYpJgmfnlUI9aQWgoAWxuTYhjnhkNxqHGb5sgG2fBpHoHlVDaoO34JNB3fgVZMICp65GraSxmYSBdPfO2m/BgmyJT56whVSIkhnswgI7anKjlDDKNzsbfNZm2 X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(39860400002)(376002)(136003)(366004)(396003)(13464003)(52164004)(189003)(199004)(97736004)(68736007)(478600001)(72206003)(36756003)(8936002)(81166006)(81156014)(42882007)(8676002)(486006)(25786009)(2616005)(956004)(476003)(67846002)(3260700006)(7736002)(16526019)(186003)(50466002)(11346002)(6666003)(305945005)(26005)(230700001)(77096007)(55236004)(6116002)(3846002)(4326008)(446003)(65806001)(65956001)(2906002)(6246003)(66066001)(105586002)(31696002)(106356001)(53936002)(58126008)(47776003)(93886005)(64126003)(386003)(76176011)(53546011)(31686004)(52116002)(65826007)(2486003)(23676004)(229853002)(52146003)(316002)(16576012)(6486002)(5660300001)(110136005)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4905; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTZQUjA3TUI0OTA1OzIzOnRqL0x2QXpLcnQrYmdsT0NGQkR1YmFIMWRQ?= =?utf-8?B?bGh6dXhQaHA3OXI5UUl5blZGOThONmhhbVd0K0t2Y0M5SWFNU0pmY1lPNDV2?= =?utf-8?B?OGtQR2ZoOWxNQ0EvRFRYbU5kdmV0aXpBRUVRUE12OG9tQm9pL1pEeElwWTRn?= =?utf-8?B?aFoxUDNZVEt0d0JZNjROdDNCWmtlNDdSd2dzTkM5endBeUQxL1BWMnd4NFRG?= =?utf-8?B?MklGVktzeFluWnZDV29QZmJZc3FXdXVZY0xkSEd6L3c2MHJCZW9rZGZvdDV2?= =?utf-8?B?eVhERTlScmJvMElQVXJHWjF2dlkzTjhLSjdmYkt2TWlWMzJwZzV5QnVGY1E3?= =?utf-8?B?NVpPL3hIbHZkd094MmVrTHpqendqUWNIcmg2L25ka1VCdElKMTU2dmFjWVRE?= =?utf-8?B?NzRJR1E5NnpZMmxuTXI5MGdmcnBSYXpLRUJqZ0dWSlJveVpDWjVMSmRGT1VC?= =?utf-8?B?WTNSK1AvbmI3WlpFSTAvWUcxclNrNVZoSitLNHUvRm0rZXg5MkxCbUJmSUtu?= =?utf-8?B?Zm15amJacXFhaVVybGRLb1RESzY4ZDRxb2t2akdVdTB6YThadXA4N1orRG9F?= =?utf-8?B?Y1FpVmRPZWhWSDFqNzRXNHEza0FPdFErMUsxMVNrUWdlNkVVNyszMzR6MEl5?= =?utf-8?B?L0Znd04vQUVIT3hrRld3WGZ4aXhPZWhndjgyRFZkRnhIc0lSTmNiTEx1YVZi?= =?utf-8?B?VjhBQ0xkTFRRcllrOFBsaGRjaUo2Uzc1cDBZQ0loK25jd3lFYUNqZlp5ZlhD?= =?utf-8?B?SzNDVFRPNXVENTVUeU4rYXVQZFllZ1VNVzNUcTc3Vnc4OHlSeWFYb0pONzZk?= =?utf-8?B?M2dPWFBuN1NvV3FmY25tbHdZc05LdlNhc3d1YmxjOHRtc3BHZEtjSVlFSEtD?= =?utf-8?B?UDRLZFkwSFFvdDdWcnRQNTltT1g0amxod0VLNHY4VDNlRFVpcDFFWXE5WUdv?= =?utf-8?B?WGdLOFZzaldYLzJtUUNONnc2ZjVjcVI1Um9uNVVHSEdpWUlGc0k3WjVtckFq?= =?utf-8?B?T1FLemlXMUdiRkxTQ3VBejRENWRWL2pRYkJPMkZhK0FxVFFod2xnOC9taGVr?= =?utf-8?B?KzdSRGdoZmxQVHQ2bUg2dnlCVklScTZUak45NmlZallTVEZETFN1dG9HNDJr?= =?utf-8?B?bkVXejF2dTlpMFV1NEYwZnRXMDlRQ3ltelNUVkNXcWtFQmE4UU0va0o2Q2wr?= =?utf-8?B?S3EvUjArOWg5SUxZelFLODV2dE50NWdNTEE4Ujh4ejNLVkV3KzFtSDUvSWNs?= =?utf-8?B?WjBDeEdzaGhES1pURCtnYkg5S0t5aTdHTDluQk51eEdJQ0dNV01HVGlQWFFN?= =?utf-8?B?WVFqVHNNZnNDRmZuZFhIQ3FUVUxuYWphV0wyWUQ0dGV0RVkrY1lSOWFqRVd2?= =?utf-8?B?RFZYTTYwbzBmajJQOGtJYWthamorSTlrYmoyRldQNGwzSnk3cEM5TER1VUpL?= =?utf-8?B?aWVJRUJnOFRrUlc0Yzh3Y1V5MTZ6dFpGNmk0SWNISGl6dEg0NU1UT3RsRkxh?= =?utf-8?B?ZFNSNmlhRk5kcmo4SUtEV2dsVk8xYnhyMExGcTA1d2huc3BuQ1oxNkFUM0ZY?= =?utf-8?B?ODE0a1J6OEtXRFI4N3puMVR3ZnFmWXg2d1NoWDhLMDdKTlM3eW0rV0xOc0tm?= =?utf-8?B?VGEvU0NFQlZwWmkxeUdJZ2Y4WXNwS1ZEV0pCR1ZvL3J4aWxUUGZQbFBYSnNV?= =?utf-8?B?L0FVUUZXcnU3T00zaDVpc1piZnArTFFMWlk0SmFoMWRZSGlWZW8vOGJQNWNj?= =?utf-8?B?V3Z0WHpINkxpUzZEYzVPcyt2eDFHeDJDYks0ZjMzSVRFQ0lFZXVqMVJoTnE5?= =?utf-8?B?S0hBMkE0QTRySmRKRkhza2Nkem1FMTFTb2NBdWw2OWQ2NHVMd08rMDJHenh6?= =?utf-8?B?WFRWMkJlUXk1cmQwNnRjSTJDdDZLSlVSRXByOU5vY3N4eEd2VFN3UG5DNkFl?= =?utf-8?B?bG81V0RJcDA0RytFZm9Sa1krcUhJaTdGRXlDbkVWRzF6MHZBWTFiM3pCNlF4?= =?utf-8?B?cGFuamUxUnZTMW50Ykk0OGFZb2lrWHhkRlQvMjQ5L0p4b0k2ZWE4aHllVVRr?= =?utf-8?B?QmZiNG16YjFjSXRhOUhSWG9SNHpjR3JBTkhYWDdvL2VjL1p1VitwUWF6SnZo?= =?utf-8?Q?dFhDJ3Z6cknFvTYo6U93thw=3D?= X-Microsoft-Antispam-Message-Info: bw5gqrQjWStw6r1KIYNMw1hwvgWQWTV2+9BfH9Yj6qlK7UpKkzKcMaoaizGPKKNiHfse8M2ysbTK7iAnYjiN8PCcK0fSHqdgfNmPFOsael4LLE9N5M5JTTICrDNvcO7jcASIhxOk1mpnMt8hbxbC8NMQLhInwyorlBsoYejU4qwAmyw+6UDy1EKFZduOkbnvQxCCHAT30LXA1+d/8P7I6G1tiThJVwhdJtcyl+5KaIJwBFrA2Q67znxICB1dk9meq52xKuToZ+SYOCLVg+VsnSfR6h2h49MI19kxSkLUQDRWlpfiDFWqwegQfsEeR5sfmD1inXLunlMzrj5DD+/qACBrSqbvEtlJr8uweet5yG0= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 6:8VgtH+DyyxTH5S2xf6DiSjAzXG9JPcKla8aDJ1Qb/KM6iv/jPdvQ4C6Ra/Dx+BerxFBnGREdpSVP3IqJ6u+ysluV4Wds6t+pe7iE+/6N+1zGB5HLocTcYJ9WbG2pFcRc1Jn89NtybY+LTHlGF8LYfiZYlZdEOKL4a+wDNfE6GWr/MD00odMQtUgANSWBlrTg2jJ0jDyKnIjl7iWtGU2UOog7bFns7KDSv6RCK/Bf6OlzH82xjIxJEvkjRASPzhVq7Od9AKOaPkaxJP8pzbAc8LoERYH2PR86eQoqeGOSjRPzUaSA5Us6sFARpCmonvINIT63jjR78AJwTZTqSb+MSsdUR5yNdSFKySXIEs3JiWn1mjMKthlrtlyNXjO36De8KuTpkwmhDCsOtOfMQhg8++KsqHzRCKCIf6msNIP7dMUR6kvKw9da0vwYHGxx3MsJfD5NO8PAXSlGnNTwgjmqXQ==; 5:q7AqMUCQEhK8q5izzJQeLcyJySde6gTgE0R50rry8dk5sw6B0sGznhELD6WppnBN/BRRHKtjq/3Q3R48zfkiDocwwSh12JwwBYyQlC8lWiXMtbLkaaf+8eL1AU1InmrJR8MgECmZpv1o7URdxTZvGxnCkeZPWZQdvCrdz9QhagY=; 24:STJ869zTbcEt4vC2/vGvJJUYCrUq1tzFd6N1kzUHJTqyj7t6R/bAF+XAlcFWIBRU0rOxol+93KLLXvWS65mHD/+qinM75//ZxCiQF7v6oCg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4905; 7:wDXKhwRqqU5kfQ+OScksjUmHCSjlbFGjmVLUr1ZwW5WCo28ofiZ9hyoRKKAuYTh4MdMzUYEMe+PIICriKSCi06VV1bHpKfQA+ZvOC7aXCs/s/whPdb8ZuI7Sj2+eNtkkS8EXUikzKtCdIJ3cQ/tCm685QqAJkS3VBszwpwmyNCOblEa+O1TzrCWglSbue2xWgsQXEVDyylWgvcCtMyGEhGeksGu4RGfFiw6glJs7tQhLoAdhN3dVVmYWAfrhXw/c X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2018 13:12:45.7768 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 784f763c-acc3-4ae8-ecc6-08d5e0e6acb9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4905 Subject: Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 13:15:22 -0000 Hi Sunil, Please see inline. Thanks, Anoob On 03-07-2018 11:57, Sunil Kumar Kori wrote: > External Email > > Hello Anoob, > > Regards > Sunil Kumar > >> -----Original Message----- >> From: Joseph, Anoob [mailto:Anoob.Joseph@caviumnetworks.com] >> Sent: Thursday, June 28, 2018 4:13 PM >> To: Sunil Kumar Kori ; Bruce Richardson >> ; Jerin Jacob >> ; Pablo de Lara >> >> Cc: Hemant Agrawal ; Narayana Prasad >> ; Nikhil Rao >> ; Pavan Nikhilesh >> ; dev@dpdk.org >> Subject: Re: [PATCH 01/20] eventdev: add files for eventmode helper >> >> Hi Sunil, >> >> On 27-06-2018 11:50, Sunil Kumar Kori wrote: >>> External Email >>> >>> Regards >>> Sunil Kumar >>> >>>> -----Original Message----- >>>> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com] >>>> Sent: Friday, June 8, 2018 10:54 PM >>>> To: Bruce Richardson ; Jerin Jacob >>>> ; Pablo de Lara >>>> >>>> Cc: Anoob Joseph ; Hemant Agrawal >>>> ; Narayana Prasad >>>> ; Nikhil Rao >>>> ; Pavan Nikhilesh >>>> ; Sunil Kumar Kori >>>> ; dev@dpdk.org >>>> Subject: [PATCH 01/20] eventdev: add files for eventmode helper >>>> >>>> Signed-off-by: Anoob Joseph >>>> --- >>>> lib/librte_eventdev/Makefile | 2 ++ >>>> lib/librte_eventdev/rte_eventmode_helper.c | 7 +++++++ >>>> lib/librte_eventdev/rte_eventmode_helper.h | 6 ++++++ >>>> lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++++++ >>>> 4 files changed, 21 insertions(+) >>>> create mode 100644 lib/librte_eventdev/rte_eventmode_helper.c >>>> create mode 100644 lib/librte_eventdev/rte_eventmode_helper.h >>>> create mode 100644 >>>> lib/librte_eventdev/rte_eventmode_helper_internal.h >>>> >>> Having a separate helper library to configure eventdev may be a >>> overhead to the application as application needs to understand main DPDK API >> as well as helper routines. >>> It can be kept in application as a separate file. >> For one application we could add a new file, but if we are to enable event mode >> with multiple applications, wouldn't this be duplication of lot of code? >> Considering that I haven't added the required parsing routines, the code >> additions in one application to make it eventdriven would be huge. >> >> I do agree that making this as a library poses its own challenges, but do you have >> something better in mind? Another option we can think of is making all these >> changes part of some common headers and then each application can include >> and start using these functions. I'm fine with any approach, but we need to >> consider making at-least l3fwd & ipsec-secgw also event driven. >> > With this approach, following may be the challenges: > 1. Documentation will be required for user to use eventdev helper library. > 2. Helper library should cater all the generic use cases which can be catered from rte_eventdev_*** library. > If not, supported configuration/use cases should also be documented and should be future evolving with eventdev library enhancements. The formal documentation is yet to be added. I do agree that we will need a sufficiently detailed documentation for the helper. Right now, all helper routines are added with enough scope for development in the future. This patch series was to float the helper library idea and get possible suggestions for improvement. Is there any other issue with the approach, apart from the documentation?