From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5854EA0588; Thu, 16 Apr 2020 05:22:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00A981DA4F; Thu, 16 Apr 2020 05:22:26 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 95D7D1DA43 for ; Thu, 16 Apr 2020 05:22:24 +0200 (CEST) IronPort-SDR: A0ewThl0246F60YgJ0ktZMg6qMq9bZzJlHzoUCF/xc4KGVTBCmIHDt6WWMA2Z2+9c/4N5AiA57 Z6j9siNTaLig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 20:22:22 -0700 IronPort-SDR: Guu9d1NeU0zmvH00+vDSgCMQMD65b6UjtE4DkpEBnkSz2IX41QYBsi8eJH3LEmFQyqxK02zQbs H11y1tUbf6Qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,388,1580803200"; d="scan'208";a="299180151" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.153]) ([10.67.68.153]) by FMSMGA003.fm.intel.com with ESMTP; 15 Apr 2020 20:22:20 -0700 To: Ferruh Yigit , "Iremonger, Bernard" , "orika@mellanox.com" , "Ye, Xiaolong" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" References: <20200318170401.7938-5-jia.guo@intel.com> <20200415171129.86297-1-jia.guo@intel.com> <20200415171129.86297-2-jia.guo@intel.com> <683076bf-4833-16d5-f5c3-d7e7e1474b9a@intel.com> From: Jeff Guo Message-ID: <9748e316-108c-59a1-660c-12e8732cfc73@intel.com> Date: Thu, 16 Apr 2020 11:22:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <683076bf-4833-16d5-f5c3-d7e7e1474b9a@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, ferruh and bernard On 4/16/2020 6:13 AM, Ferruh Yigit wrote: > On 4/15/2020 4:38 PM, Iremonger, Bernard wrote: >> Hi Jeff, >> >> >>> -----Original Message----- >>> From: Guo, Jia >>> Sent: Wednesday, April 15, 2020 6:11 PM >>> To: Iremonger, Bernard ; >>> orika@mellanox.com; Ye, Xiaolong ; Zhang, Qi Z >>> >>> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >>> ; Su, Simei ; Guo, Jia >>> >>> Subject: [dpdk-dev v5 1/3] ethdev: add new RSS offload types >>> >>> Defines some new RSS offload types for ETH/S_VLAN/C_VLAN/L2TPV3/ >>> ESP/AH/PFCP/L2_SRC_ONLY/L2_DST_ONLY. >>> >>> Signed-off-by: Jeff Guo >>> Reviewed-by: Qi Zhang >>> --- >>> v5->v4: >>> rename ETH_RSS_ETH_XXX to ETH_RSS_L2_XXX. >>> --- >>> lib/librte_ethdev/rte_ethdev.h | 11 ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >>> index d1a593ad1..138c15a16 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -511,6 +511,13 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_GENEVE (1ULL << 20) >>> #define ETH_RSS_NVGRE (1ULL << 21) >>> #define ETH_RSS_GTPU (1ULL << 23) >>> +#define ETH_RSS_ETH (1ULL << 24) >>> +#define ETH_RSS_S_VLAN (1ULL << 25) >>> +#define ETH_RSS_C_VLAN (1ULL << 26) >>> +#define ETH_RSS_ESP (1ULL << 27) >>> +#define ETH_RSS_AH (1ULL << 28) >> I have a patch in flight to add ETH_RSS_ESP and ETH_RSS_AH. >> I have used the same values as you have used. >> http://patches.dpdk.org/patch/68550/ > Both patch sets touch similar area, both in ethdev and testpmd, and both sets > has external dependencies, so not easy to manage. > But since the changes are trivial, I hope it can be resolved while merging, if > not one may be required to be rebased, based on merge order. > btw, using same values is good idea, it helps to resolve conflict. Agree and thanks. >>> +#define ETH_RSS_L2TPV3 (1ULL << 29) >>> +#define ETH_RSS_PFCP (1ULL << 30) >>> >>> /* >>> * We use the following macros to combine with above ETH_RSS_* for @@ - >>> 524,7 +531,9 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_L3_SRC_ONLY (1ULL << 63) >>> #define ETH_RSS_L3_DST_ONLY (1ULL << 62) >>> #define ETH_RSS_L4_SRC_ONLY (1ULL << 61) >>> -#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_L2_SRC_ONLY (1ULL << 59) >>> +#define ETH_RSS_L2_DST_ONLY (1ULL << 58) >>> >>> /** >>> * For input set change of hash filter, if SRC_ONLY and DST_ONLY of >>> -- >>> 2.20.1 >> Regards, >> >> Bernard. >>