From: Kevin Traynor <ktraynor@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
Luca Boccassi <bluca@debian.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
dev@dpdk.org
Subject: Re: [PATCH 1/2] test: add graph tests
Date: Tue, 20 Jun 2023 14:06:22 +0100 [thread overview]
Message-ID: <97597f47-bbd9-a597-f1a0-50e076fbc370@redhat.com> (raw)
In-Reply-To: <CAJFAV8wCrzFz1=x1NSrJ_BkmMabJdwGp8PJv0RTT8izoTbmTBw@mail.gmail.com>
On 20/06/2023 12:52, David Marchand wrote:
> On Tue, Jun 20, 2023 at 12:32 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>
>> On 20/06/2023 07:56, David Marchand wrote:
>>> On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>>>>
>>>> On Tue, Jun 20, 2023 at 2:17 AM David Marchand
>>>> <david.marchand@redhat.com> wrote:
>>>>>
>>>>> We forgot to add graph unit tests to the CI testsuites.
>>>>>
>>>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>>>
>>>> Could we add Fixes: ?
>>>> Either way,
>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>
>>> Indeed.
>>> I don't think the graph unit tests and code changed much, so it should
>>> be ok to backport down to 20.11 and enable these ut in the CI.
>>>
>>>
>>
>> Sounds ok to me to add "Fixes:" tag and backport. If they pass, great -
>> if they don't, the graph maintainers would need to spend time updating
>> the tests etc or we could just drop the patch.
>
> Modulo some easy to fix conflict when backporting, the graph tests pass fine:
> - 20.11:
> 2023-06-20T11:30:44.7171265Z 87/96 DPDK:fast-tests / graph_autotest
> OK 0.13 s
> 2023-06-20T11:30:44.7171724Z 88/96 DPDK:fast-tests / node_list_dump
> OK 0.13 s
>
> - 21.11:
> 2023-06-20T11:32:37.2132951Z 90/101 DPDK:fast-tests / graph_autotest
> OK 0.17 s
> 2023-06-20T11:32:37.2133397Z 91/101 DPDK:fast-tests / node_list_dump
> OK 0.17 s
>
> - 22.11:
> 2023-06-20T11:50:48.2519983Z 92/106 DPDK:fast-tests / graph_autotest
> OK 0.17 s
> 2023-06-20T11:50:48.2520344Z 93/106 DPDK:fast-tests / node_list_dump
> OK 0.17 s
>
>
Thanks David. In that case lgtm.
prev parent reply other threads:[~2023-06-20 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 20:46 David Marchand
2023-06-19 20:46 ` [PATCH 2/2] lib: make graph optional David Marchand
2023-06-20 6:56 ` Jerin Jacob
2023-06-20 7:09 ` David Marchand
2023-06-20 8:10 ` Bruce Richardson
2023-06-20 8:20 ` Jerin Jacob
2023-06-22 17:33 ` Thomas Monjalon
2023-06-20 6:45 ` [PATCH 1/2] test: add graph tests David Marchand
2023-06-20 6:50 ` Jerin Jacob
2023-06-20 6:56 ` David Marchand
2023-06-20 10:32 ` Kevin Traynor
2023-06-20 11:52 ` David Marchand
2023-06-20 13:06 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97597f47-bbd9-a597-f1a0-50e076fbc370@redhat.com \
--to=ktraynor@redhat.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).