From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65BB442CFA; Mon, 19 Jun 2023 14:37:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0002140E0F; Mon, 19 Jun 2023 14:37:04 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2071.outbound.protection.outlook.com [40.107.100.71]) by mails.dpdk.org (Postfix) with ESMTP id B660C40DF8 for ; Mon, 19 Jun 2023 14:37:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FyP4k6LEu9nr2h0fQg5QPc5SN0y+/2kpzw0hX+h5rtsqjN7/tJwDN0rtih5vGjVBkzU+XEjgkd7Kl0zs/qi5uU9rXKFNHvwj5L9iuAvnnsq1QbEKoSTMoxkq8DA3h+dyziGWO7j/+bBDopRwkUyPm9ULExOgH/xeUvu1R7VDoCwv96FmFByNafvwFHS4TAQcvdqzpHNm70ziM9NMAVTeHx61G4C1qAHLDj6HaWPjW/SaFSgZeeqnvufY4zkWzYN9XnsZo2hTsBsDDpM6ATVnLFoTa/yTNwvy5amEoyUiLJCBmiLc9rDQyxVnzIoLGNhfKt261KZwqpP1yhUPEDybFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MA+bPjfbg3Z6lO8qs3sAsIgD0LSl0IAAk+l3ozHFNUM=; b=YO61pM6HVDf5eg8nLbmszWjGU/stfZ5g0i1mUs2zhU9m+7vUSV4A0tZ6Vf4PunsHYpJcPNffipVXYV2/tqzL9u/KTtnkKmDwPRb453g7qbmogKrwXB62B1xW8mvaCmBMTHZuDQ3t4e2cwH2wTC/ZwTB5P3AZFtgVY646uk3xNUP0XFMJ1Y2Ra+8PUavukDFneUurgowuhbLRfht0gUSXMQOM553gbZRYS2Cn+f/9lltJJckCRrbKtup53phV8pzZWJ1oI2NbXQqOQwOxnX9eFgTMgkHgkcqyB6lfarVKMF6+FkawAwPH9cV4tP0ZOsizgfgnwCUeYWWJs64OQN0CUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MA+bPjfbg3Z6lO8qs3sAsIgD0LSl0IAAk+l3ozHFNUM=; b=bJV7WAJ76X2btvkpdzyPSrbyXCIIlUKKdP+iowBSz7bD8+zA+0V+7NqSX7cdgqwAN3qFBtktM/eD+bz2dMTmVci7N667/M8dcp7tNrHjPgoqjrireZipkpySRDhGtLh5XCIr+4vy+9OV+KW4SFzYoIcGhP4lpMKPtU9pu9tR7dA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7933.namprd12.prod.outlook.com (2603:10b6:806:342::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Mon, 19 Jun 2023 12:37:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 12:37:00 +0000 Message-ID: <97599564-08da-c64c-b4dd-143f364fb176@amd.com> Date: Mon, 19 Jun 2023 13:36:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v2 0/3] improve FEC API usage Content-Language: en-US From: Ferruh Yigit To: Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko , "Min Hu (Connor)" , "Wei Hu (Xavier)" , Chengwen Feng , Chengchang Tang , Ajit Khaparde References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230508114707.89629-1-denis.pryazhennikov@arknetworks.am> <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com> In-Reply-To: <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0320.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7933:EE_ X-MS-Office365-Filtering-Correlation-Id: 326dfd38-a9b1-4c6b-41e3-08db70c1e0d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YvNP/ayG9cSfx70f+R1jAWPnUkdyiVVKPRRi54KLeNrofmPsF+1T85jcxANJjQ//+PFhZBBKZY1+9l6vKEC7fYG5I0jni0UYaJyyRckOII8nadbHi7n9+Tf6YpOtn5e9zsqehwD96QOt5gsjYJ+l/N15XV8Zi5znuUx3u52IKeQcS7s9y2dDkKli3n8WGR4rAMC0BV0ecgIDrZT+A/3ZP0Ufp8eNOmyV1LcX67IBYXwHyVD6m8ZrDVB8MTlSwOzV8qh7LWrz7dwXwk1UYZ4AGMTowrD80QTefyOIDn0ClMS507qlQpMUIUQOyB3P6Janr7doocK/G6ssHqB9BL+LOHoiigDnmi3Ylz2YTlzF6RAN6J9x20gxykgjAHCg9ew6J5iAd9NjHxNFzEUuSmyC7XFhAUR+YtJ+wOHcCvmLsQV22dypIXE0d2lY/p03f18gj3+6Fa+KPwP2SB51EAWD7t+HPfEldDBQQfBPbyVCsUsYseYJ/3GZWDUlGgduetByKjPRj1Nta+nRwuh2iawxU/njS9fdHoEi6xx9WI1zrw9m54chJfvRMQ/R8DB2v+BFdMyylsxY1EI6yTgm61qHCSSweEu1zm93VEhte4RJD0KePOvuqICQSdI1ScSojgtsc02v+Go3d1dI9db0YQEXTA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199021)(186003)(8936002)(8676002)(66946007)(66556008)(66476007)(5660300002)(54906003)(4326008)(6666004)(6486002)(316002)(38100700002)(478600001)(41300700001)(36756003)(26005)(53546011)(6506007)(6512007)(7416002)(86362001)(31696002)(83380400001)(44832011)(31686004)(2906002)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enlZRHh6KzBmc0JmY3hYazM2c3RpTGdwT0RXSFZTWVREdm9PWkpRZTYxV1VQ?= =?utf-8?B?Ui9sN1dRRTAvWkdROTZHQzIwa0Q4UkRPVGlBVGdyUXVSR2laRW1oRU03ZzlW?= =?utf-8?B?cVVQNk44aW9jWFVuUUp5VWdrbitQYldvTEFDMkltWWdSajlCNzZ6SFVaQTNs?= =?utf-8?B?L3R3YWxrUHVCVEJtUmhyNHN4UlBrZWJxd2tFak4yNm9sNEFpZ3FDL2sxTEhp?= =?utf-8?B?YmxGbUZQbEF0V2diMm5SRkJta0xpdWpTRHU5RHJjYXpJam9CT1BkUDR1bXBD?= =?utf-8?B?Q1QzVEpSNWVCZjRDVHk2a3ZwSXdQMTFnU3NhTCswRFIzRXA4OHcrQnJkYklI?= =?utf-8?B?dldUTkh4NDR2S0xvZkZuZ3RLUmEvVHJiRU1EcldCNXo5Mjl2VVVLVkZOdFow?= =?utf-8?B?Um1nQkFNOEU3S2prRzh2MHp2TFdFNWRrWVVGOVB2SjJWNGJ4WkRqMHBYQUhI?= =?utf-8?B?dnpWRmk1SVZQYml3ZWNPYllWWEp6b3ZzenQ2TGJ6ak1iRkozT2UyTDBmZHBu?= =?utf-8?B?K3pmNEtoU2c0Y1NKOVRQWVZpRFRza1pHZUVzOEJaR1gxSzd6VGJTN2JvbXhN?= =?utf-8?B?VkFxU2VYZjhOWDc5WU5uVDlray9NajFSZjZaTGM0R0xYNjdrRWFVUFNCNVVU?= =?utf-8?B?TUg4Ym5nUzc2a0Zvb2FCVWdUajNLZlk3eU13RFdOeWdTdEhJd3JhRDdxYzl3?= =?utf-8?B?c2xNdXN2R3h5TDhiR2lyUGtrK3FMMWNFYTVIOU5taDJON1lPbkdBQVprRVIv?= =?utf-8?B?cjdDWmIrdnUvbDdqVWxxZ08rbWlKaTkzN1RFTE9vMFVPVXlNM044MnlsaldN?= =?utf-8?B?VklPSGJFdnJVVCtGU2FWNGZ1UHhTekJxQXBHMHFaQWV4N01COThzVXRaM1Nm?= =?utf-8?B?cUhhWkNRcTFOU0xYNFc4dkZITiszZ1RVYmpMRjVnVnlRR1hEZnc3V3VtZlh5?= =?utf-8?B?SWx6UVJuOFM3WjNKc3k2cHVrMTUxd29QTExJcG4ycVVhQkxVR24zNzc5MUtH?= =?utf-8?B?OE1aditmT2dYT2ZRcnBIdU52S2hFQSswYkJ6aDFpS1B6NktVYTZzcTVTcmJF?= =?utf-8?B?aGlqek93UkI4UysvUzR5ajFwWFppWGhlYzhMbnJjdXVybEpRWUtpN1VLcmx4?= =?utf-8?B?OWd3S2Y3bStXbzYzSHVGSUhtemFZUUYxOVlJUHdUQUYrSUVpVnkzdWdMWFdK?= =?utf-8?B?bEdYNG9yNFU5NkRrMGlyRWdXUExFN3I3YXNudzFOb0haZC9LM3I5ZUJIT0gv?= =?utf-8?B?Nks1SHY0di9RdGFkSEZVSlVvc3Q5elNrcWVFaEtOZHpjZzVBbzlCbXd6WXhL?= =?utf-8?B?RFRsZTZ5a3plT2J1R2wwRGM0Yys5MmIvZ2hab2RWZmxPMkQvdUV1MlNyQ2lo?= =?utf-8?B?dVh5dWlhU3dSME1CZHNGeUgzWWtqT2QvUWJmZ0ZZSnExemoycHk3eUV2RzQ3?= =?utf-8?B?anB5RUdzcVRLZ2VSdjBBWEdFQkJCeGpHNm93RkFDL1NCa3UvYytNbzhjTUVx?= =?utf-8?B?NmZ1ZW8zNjNWamc1NWl0bXdTMXhkSkVnK2JtbDFSdm5BUTZ6VDhwRVJueDU1?= =?utf-8?B?aDltL1d1YjBaQ2twVzZEVWx2cjU5RGo4Tk5CZFJQbHd4Rlp5Z3VXWkZBcTVa?= =?utf-8?B?TjR2aStWcG1mTllOWUZEOHRFUXErNUo3OC83NUJicUpxazMrTzV0UlI4RkpT?= =?utf-8?B?WjcrM2RKMVY3Q29XN1BmZ1V6dHV1aHRGWkQ5ay9FTVJ2U0N6dHdnOXgxY1hG?= =?utf-8?B?TE9PVDhSeGFXaHBoTUNTNzlkeC80d1VzTDZaSHlJYVkzODVqT1o0L0p1djFS?= =?utf-8?B?S1J2am1HQk1kUGtSb0hNaXVXcXk0UHJJQmJ5Vk5aMmg1Sm9qUU1LMlRGdGg5?= =?utf-8?B?OVdwLzg4RzBvRlpTMFlEYmNneFZJWVdEcTlscUQ2bWFlSVdPOWZwc254OUE1?= =?utf-8?B?aTBxY29kVUk0K29BM1lnWTh5WWZwVjBqSDVIMU53Q3didDZta1oxckRpNXVV?= =?utf-8?B?cDE5Y21YRlFzQ3N5MGdKTFJqK2RnTDlrMnM1Q3NJMWRkbHNJMjNVcCtBRmZY?= =?utf-8?B?VSswTDJjY0FubzBnd2tENkFKZEExektQTWxqNitLQUtjQVpEQnV4ZngrV2hv?= =?utf-8?Q?WtwGSGpK0NBy3uMfBa3IbKNMT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 326dfd38-a9b1-4c6b-41e3-08db70c1e0d3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 12:37:00.8289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o1i2L1wodRwQcArVF7/aa28bcIqOlmBCchxX1wn5aS4kJYFGzPbNEF2uaUzsdFMw X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7933 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/12/2023 12:57 PM, Ferruh Yigit wrote: > On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote: >> The documentation for the FEC API is currently incomplete and contains >> inaccuracies in its descriptions of function parameters. >> Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set() >> is not well-defined. It does not provide information on what should >> be done if only AUTO bit is set or one of the specified FEC modes is >> not supported. Additionally, the fec_capa parameter in rte_eth_fec_get() >> implies that more than one FEC mode can be obtained, but it is >> wrong. Furthermore, the behaviour is undefined in >> rte_eth_fec_set() when the fec_capa parameter is zero. >> >> To address these issues, a patch series has been created that updates >> the FEC API documentation, renames one of the parameters to improve >> its clarity and adds a check for zero fec_capability. >> >> v2: >> * Update documentation for rte_eth_fec_set() to fix review comments. >> * Don't rename the fec_capa parameter of rte_eth_fec_get() but >> add a proper description instead. >> >> Denis Pryazhennikov (3): >> ethdev: update documentation for API to set FEC >> ethdev: check that at least one FEC mode is specified >> ethdev: update documentation for API to get FEC >> > > For series, > Acked-by: Ferruh Yigit > > Series applied to dpdk-next-net/main, thanks. > +cc Author and reviewer of original patch, if there is no objection I > can proceed with the set. > > > @Denis, can you please provide Fixes tags too? If you prefer you can > send a new version with ack and fixes tags. > Fixes: b7ccfb09da95 ("ethdev: introduce FEC API") Cc: stable@dpdk.org