From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFFE6439DC; Sat, 27 Jan 2024 09:33:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BC29402C4; Sat, 27 Jan 2024 09:33:42 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 11A134021D for ; Sat, 27 Jan 2024 09:33:40 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TMSTt22XmzvVKB; Sat, 27 Jan 2024 16:32:02 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id 9AE9118007B; Sat, 27 Jan 2024 16:33:37 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Sat, 27 Jan 2024 16:33:36 +0800 Message-ID: <975d9da7-8522-b6fb-770b-cdc186b9b7d1@huawei.com> Date: Sat, 27 Jan 2024 16:33:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RESEND v7 0/3] add telemetry cmds for ring From: Jie Hai To: , , , , , , CC: , , References: <20230117091049.20194-1-haijie1@huawei.com> <20231109102046.1277893-1-haijie1@huawei.com> In-Reply-To: <20231109102046.1277893-1-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thomas, Kindly ping for review. Thanks, Jie Hai On 2023/11/9 18:20, Jie Hai wrote: > This patch set supports telemetry cmd to list rings and dump information > of a ring by its name. > > v1->v2: > 1. Add space after "switch". > 2. Fix wrong strlen parameter. > > v2->v3: > 1. Remove prefix "rte_" for static function. > 2. Add Acked-by Konstantin Ananyev for PATCH 1. > 3. Introduce functions to return strings instead copy strings. > 4. Check pointer to memzone of ring. > 5. Remove redundant variable. > 6. Hold lock when access ring data. > > v3->v4: > 1. Update changelog according to reviews of Honnappa Nagarahalli. > 2. Add Reviewed-by Honnappa Nagarahalli. > 3. Correct grammar in help information. > 4. Correct spell warning on "te" reported by checkpatch.pl. > 5. Use ring_walk() to query ring info instead of rte_ring_lookup(). > 6. Fix that type definition the flag field of rte_ring does not match the usage. > 7. Use rte_tel_data_add_dict_uint_hex instead of rte_tel_data_add_dict_u64 > for mask and flags. > > v4->v5: > 1. Add Acked-by Konstantin Ananyev and Chengwen Feng. > 2. Add ABI change explanation for commit message of patch 1/3. > > v5->v6: > 1. Add Acked-by Morten Br?rup. > 2. Fix incorrect reference of commit. > > v6->v7: > 1. Remove prod/consumer head/tail info. > > Jie Hai (3): > ring: fix unmatched type definition and usage > ring: add telemetry cmd to list rings > ring: add telemetry cmd for ring info > > lib/ring/meson.build | 1 + > lib/ring/rte_ring.c | 135 +++++++++++++++++++++++++++++++++++++++ > lib/ring/rte_ring_core.h | 2 +- > 3 files changed, 137 insertions(+), 1 deletion(-) >