From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3223F41E65; Fri, 10 Mar 2023 17:09:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13DB440A8B; Fri, 10 Mar 2023 17:09:29 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2071.outbound.protection.outlook.com [40.107.212.71]) by mails.dpdk.org (Postfix) with ESMTP id 0B38640685 for ; Fri, 10 Mar 2023 17:09:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DLMIKQlrDLWOlyv+4iTUSSJdK1/EByyGr137t1dJC0ep1I7NZrRrOQad7jZ/ijkGs4/3EQyfMoJt+2cUN5KJaYq+QwIpZ1RVU2k6FNcF97CiXpD5QBQPWvaWOOPSPHHQaODHnFGiHcv6WnueJgqAotYHeP4u/z377GLwsi2c6qrIj8kLZt58/MAsw0AtIpyhzId4fqqdA04HirPkbpMnPkffZvLsr3iWdSjIRolSse/0Mjh41qK/6eBAeXqFQv46NYgrUQAeyLZwgJK/2H/9DNHVaWBeM9xECqRA4u3E3dVh+LzznDxSbND96esDRNnT36S22zoPA6N5XqVm9GF25Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DEp6g1NAGPcZGqbVIin8cCCi01bUGYQwQi4kv44Jn0o=; b=F8yEGdpPRwcWaBIcYBqsOWsnseA9uWq/CXIRrrQfdDDfJhFTlIfRMAZBYKnjKef0pwuT+bVqu3avc3SkamC/o9bvon6WzbuCN/7+/QZw2M7GnQae3WcTOgKbo+VxHPDF44h8ypcbnZniG8nRy1BjIn16PxcEuGR6RsE9idTA0YTFwpq2qFPWz+NLY8TWQXo9JWtaxtMdI6kZB8laMyOOJ+2UFghYJbEtLLejb3fL4Ms3l3HofETIvbUbM6wL3Qy4Nl9iH7nhIT9kYhhpYHXv5fG94cLBMOfq+bu2xDoGUkEVCQ/dDeaXBvg8cKjkB1knnZxWwBREvQ7XIRU8COgzVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DEp6g1NAGPcZGqbVIin8cCCi01bUGYQwQi4kv44Jn0o=; b=nZcl2GAVWysE4CWIlXJ4GN3hliF6JUodbeHGXPHpTu03enU1MF3DhIkWSavVpQvN4+dV2pZ3RzmjuMroJ2+86vxHjjKWF0/vq9SkYJm8w7VBnpZ0Np0KQroL6OBl8e6HWHF08mVHJiGIxeTbXTAeDjNEJ5z3pbfdyldjJ2PKB3E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7355.namprd12.prod.outlook.com (2603:10b6:510:20e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 16:09:25 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 16:09:25 +0000 Message-ID: <97609cce-1884-e820-80c7-ed46491684a2@amd.com> Date: Fri, 10 Mar 2023 16:09:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] net/sfc: replace of RTE_LOGTYPE_PMD Content-Language: en-US To: Andrew Rybchenko , Stephen Hemminger Cc: Vijay Kumar Srivastava , dev@dpdk.org References: <20230223031021.167490-1-stephen@networkplumber.org> <48a9058e-14e6-db7c-887b-4ead51c3fd48@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <48a9058e-14e6-db7c-887b-4ead51c3fd48@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0681.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7355:EE_ X-MS-Office365-Filtering-Correlation-Id: c290d059-e2f9-4cee-ce91-08db2181d197 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0omN4hnXDh/izrw7ZfwdreBdUv9yw+23Y0469GLLhJRzzJosKUpsf54NLJDQ1S3pHOSlD6iOxqDnfaRvd7a66kDxgF0SG777dUthUf+n5ObiKcr23JpLEWhbjftbnPnl8thdLGsbyH8QlWC/2GFZAMdsabggoVS2cYQ78/no9ZsVfom3N75fMxca5kCI5v5LuzPB/5UIQjElL4jqvCmLQ03Tk8VvyN7vcAmr4GiAz9kY9+iYdU4k7rHKGao7eDlrAFyltyyu0YZW4VshWUjaZxznKi9f3hveCGCvLs8o3TAuuynxWFjlsIEpACN5PKr7MXSuz5EXWtZj1cqHa9T5JppGzdklIdMr/tCgLH5HMmTP2AOBEwvWwbV/S0zd66ilvjKBPPKHq9HzzJJRW01hpJoCsmHWUssGLWipUqlfArmIeJLDwgYYH1nURZSRwz5X/m56r+xAweRH4FDqsb+SjohuhTy6anferPaYTT1ztPmXTHLXEoXm1/njYHtuCohjdwc4YH3vblNEFLiUBUbVRvcOQuNnJDRLiC/NILl64U7Yie2Ea+AZ7/ngLVamlIrffCZgdSVDybuk92fcW0za3niXr3r6bcLgyqBjsrGb8bAK+A2BGRaR65eFSyNWQm+lVpis4haoUnfmnxH69ZahNbdL1BcOoQV45VLRV4Xo3IEKylCcrOslO8zeLz7CNV+ciJr++5zzjAzbwnVzFWUvqN7qQpVtY8s0tiW1avRdXcs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(376002)(136003)(39860400002)(346002)(396003)(451199018)(8936002)(36756003)(4744005)(5660300002)(26005)(6506007)(53546011)(6666004)(38100700002)(186003)(2616005)(86362001)(6512007)(316002)(31696002)(8676002)(4326008)(66946007)(110136005)(41300700001)(66556008)(66476007)(478600001)(6486002)(31686004)(2906002)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkZzSFhZT1BoclgySVNmbEtnbDA0NDAzdkcwODhtZmdBbUVuU3J5bTQxVlVl?= =?utf-8?B?RGgwbnVDbmxLVFVtK2ZadEpuQS8rQmd5V3VPcjQ3UGhnOXRuN2RRV2ttR0ho?= =?utf-8?B?WTNOaHo4WW44cXFpNTNGQ2toUVRPVGdzR3JEZHBLeldFNktTeERBM3lOOXJU?= =?utf-8?B?UkRGd3JDMytpK2Fkc3RkMEh5amtMQkR2aGNnRjFkOUhkV01HcDVrSzdqMGZY?= =?utf-8?B?U216U3lYQ3F3Q2ZOcjFrQzRKaFR5NVJ2NFhlcUdXK1Z0bjdqQTE4bWFpelZD?= =?utf-8?B?L2YwOGxEM0h5YXFXcjJXbFJIWUpVUFpxTkZHaExoRUVqTlBWVjMxTHVhdWM5?= =?utf-8?B?UzRaUEZjNkRqbUpaR1hFVGx3UWZrVkJ3a0dRV25ja0Z0NzlRUG1Ic1RZTnFk?= =?utf-8?B?cWhyV3ArVmw4YnZaOWcxamZUZ0NrK2M5dWJ1eWtMZnd4RnZzS0hYM1llNzRY?= =?utf-8?B?NTN0THRINnNCUk42Z09vNUdEdjBQb21YTkFUclJ6S1pKMEFvZEtia3hFMTdW?= =?utf-8?B?ZWJkWkc0dlNjN3Vnb1hjVVpBdHNpeEZrL3hzeW95Q0ttR0h2UDZwUFZBNjJP?= =?utf-8?B?QnRKQkJUMkdiUnlHS2xSWDJ0aWw5LzdTOXRVWW8rQTBkYnhySElOUDA0cUZk?= =?utf-8?B?MEVTVzNycnN6UkcyTUJjVUdOZXlMMzhNWU9sb0tyUFQxSjRKRDJrN3EvU0lX?= =?utf-8?B?SkFSTlRrTmdNZDVwWVVScHNwb3lnOVZ1clpieXFnY1NxZGdWckJ2UUJ3QWFh?= =?utf-8?B?L2c4eUdkSWl5aE1STHc2SGVvS1h0N3J0bS9kSndZQW5nU2loMjY3TkRpZ2lO?= =?utf-8?B?OGdIUVdvak1PUkJPMnVpZ3I5dUZ1dUxwUFRpejFRcEFmcWZvRGxiN2RHRVhv?= =?utf-8?B?WnZCRmY5S0ZJTTVTQkhwZjdTL3NYSXNQQWlPdHRTR3huaElIQUQ2Q3pXUUEy?= =?utf-8?B?Rys2NGdBUXp2ajZ3Y09CZlBOaTA5eWZpd0hHQ3AxWmVVdU9lT3kwNFV3MjFt?= =?utf-8?B?QTltQ3VxUzA2SjIxdXArWDN0THFRS3hQeTQ5a2wrUjhub0xIeUwvT1RLazJh?= =?utf-8?B?Y3BNQmphbHlpV0dVMjlOeDBjVWhYTkordWs1S284SGtwdEtDT09FMXhmRC9R?= =?utf-8?B?dHFUTXo1clFvTGo3REROamFUb2dTTWloY0R0a3NjOWNrc3J1bUdpWkpjMjVj?= =?utf-8?B?SDlkSkRNc3k0a1VaRU56eDllK2dRSVhBNXVlWXpHSUZqRFRqUGFsaVJFQ25D?= =?utf-8?B?YzJzSTkrYndDdlJHRWdMTHN0U1JrNXVDdVY0UlV6ZHBDYnpXVWxDSzcvOVdD?= =?utf-8?B?SzV0d1RoRUw5eHRJK1ZCYm1MWW5icm0vUzBZZTFGT1pJdzNDVWNVMnNzZm5t?= =?utf-8?B?a2dMSHpRWTFCWDNZeXI0K0N1V0dlWGsvbzl2M001MUtnR0Q0d1VVYS9IWXVH?= =?utf-8?B?bFRGSGFrbEV3ZkhkRGt4cmZmbE5sRFNqVlJpTGJUQmpxaE15MW1TdkRTZEtn?= =?utf-8?B?Y3pyOEtDTWlZbVhRT3o4VUZrQXpwVnQrU0ZZeVprWHh0TU9aSmdSd2E2ZTU3?= =?utf-8?B?YUpRZkgwekdJTU5xSWpabVpZYjNxR3pIRFVZWEV2SWJOcmttUHQwRnlYUFha?= =?utf-8?B?R2dFMmpHM2dpdWhGay9PdWlXc2VONFhWYzAydjRLZGVKU0MzbjRIeFZSTEZx?= =?utf-8?B?TkRPVFJsWTlNK3lVcm1pZDlNQXp2NVBtZTBGS20xdXMzc3lLT1h0U0NJSFA1?= =?utf-8?B?b3VsWU1ZcTJ5YzkyNytyODhPenpHaWwxTW82Z1loZDZlYVV1NjJJZVRhMVo5?= =?utf-8?B?a0dVNFpEWHlwcmg5S1RHd21UWCtTVFZ4L2l1OUdsREtzRDFrTmFHOGFiRkE1?= =?utf-8?B?V2VDQjJGUEpLUW5GUEJCZzl4TEhjV2pkM3dBN1BLUEcwdnZwSHUxNHhONGpG?= =?utf-8?B?SGxLV0VraEptNHdHSVd4RWNsSDl0eCtLWHEyeTFjamdudDZSQXN3VWtvZDdz?= =?utf-8?B?K1BiVnI0RkkxcWw0andTZXZRemtEYjJ6WUNHU21zSEVZemRSYkRBWWR3eklt?= =?utf-8?B?MnpCbjZ6VXR4UStXRzY4NVNCKzNhcmxiMTFuWmRJS0ZxYnVUWXVxTjRuaFhl?= =?utf-8?Q?xqOWMKY35kc0GAAuf4gCeE6vi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c290d059-e2f9-4cee-ce91-08db2181d197 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 16:09:25.6298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kDOlaj4yRxoFd1HVayL6GfMqDk4DfWSg7t70sElYaYsjuxRanlvqCS4T/6UgSCgC X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7355 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2023 2:22 PM, Andrew Rybchenko wrote: > On 2/23/23 06:10, Stephen Hemminger wrote: >> The static LOGTYPE PMD will go away in the future. >> Replace its use in the sfc driver with the same static >> type as is already used in RTE_LOG_REGISTER macro. >> >> These drivers are trying to do things that other drivers are not >> in creating log types. IMHO it should follow the other driver >> usage pattern. But this patch leaves the special code. >> >> Signed-off-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko > > Applied to dpdk-next-net/main, thanks.