From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9707BA04A2;
	Thu,  3 Mar 2022 08:39:29 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 38BFE40687;
	Thu,  3 Mar 2022 08:39:29 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5A04A40141
 for <dev@dpdk.org>; Thu,  3 Mar 2022 08:39:27 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 34A2041;
 Thu,  3 Mar 2022 10:39:26 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 34A2041
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1646293166;
 bh=CCydrcDEZRLrBPJvS85VUkhXFScaa0CmYhDdcf1JUfo=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=t1L6QSeRLBPUXxWBGfg4fWkqWkpl7fZsyZ3CqUPQeuXElMYUgDxTzgu2W+FO7WkwV
 Vi4TjlPmmboDNfvH14zwGdLYP2toMxDUNmOGOr+4GpOLNVnw3i9XkRwbTO6nsosz/h
 A+0f47D41m8ysXfdQ3mc7khwfc0gXhhlBHTtvs0I=
Message-ID: <9775f557-9c1b-9969-f774-9a24d573dffe@oktetlabs.ru>
Date: Thu, 3 Mar 2022 10:39:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 16/20] net/sfc: fix a memory leak in error handling
Content-Language: en-US
To: Weiguo Li <liwg06@foxmail.com>, dev@dpdk.org
Cc: adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com,
 bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com,
 hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com,
 simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com,
 shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org,
 kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com,
 declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com
References: <cover.1645551559.git.liwg06@foxmail.com>
 <tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <tencent_10003CF1A7A111C93A6DDF4023B222743108@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/22/22 21:18, Weiguo Li wrote:
> When efx_nic_get_board_info() failed then function return, the
> memory in 'id' is not released, this leads to a memory leak.
> 
> Fixes: e86b48aa46d4 ("net/sfc: add HW switch ID helpers")
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>